On Thursday 09 April 2009 11:22:48 pm Chris Frey wrote:
> ---
> src/kdepim_sync.cpp | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/src/kdepim_sync.cpp b/src/kdepim_sync.cpp
> index 1bfc5f1..0139c3f 100644
> --- a/src/kdepim_sync.cpp
> +++ b/src/kdepim_sync.cpp
> @@ -146,11 +146,14 @@ void *kde_initialize(OSyncPlugin *plugin,
> OSyncPluginInfo *info, OSyncError **er
>
> osync_bool kde_discover(OSyncPluginInfo *info, void *userdata, OSyncError
> **error) {
> + OSyncList *l, *list = NULL;
> osync_trace(TRACE_ENTRY, "%s(%p, %p, %p)", __func__, userdata, info,
> error);
>
> - int num_objtypes = osync_plugin_info_num_objtypes(info);
> - for (int n = 0; n < num_objtypes; n++)
> - osync_objtype_sink_set_available(osync_plugin_info_nth_objtype(info, n),
> TRUE); + list = osync_plugin_info_get_objtype_sinks(info);
> + for (l=list; l; l = l->next) {
> + OSyncObjTypeSink *sink = (OSyncObjTypeSink *) l->data;
> + osync_objtype_sink_set_available(sink, TRUE);
> + }
Here is a osync_list_free of *list missing.
(We should mention the free call in the API documentaiton)
Beside that it looks good.
>
> // set information about the peer (KDE itself)
> {
Best Regards,
Daniel
--
Daniel Gollub Geschaeftsfuehrer: Ralph Dehner
FOSS Developer Unternehmenssitz: Vohburg
B1 Systems GmbH Amtsgericht: Ingolstadt
Mobil: +49-(0)-160 47 73 970 Handelsregister: HRB 3537
EMail:
gollub@... http://www.b1-systems.deAdresse: B1 Systems GmbH, Osterfeldstraße 7, 85088 Vohburg
http://pgpkeys.pca.dfn.de/pks/lookup?op=get&search=0xED14B95C2F8CA78D------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com_______________________________________________
Opensync-devel mailing list
Opensync-devel@...
https://lists.sourceforge.net/lists/listinfo/opensync-devel