« Return to Thread: [PATCH 0/5] reduce exclusive ilock hold times V2

Re: [PATCH 3/5] xfs: reduce ilock hold times in xfs_setattr_size

by Mark Tinguely-3 :: Rate this Message:

| View in Thread

On 03/27/12 09:34, Christoph Hellwig wrote:
> We do not need the ilock for most checks done in the beginning of
> xfs_setattr_size.  Replace the long critical section before starting the
> transaction with a smaller one around xfs_zero_eof and an optional one
> inside xfs_qm_dqattach that isn't entered unless using quotas.  While
> this isn't a big optimization for xfs_setattr_size itself it will allow
> pushing the ilock into xfs_zero_eof itself later.
>
> Signed-off-by: Christoph Hellwig<hch@...>


Looks good.

Reviewed-by: Mark Tinguely <tinguely@...>

_______________________________________________
xfs mailing list
xfs@...
http://oss.sgi.com/mailman/listinfo/xfs

 « Return to Thread: [PATCH 0/5] reduce exclusive ilock hold times V2