« Return to Thread: [PATCH v2] Fix crash when a stencil routine is missing

Re: [PATCH v2] Fix crash when a stencil routine is missing

by Patrick McCarty-3 :: Rate this Message:

Reply to Author | View in Thread

On Sun, Jul 05, 2009 at 08:22:02PM -0700, Graham Percival wrote:
> On Sun, Jul 05, 2009 at 06:01:21PM -0700, Patrick McCarty wrote:
> > On Sun, Jul 05, 2009 at 05:39:45PM -0700, Graham Percival wrote:
> > >
> > > -dwarning-as-error
> > > looks fine to me.
> >
> > Okay.  On second thought, it looks decent to me too.
>
> Wasn't that your initial proposal?  Did I misread the patch?

I was reusing Jan's name for the option, and initially I was not sure
I liked the name.  Now I think the name looks okay (semantically).

> > > ... oh wait, here it is:
> > > #(ly:set-option 'point-and-click #f)
> >
> > I think Han-Wen suggested to enable this option for the entire
> > regression test suite, so adding this option to every single
> > regression test would not be reasonable.
> >
> > In other words, some makefile hacking is needed, which I would
> > probably need to delegate.
>
> I doubt that the regtests compile without warnings, and I'm not
> certain that we have enough Frogs to eat all the issues that would
> be added if we went this route.
>
> (I'd love to be proven wrong about this, though!)

The patch will enable warnings by default for every missing stencil,
but the new option will enable *errors*, causing the regression test
suite to fail.

Since I don't know how to enable the new option for the entire test
suite, I'm presently compiling the docs and will examine the logs for
the new warnings.

Thanks,
Patrick


_______________________________________________
lilypond-devel mailing list
lilypond-devel@...
http://lists.gnu.org/mailman/listinfo/lilypond-devel

 « Return to Thread: [PATCH v2] Fix crash when a stencil routine is missing