On Thu, Jun 21, 2012 at 3:34 PM, Tobias Burnus <burnus@...> wrote:
> On 06/20/2012 11:28 PM, Janne Blomqvist wrote:
>> the attached patch makes the FTELL intrinsic function work on offsets
>> larger than 2 GB on 32-bit systems that support large files. As this
>> is an ABI change the old library function is left untouched, to be
>> removed when/if the library ABI is bumped.
>> Regtested on x86_64-unknown-linux-gnu, Ok for trunk?
> The patch is okay; however, I wonder whether a name like "ftell64" or
I considered that, but since gfc_intio_kind is not guaranteed to be 8
I thought it wouldn't be a good choice. So I just used a simple
sequential number; it shouldn't matter that much anyway since it's not
visible to the user.
> and a comment mentioning additionally the large-file support will
> help when reading the file.
I enhanced the comment above the ftell2 function in libgfortran to
hopefully explain the issue better.
> Thanks for the patch.
Thanks for the quick review! Committed as r188858.