On Sun, Jun 10, 2012 at 4:16 PM, Marc Glisse <marc.glisse@...> wrote:
> currently, tree-ssa-ifcombine handles pairs of imbricated "if"s that share
> the same then branch, or the same else branch. There is no particular reason
> why it couldn't also handle the case where the then branch of one is the
> else branch of the other, which is what I do here.
> Any comments?
The general idea looks good, but I think the patch is too invasive. As far
as I can see the only callers with a non-zero 'inv' argument come from
ifcombine_ifnotorif and ifcombine_ifnotandif (and both with inv == 2).
I would rather see a more localized patch that makes use of
invert_tree_comparison to perform the inversion on the call arguments