Re: [Phpmyadmin-svn] SF.net SVN: phpmyadmin:[12782] branches/gsoc/derek/phpMyAdmin/libraries/ import

[Michal Čihař]

Hi

Dne Wed, 12 Aug 2009 22:34:25 +0000
drummingds1@... napsal(a):

> Log Message:
> -----------
> Fixed include path problem for demo server. Import panel now displays as intended.
>
[...]

> +$loc1 = getcwd() . '/libraries/PHPExcel/';
> +$loc2 = '../libraries/PHPExcel/';
> +
> +if (file_exists($loc1)) {
> +    $path = $loc1;
> +} else {
> +    $path = $loc2;
> +}
> +
>  /* Append the PHPExcel directory to the include path variable */
>  set_include_path(get_include_path() . PATH_SEPARATOR . getcwd() . '/libraries/PHPExcel/');

How is this supposed to work without using $path anywhere?

Also the cwd should always be top level phpMyAdmin directory (too many
things rely on this), when is it different?

--
        Michal Čihař | http://cihar.com | http://phpmyadmin.cz


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@...
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

[Derek Schaefer]

On Wed, Aug 12, 2009 at 5:42 PM, Michal Čihař<michal@...> wrote:

> Hi
>
> Dne Wed, 12 Aug 2009 22:34:25 +0000
> drummingds1@... napsal(a):
>
>> Log Message:
>> -----------
>> Fixed include path problem for demo server. Import panel now displays as intended.
>>
> [...]
>> +$loc1 = getcwd() . '/libraries/PHPExcel/';
>> +$loc2 = '../libraries/PHPExcel/';
>> +
>> +if (file_exists($loc1)) {
>> +    $path = $loc1;
>> +} else {
>> +    $path = $loc2;
>> +}
>> +
>>  /* Append the PHPExcel directory to the include path variable */
>>  set_include_path(get_include_path() . PATH_SEPARATOR . getcwd() . '/libraries/PHPExcel/');
>
> How is this supposed to work without using $path anywhere?

I must have missed copying the modified "set_include_path" line there.
The other one was fine.

But in any case, it matters not. I thought the XLSX module wasn't
working on the demo server because the CWD value there was somehow
different than a default installation, but rather it was a just a
silly typo. Thus, I will be reverting the path changes here.

> Also the cwd should always be top level phpMyAdmin directory (too many
> things rely on this), when is it different?
>
> --
>        Michal Čihař | http://cihar.com | http://phpmyadmin.cz
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@...
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel