Re: [Pkg-octave-devel] Bug#548843: octave-signal: please include adsgn.m, cdsgn.m & co

[Paul Brossier-3]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

As Thomas Weber suggested, this list is probably a better place for this
wishlist item.

Would it be possible to include in the octave-signal package the
'octave' toolbox of Christophe Couvreur, available under a BSD license:

   http://www.mathworks.com/matlabcentral/fileexchange/69

Thanks, piem


Thomas Weber wrote:

> On Tue, Sep 29, 2009 at 06:30:52AM +0200, Paul Brossier wrote:
>> Package: octave-signal
>> Version: 1.0.9-1+b1
>> Severity: wishlist
>>
>> Hi,
>>
>> It would be neat if this package could also ship the files from the
>> 'octave' toolbox of Christophe Couvreur, available under a BSD license:
>>
>>   http://www.mathworks.com/matlabcentral/fileexchange/69
>
> I agree about the "neat" part, but I will not do this in Debian, that's
> why I'm closing this bug immediately. Contributing to octave-forge
> directly is easy and will benefit every Octave user, not just Debian.
>
> I suggest you ask on octave-forge's list directly. Maybe someone is
> interested or you can contribute the files yourself.
>
> See http://octave.sourceforge.net/ or mail
> octave-dev@... directly. Please note that
> octave-forge's bug tracker is rarely used.
>
> BTW, thanks for maintaining fftw.
>
> Thanks
> Thomas
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrCUTMACgkQkuC958YALL0JRgCgipzoQzq3Qymr3zVUay0PG7Ot
FoEAoK/p+Q0pK7ODWAoBqV2wpIoFhB0X
=4tLv
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev

[Søren Hauberg]

tir, 29 09 2009 kl. 20:25 +0200, skrev Paul Brossier:
> Would it be possible to include in the octave-signal package the
> 'octave' toolbox of Christophe Couvreur, available under a BSD license:
>
>    http://www.mathworks.com/matlabcentral/fileexchange/69

I don't have any objections about including this code, but I would
appreciate comments from users of the 'signal' package.

I do have one question though: have you asked Christophe about this? I
know the BSD license gives us permission to include his code, but I
think it would be polite ask him first.

Søren


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev

[Paul Brossier-4]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Søren and all,

Søren Hauberg wrote:

> tir, 29 09 2009 kl. 20:25 +0200, skrev Paul Brossier:
>> Would it be possible to include in the octave-signal package the
>> 'octave' toolbox of Christophe Couvreur, available under a BSD license:
>>
>>    http://www.mathworks.com/matlabcentral/fileexchange/69
>
> I don't have any objections about including this code, but I would
> appreciate comments from users of the 'signal' package.
>
> I do have one question though: have you asked Christophe about this? I
> know the BSD license gives us permission to include his code, but I
> think it would be polite ask him first.
>

I didn't and indeed should have. Christophe's email, as found on
mathworks.com is included in this message.

Christophe, would you agree on including your 'octave' toolbox in the
octave-signal package? The package is available here:
  http://octave.sourceforge.net/signal/index.html

One note about using this code in octave: given that the  bilinear
function in the octave-signal package "differs from the bilinear
function in the signal processing toolbox, which uses 1/T rather than
T", the call to bilinear in cdsgn.m and adsgn.m should be updated
accordingly:

% Use the bilinear transformation to get the digital filter.
[B,A] = bilinear(NUMs,DENs,1/Fs);

Also, the page at http://wiki.octave.org/wiki.pl?CategorySpeech could be
updated as follow:

 - Christophe Couvreur's octave
(http://www.mathworks.com/matlabcentral/fileexchange/69) has
C-weighting, A-weighting, octave and one-third-octave filter design
functions, as well as plotting functions to compare filter
characteristics to specifications.

Thanks, Paul
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrCsuwACgkQkuC958YALL0E7ACdFgI6zuVdXcceFXL2vJb2CdMk
lGUAn0z0yauUrPVW++U8PO3ql8Y7EJC5
=6Yos
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev

[Søren Hauberg]

ons, 30 09 2009 kl. 03:22 +0200, skrev Paul Brossier:
> Christophe, would you agree on including your 'octave' toolbox in the
> octave-signal package? The package is available here:
>   http://octave.sourceforge.net/signal/index.html

Let us know what he replies.

Søren


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev

[Couvreur, Christophe]

Hi Paul,

No problem.  I'm happy to have my "old" Octave toolbox included.

Regards,

- Christophe

-----Original Message-----
From: Paul Brossier [mailto:piem@...]
Sent: Wednesday, September 30, 2009 3:23 AM
To: Søren Hauberg; Christophe Couvreur
Cc: octave-dev@...; Thomas Weber
Subject: Re: [OctDev] [Pkg-octave-devel] Bug#548843: octave-signal: please include adsgn.m, cdsgn.m & co

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Søren and all,

Søren Hauberg wrote:

> tir, 29 09 2009 kl. 20:25 +0200, skrev Paul Brossier:
>> Would it be possible to include in the octave-signal package the
>> 'octave' toolbox of Christophe Couvreur, available under a BSD license:
>>
>>    http://www.mathworks.com/matlabcentral/fileexchange/69
>
> I don't have any objections about including this code, but I would
> appreciate comments from users of the 'signal' package.
>
> I do have one question though: have you asked Christophe about this? I
> know the BSD license gives us permission to include his code, but I
> think it would be polite ask him first.
>

I didn't and indeed should have. Christophe's email, as found on mathworks.com is included in this message.

Christophe, would you agree on including your 'octave' toolbox in the octave-signal package? The package is available here:
  http://octave.sourceforge.net/signal/index.html

One note about using this code in octave: given that the  bilinear function in the octave-signal package "differs from the bilinear function in the signal processing toolbox, which uses 1/T rather than T", the call to bilinear in cdsgn.m and adsgn.m should be updated
accordingly:

% Use the bilinear transformation to get the digital filter.
[B,A] = bilinear(NUMs,DENs,1/Fs);

Also, the page at http://wiki.octave.org/wiki.pl?CategorySpeech could be updated as follow:

 - Christophe Couvreur's octave
(http://www.mathworks.com/matlabcentral/fileexchange/69) has C-weighting, A-weighting, octave and one-third-octave filter design functions, as well as plotting functions to compare filter characteristics to specifications.

Thanks, Paul
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrCsuwACgkQkuC958YALL0E7ACdFgI6zuVdXcceFXL2vJb2CdMk
lGUAn0z0yauUrPVW++U8PO3ql8Y7EJC5
=6Yos
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev

[Søren Hauberg]

tor, 01 10 2009 kl. 00:27 +0200, skrev Couvreur, Christophe:
> No problem.  I'm happy to have my "old" Octave toolbox included.

Sorry 'bout the late reply. I think it is fine to include the code in
question in the 'signal' package. Would anybody care to suggest a patch?
(or send the files in question to this list, so I don't have to figure
out which files are relevant)

Søren


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev

[Paul Brossier-4]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Søren Hauberg wrote:
> tor, 01 10 2009 kl. 00:27 +0200, skrev Couvreur, Christophe:
>> No problem.  I'm happy to have my "old" Octave toolbox included.
>
> Sorry 'bout the late reply. I think it is fine to include the code in
> question in the 'signal' package. Would anybody care to suggest a patch?
> (or send the files in question to this list, so I don't have to figure
> out which files are relevant)
>
> Søren

Hello,

Thanks for your contribution Christophe! Attached is a patch that uses
the bilinear function as defined in octave-signal.

Best,
Paul


>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrc4dUACgkQkuC958YALL0AaQCfftfCiWnt90yNFH8LbQHSoYib
+3sAn0OnJcgB3eAZr3HjhCC30uhMBHQW
=ANeU
-----END PGP SIGNATURE-----

diff -ruNad a/octave/adsgn.m b/octave/adsgn.m
--- a/octave/adsgn.m      1997-08-26 20:01:59.000000000 +0200
+++ b/octave/adsgn.m        2009-10-19 21:50:05.000000000 +0200
@@ -29,5 +29,5 @@
 DENs = conv(conv(DENs,[1 2*pi*f3]),[1 2*pi*f2]);

 % Use the bilinear transformation to get the digital filter.
-[B,A] = bilinear(NUMs,DENs,Fs);
+[B,A] = bilinear(NUMs,DENs,1./Fs);

diff -ruNad a/octave/cdsgn.m b/octave/cdsgn.m
--- a/octave/cdsgn.m      1997-08-26 20:01:59.000000000 +0200
+++ b/octave/cdsgn.m        2009-10-19 21:50:05.000000000 +0200
@@ -26,5 +26,5 @@
 DENs = conv([1 +4*pi*f4 (2*pi*f4)^2],[1 +4*pi*f1 (2*pi*f1)^2]);

 % Use the bilinear transformation to get the digital filter.
-[B,A] = bilinear(NUMs,DENs,Fs);
+[B,A] = bilinear(NUMs,DENs,1./Fs);



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev

[Søren Hauberg]

tir, 20 10 2009 kl. 00:01 +0200, skrev Paul Brossier:
> Thanks for your contribution Christophe! Attached is a patch that uses
> the bilinear function as defined in octave-signal.

I'm sorry but I don't quite understand this patch. The functions you
want to patch doesn't seem to exist in the 'signal' package.

If you would like to see "adsgn.m, cdsgn.m & co" in Octave-Forge then
please send all code that should be included to this list. I don't have
the time or knowledge to dig through some page on the internet to figure
out what should be included, what should be changed and so forth.

Søren


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev

[Paul Brossier-4]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Søren,

Arg. Ok the former patch applies to Christophe's code, which indeed is
not yet in octave-signal.

Attached is the original tarball, to which the previous patch applies.
All files should go in octave-forge/main/signal/inst.

The license is MIT like, so COPYING and DESCRIPTION would need to be
updated.

Let me know if you want me to prepare a patch against trunk for that.

Thanks, Paul

Søren Hauberg wrote:

> tir, 20 10 2009 kl. 00:01 +0200, skrev Paul Brossier:
>> Thanks for your contribution Christophe! Attached is a patch that uses
>> the bilinear function as defined in octave-signal.
>
> I'm sorry but I don't quite understand this patch. The functions you
> want to patch doesn't seem to exist in the 'signal' package.
>
> If you would like to see "adsgn.m, cdsgn.m & co" in Octave-Forge then
> please send all code that should be included to this list. I don't have
> the time or knowledge to dig through some page on the internet to figure
> out what should be included, what should be changed and so forth.
>
> Søren
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrhrzsACgkQkuC958YALL2KdgCfaoA9S6gHi9lh05Uagsj7B5m1
WLMAn3LmEvYGRM/QZk9l1wfUMeZZdzcs
=Jzld
-----END PGP SIGNATURE-----



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev

[Søren Hauberg]

fre, 23 10 2009 kl. 15:27 +0200, skrev Paul Brossier:
> Attached is the original tarball, to which the previous patch applies.
> All files should go in octave-forge/main/signal/inst.
>
> The license is MIT like, so COPYING and DESCRIPTION would need to be
> updated.

I had a brief look at the files, and they did not include a license
statement. All code files uploaded to Octave-Forge should carry a
license statement, so the individual functions would need to be changed
to include a license. I did not see any mention of the license at all in
the stuff you sent. Where did you get the license information from?

> Let me know if you want me to prepare a patch against trunk for that.

Yes, please prepare a patch against SVN. Remember to update the 'INDEX'
file as well.

Søren


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Octave-dev mailing list
Octave-dev@...
https://lists.sourceforge.net/lists/listinfo/octave-dev