« Return to Thread: [Proposal] fix http.getFileList()

Re: [Proposal] fix http.getFileList()

by brettporter :: Rate this Message:

Reply to Author | View in Thread

+1. Neko is smaller than jtidy.

I wonder if it actually makes sense to bring in just a subset of neko  
to suit this purpose, either in source or binary form, to make it even  
smaller and to shade the classes?

- Brett

On 12/04/2008, at 1:19 PM, Joakim Erdfelt wrote:

> I'd like to fix a few faults in ...
>
> https://svn.apache.org/repos/asf/maven/wagon/trunk/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java
>
> ... with regards to detecting links.
>
> Jtidy is the main culprit, and the use of the various plexus string  
> utility functions to determine if a link belongs to the page itself  
> and not the parent folder or a downstream folder (this is not a  
> problem with plexus StringUtils, just a bad use of it, and a bad  
> assumption that all we needed was string manipulations), as well as  
> detecting if it is an absolute file vs a dynamic file.
>
> This was fixed in an alternative implementation found at ...
>
> http://svn.apache.org/repos/asf/maven/wagon/branches/wagon-http-with-webdav/src/main/java/org/apache/maven/wagon/providers/http/links/LinkParser.java
>
> ... using nekohtml with the java.net.URI class routines and straight  
> jaxp parsing.
>
> For the record, this is not a proposal for the other functionality  
> within wagon-http-with-webdav proof of concept, just the link  
> parsing and detecting needed by the Wagon.getFileList() method with  
> straight http wagons.
>
> - Joakim
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wagon-dev-unsubscribe@...
> For additional commands, e-mail: wagon-dev-help@...

--
Brett Porter
brett@...
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@...
For additional commands, e-mail: wagon-dev-help@...

 « Return to Thread: [Proposal] fix http.getFileList()