« Return to Thread: [RFC] drop plugin batch_commit for 0.40?

Re: [RFC] drop plugin batch_commit for 0.40?

by Juergen Leising :: Rate this Message:

Reply to Author | View in Thread

On Mon, Apr 13, 2009 at 02:09:45PM +0200, Daniel Gollub wrote:
 

> Example:
>
> - commit() call with change UID: 00001
> - plugin calls protocl specific code to commit change to peer
> - plugins retrieves the new ID of the change which got just committed. ID: 123
> - plugin now needs to call osync_changet_set_uid(change, "123");
> - then the commit function ends with osync_context_report_success()
>
> With the context reply (osync_context_report_sucess()) an internal function
> get called which reports the new UID to the internal mapping table.

Oh, that's interesting.  Did you know, that the file-sync plugin
changes the UID in file-sync/src/filename_scape.h   ?
Unfortunately, the filenames are the actual carrier for the UIDs.  

This causes some trouble in the LDAP plugin, which does not
expect such changes. I have tried a workaround in the LDAP plugin,
but I am not too happy with it.

So if I have understood you correctly, adding osync_changet_set_uid()
anywhere in the file-sync plugin is the solution for the problems
(which I do not fully overlook), isn't it?

Bye, bye,

Juergen



------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
Opensync-devel mailing list
Opensync-devel@...
https://lists.sourceforge.net/lists/listinfo/opensync-devel

 « Return to Thread: [RFC] drop plugin batch_commit for 0.40?