Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-277-gc9c3d43

View: New views
2 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-277-gc9c3d43

by Volker Lendecke :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Jul 08, 2009 at 08:00:18PM -0500, Jeremy Allison wrote:

> The branch, master has been updated
>        via  c9c3d4312d7281904fc4a1cc9abd4831cdf4bfb9 (commit)
>       from  58daaa3d1e7075b23c8709889be9b461c6c6c174 (commit)
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit c9c3d4312d7281904fc4a1cc9abd4831cdf4bfb9
> Author: Jeremy Allison <jra@...>
> Date:   Wed Jul 8 17:51:35 2009 -0700
>
>     The migration to struct stat_ex broke the calculation of
>     create time from the existing timestamps (for systems
>     that need to do this). Once the write time is changed
>     via a sticky write, the create time might need to be
>     recalculated. To do this I needed to add a bool into
>     struct stat_ex to remember if the st_ex_btime field
>     was calculated, or read from the OS. Also fixed the
>     returning of modified write timestamps in the return
>     from NTCreateX, SMBattr and SMBattrE (which weren't
>     taking into account the modified timestamp stored
>     in the open file table). Attempting to fix an issue
>     with Excel 2003 and offline files. Volker and Metze,
>     please review.
>     Jeremy
Hmmm. Sorry for the breakage.

Volker


signature.asc (204 bytes) Download Attachment

Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-277-gc9c3d43

by Jeremy Allison :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Thu, Jul 09, 2009 at 01:06:23PM +0200, Volker Lendecke wrote:

> On Wed, Jul 08, 2009 at 08:00:18PM -0500, Jeremy Allison wrote:
> > The branch, master has been updated
> >        via  c9c3d4312d7281904fc4a1cc9abd4831cdf4bfb9 (commit)
> >       from  58daaa3d1e7075b23c8709889be9b461c6c6c174 (commit)
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
> > commit c9c3d4312d7281904fc4a1cc9abd4831cdf4bfb9
> > Author: Jeremy Allison <jra@...>
> > Date:   Wed Jul 8 17:51:35 2009 -0700
> >
> >     The migration to struct stat_ex broke the calculation of
> >     create time from the existing timestamps (for systems
> >     that need to do this). Once the write time is changed
> >     via a sticky write, the create time might need to be
> >     recalculated. To do this I needed to add a bool into
> >     struct stat_ex to remember if the st_ex_btime field
> >     was calculated, or read from the OS. Also fixed the
> >     returning of modified write timestamps in the return
> >     from NTCreateX, SMBattr and SMBattrE (which weren't
> >     taking into account the modified timestamp stored
> >     in the open file table). Attempting to fix an issue
> >     with Excel 2003 and offline files. Volker and Metze,
> >     please review.
> >     Jeremy
>
> Hmmm. Sorry for the breakage.

No problem, this stuff is mind-bendingly nasty. There's
the same bug in 3.4.0 as well for slightly different reasons
(and previous of course), but it needs a different patch.

I'll open a bug and attach the fixes for 3.4.0.

Jeremy.