Re: [SCM] Samba Shared Repository - branch master updated

[Jelmer Vernooij-2]

Hi Matthias,

On Fri, Oct 23, 2009 at 07:28:04AM -0500, Matthias Dieter Wallnöfer wrote:

> The branch, master has been updated
>        via  4f8826f... ldb python bindungs - better use the "enum ldb_scope" for the search scope rather than "int"
>       from  b9a3f1d... s3: Fix crash in pam_winbind, another reference to freed memory.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit 4f8826ff7f4789c5b5f363b733a42053f72aa526
> Author: Matthias Dieter Wallnöfer <mwallnoefer@...>
> Date:   Fri Oct 23 14:26:41 2009 +0200
>
>     ldb python bindungs - better use the "enum ldb_scope" for the search scope rather than "int"
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  source4/lib/ldb/pyldb.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
>
> Changeset truncated at 500 lines:
>
> diff --git a/source4/lib/ldb/pyldb.c b/source4/lib/ldb/pyldb.c
> index d4a369c..136cd47 100644
> --- a/source4/lib/ldb/pyldb.c
> +++ b/source4/lib/ldb/pyldb.c
> @@ -1006,7 +1006,7 @@ static PyObject *py_ldb_schema_format_value(PyLdbObject *self, PyObject *args)
>  static PyObject *py_ldb_search(PyLdbObject *self, PyObject *args, PyObject *kwargs)
>  {
>   PyObject *py_base = Py_None;
> - int scope = LDB_SCOPE_DEFAULT;
> + enum ldb_scope scope = LDB_SCOPE_DEFAULT;
>   char *expr = NULL;
>   PyObject *py_attrs = Py_None;
>   PyObject *py_controls = Py_None;
> @@ -1348,7 +1348,8 @@ static PyObject *py_ldb_module_del_transaction(PyLdbModuleObject *self)
>  static PyObject *py_ldb_module_search(PyLdbModuleObject *self, PyObject *args, PyObject *kwargs)
>  {
>   PyObject *py_base, *py_tree, *py_attrs, *py_ret;
> - int ret, scope;
> + int ret;
> + enum ldb_scope scope;
>   struct ldb_request *req;
>   const char * const kwnames[] = { "base", "scope", "tree", "attrs", NULL };
>   struct ldb_module *mod;
>

Please revert this - this is intentional. PyArg_ParseTupleAndKeywords parses
and sets an integer, not an ldb_scope enum. The values it reads are not
necessarily valid ldb_scope values.

Cheers,

Jelmer

[Andrew Bartlett]

On Tue, 2009-10-27 at 12:18 +0000, Jelmer Vernooij wrote:
> Hi Matthias,
>

> Please revert this - this is intentional. PyArg_ParseTupleAndKeywords parses
> and sets an integer, not an ldb_scope enum. The values it reads are not
> necessarily valid ldb_scope values.

Matthias,

The reason this is a worry is that the size of an enum and the size of
'int' may differ, and this reverts a patch tridge put in only very
recently to fix python on 64 bit machines.

See commit c45a81ecf3229762b7074891b86d894c27489180

Perhaps you could continue to put your cleanup patches past another team
member, so they may advise on areas of history or complexity that you
haven't picked up on yet, just as you are on the const patches?

I know these changes seem trivial and safe, but we seem to be doing the
reviews (and finding issues) once they are in the tree, rather than
before they are merged.

(And yes, I've had my own suite of issues with patches that have been in
the tree without enough review and testing.  This is something we all
need to improve on).

Thanks,

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

[Volker Lendecke]

On Wed, Oct 28, 2009 at 06:11:21PM -0500, Simo Sorce wrote:

> The branch, master has been updated
>        via  04161b4... Fix map readonly in smb.conf, it is a single word
>       from  25f96a4... Add in Metze's new code to ndr encode the user.DOSATTRIB blobs. Next I'll change the create timestamp and dos attribute code to use this.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit 04161b44a035cb0330cecc06c2fd814c9c1211ff
> Author: Simo Sorce <idra@...>
> Date:   Wed Oct 28 19:10:08 2009 -0400
>
>     Fix map readonly in smb.conf, it is a single word

Hmmm. As far as I know spaces in parameter names do not
matter. Has that changed lately?

Volker

[Volker Lendecke]

On Thu, Oct 29, 2009 at 05:09:40AM -0500, Günther Deschner wrote:

> The branch, master has been updated
>        via  184afaa... s3-secrets: use autogenerated code for TRUSTED_DOM_PASS struct parsing from a tdb.
>        via  e92e332... s3: add secrets.idl.
>       from  83de5c8... tdb: update README a bit
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit 184afaa04ca90e089be0071ffb024a884d9d347f
> Author: Günther Deschner <gd@...>
> Date:   Wed Oct 28 16:42:44 2009 +0100
>
>     s3-secrets: use autogenerated code for TRUSTED_DOM_PASS struct parsing from a tdb.
>    
>     Guenther
>
> commit e92e33238c79a917db7af9b6dfbf06ebaaba9fd8
> Author: Günther Deschner <gd@...>
> Date:   Wed Oct 28 16:21:53 2009 +0100
>
>     s3: add secrets.idl.

Wow! Thanks for removing that piece of ugly code!

Volker

[simo-7]

On Thu, 2009-10-29 at 07:49 +0100, Volker Lendecke wrote:

> On Wed, Oct 28, 2009 at 06:11:21PM -0500, Simo Sorce wrote:
> > The branch, master has been updated
> >        via  04161b4... Fix map readonly in smb.conf, it is a single word
> >       from  25f96a4... Add in Metze's new code to ndr encode the user.DOSATTRIB blobs. Next I'll change the create timestamp and dos attribute code to use this.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
> > commit 04161b44a035cb0330cecc06c2fd814c9c1211ff
> > Author: Simo Sorce <idra@...>
> > Date:   Wed Oct 28 19:10:08 2009 -0400
> >
> >     Fix map readonly in smb.conf, it is a single word
>
> Hmmm. As far as I know spaces in parameter names do not
> matter. Has that changed lately?

It's for consistency,
when you run testparm you see "map readonly", and that's how it is
spelled in the code and also referenced in the "store dos attributes"
man page entry.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <simo@...>
Principal Software Engineer at Red Hat, Inc. <simo@...>

[simo-7]

On Fri, 2009-10-30 at 18:47 -0500, Björn Jacke wrote:

> The branch, master has been updated
>        via  4ae950d2.. ѕ3:buildsystem: fix depenencies for libreplace
>        via  72cec4a... ѕ3:ldap: search for account policies in objectclass sambaDomain, not *
>       from  d1ad143... s3/docs: Fix typo.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit 4ae950d211cfb17e086e4e3068ff351effb2b5a0
> Author: Björn Jacke <bj@...>
> Date:   Fri Oct 30 19:54:52 2009 +0100
>
>     ѕ3:buildsystem: fix depenencies for libreplace
>    
>     This problem became visible after adding the picky -z defs linker option: On
>     Solaris libreplace had unresolved symbols, which showed up in the libtalloc
>     build. PAM_WINBIND_EXTRA_LIBS and WINBIND_NSS_EXTRA_LIBS had been workarounds
>     to make things work at two placeѕ. These variables have been obsoleted now.
>     This patch introduces LIBREPLACE_LIBS which contans the linker flags needed for
>     linking anything using libreplace.

Björn are the standalone configuration scripts for talloc, tdb, tevent
fine, otherwise could you fix them too ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <simo@...>
Principal Software Engineer at Red Hat, Inc. <simo@...>