Re: [SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

On Sat, Nov 07, 2009 at 04:08:07AM -0600, Volker Lendecke wrote:

> The branch, master has been updated
>        via  5cdee7a... s3: Do the printing for DEBUGLEVEL>=10 centrally
>       from  843be3b... ldb_init: use constant for result of "ldb_setup_wellknown_attributes"
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit 5cdee7ae0565c08026b8845cd3090b20d8abc472
> Author: Volker Lendecke <vl@...>
> Date:   Sat Nov 7 10:28:40 2009 +0100
>
>     s3: Do the printing for DEBUGLEVEL>=10 centrally
>    
>     12 insertions(+), 10651 deletions(-)
>    
>     I think that says it all :-)

Oh that's *awesome* - thanks :-).

[Jeremy Allison]

On Mon, Nov 09, 2009 at 09:04:13AM -0600, Günther Deschner wrote:

> The branch, master has been updated
>        via  8eac307... s3-param: fix set_inherit_acls().
>       from  e6df4c2... pidl: Fix selftest after s3 code changed
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit 8eac3075b604d5d0938e2a087a154bb6546d78b1
> Author: Günther Deschner <gd@...>
> Date:   Mon Nov 9 16:02:24 2009 +0100
>
>     s3-param: fix set_inherit_acls().
>    
>     Jeremy, please check.

Perfectly correct - thanks !

Jeremy.

[Volker Lendecke]

On Thu, Nov 12, 2009 at 01:49:11PM -0600, Jeremy Allison wrote:

> The branch, master has been updated
>        via  83c2c17... Ensure every return path initializes presult as NULL. Ensures no crashes in calling code that forgets to init return as null. Jeremy.
>       from  21644c5... s4:heimdal_build: allow flex-2.5.35 with bison-2.3
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit 83c2c177a5e86d04da37384f1f04230c8274e1e6
> Author: Jeremy Allison <jra@...>
> Date:   Thu Nov 12 11:49:54 2009 -0800
>
>     Ensure every return path initializes presult as NULL.
>     Ensures no crashes in calling code that forgets to
>     init return as null.

Hmmm. The convention for a while was to not touch output
arguments if the result was not NT_STATUS_OK. Any particular
reason for this change in convention?

Volker

[Jeremy Allison]

On Thu, Nov 12, 2009 at 08:51:45PM +0100, Volker Lendecke wrote:

> On Thu, Nov 12, 2009 at 01:49:11PM -0600, Jeremy Allison wrote:
> > The branch, master has been updated
> >        via  83c2c17... Ensure every return path initializes presult as NULL. Ensures no crashes in calling code that forgets to init return as null. Jeremy.
> >       from  21644c5... s4:heimdal_build: allow flex-2.5.35 with bison-2.3
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
> > commit 83c2c177a5e86d04da37384f1f04230c8274e1e6
> > Author: Jeremy Allison <jra@...>
> > Date:   Thu Nov 12 11:49:54 2009 -0800
> >
> >     Ensure every return path initializes presult as NULL.
> >     Ensures no crashes in calling code that forgets to
> >     init return as null.
>
> Hmmm. The convention for a while was to not touch output
> arguments if the result was not NT_STATUS_OK. Any particular
> reason for this change in convention?

Yeah - for this code, bug 6889 which was caused by
calling code not initializing the return val and thus
crashing winbindd. I looked at some of the other callers
in the auth code and they were making the same mistake,
so I just made it safe.

Jeremy.