Re: [Spirit-general] warnings...

[Hartmut Kaiser]

> Lately, there's been talk in the Boost dev about making Boost
> libraries warning free. If anyone here really cares about them
> (most warnings are really nonsense), we'd appreciate your help
> in eliminating them. I know this is mechanical and boring work,
> so what I'll ask instead is to fix them incrementally. We'd
> appreciate it a lot if you can build with warnings on and report
> back offending files. It will be a plus if you can provide patches
> too. Thank you!

Just for the records (and to avoid that anybody wastes more time on this), I
patched the Spirit code base to be (almost) warning free while using MSVC
with highest warning level.

But if you want to work on eliminating gcc warnings, that's still open, so
be our guest. The goal is to be free of warnings while compiling the tests
with:

   cd $BOOST_ROOT/libs/spirit/test
   bjam gcc warnings=all cxxflags=-Wextra


Regards Hartmut

-------------------
Meet me at BoostCon
http://boostcon.com




------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Spirit-devel mailing list
Spirit-devel@...
https://lists.sourceforge.net/lists/listinfo/spirit-devel

[Daniel James]

On Mon, Nov 9, 2009 at 1:26 PM, Hartmut Kaiser <hartmut.kaiser@...> wrote:
>
> But if you want to work on eliminating gcc warnings, that's still open, so
> be our guest. The goal is to be free of warnings while compiling the tests
> with:
>
>   cd $BOOST_ROOT/libs/spirit/test
>   bjam gcc warnings=all cxxflags=-Wextra

If no one else wants to, I'll do this.

Daniel

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Spirit-devel mailing list
Spirit-devel@...
https://lists.sourceforge.net/lists/listinfo/spirit-devel

[Daniel James]

On Mon, Nov 9, 2009 at 6:49 PM, Daniel James <daniel_james@...> wrote:

> On Mon, Nov 9, 2009 at 1:26 PM, Hartmut Kaiser <hartmut.kaiser@...> wrote:
>>
>> But if you want to work on eliminating gcc warnings, that's still open, so
>> be our guest. The goal is to be free of warnings while compiling the tests
>> with:
>>
>>   cd $BOOST_ROOT/libs/spirit/test
>>   bjam gcc warnings=all cxxflags=-Wextra
>
> If no one else wants to, I'll do this.

A lot of warnings were fixed along with the visual c++ warnings. I
fixed a few warnings, but there are some more left, I'll try to fix
them soon.

https://svn.boost.org/trac/boost/changeset/57524

Daniel

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Spirit-devel mailing list
Spirit-devel@...
https://lists.sourceforge.net/lists/listinfo/spirit-devel

[Hartmut Kaiser]

> On Mon, Nov 9, 2009 at 6:49 PM, Daniel James <daniel_james@...>
> wrote:
> > On Mon, Nov 9, 2009 at 1:26 PM, Hartmut Kaiser
> <hartmut.kaiser@...> wrote:
> >>
> >> But if you want to work on eliminating gcc warnings, that's still
> open, so
> >> be our guest. The goal is to be free of warnings while compiling the
> tests
> >> with:
> >>
> >>   cd $BOOST_ROOT/libs/spirit/test
> >>   bjam gcc warnings=all cxxflags=-Wextra
> >
> > If no one else wants to, I'll do this.
>
> A lot of warnings were fixed along with the visual c++ warnings. I
> fixed a few warnings, but there are some more left, I'll try to fix
> them soon.
>
> https://svn.boost.org/trac/boost/changeset/57524

Thanks Daniel! That's appreciated!
Regards Hartmut

-------------------
Meet me at BoostCon
http://boostcon.com




------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Spirit-devel mailing list
Spirit-devel@...
https://lists.sourceforge.net/lists/listinfo/spirit-devel

[Joel de Guzman-2]

Hartmut Kaiser wrote:

>> On Mon, Nov 9, 2009 at 6:49 PM, Daniel James <daniel_james@...>
>> wrote:
>>> On Mon, Nov 9, 2009 at 1:26 PM, Hartmut Kaiser
>> <hartmut.kaiser@...> wrote:
>>>> But if you want to work on eliminating gcc warnings, that's still
>> open, so
>>>> be our guest. The goal is to be free of warnings while compiling the
>> tests
>>>> with:
>>>>
>>>>   cd $BOOST_ROOT/libs/spirit/test
>>>>   bjam gcc warnings=all cxxflags=-Wextra
>>> If no one else wants to, I'll do this.
>> A lot of warnings were fixed along with the visual c++ warnings. I
>> fixed a few warnings, but there are some more left, I'll try to fix
>> them soon.
>>
>> https://svn.boost.org/trac/boost/changeset/57524
>
> Thanks Daniel! That's appreciated!

Thanks Daniel!

Cheers,
--
Joel de Guzman
http://www.boostpro.com
http://spirit.sf.net
http://www.facebook.com/djowel

Meet me at BoostCon
http://www.boostcon.com/home
http://www.facebook.com/boostcon



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Spirit-devel mailing list
Spirit-devel@...
https://lists.sourceforge.net/lists/listinfo/spirit-devel

[Hartmut Kaiser]

> > Lately, there's been talk in the Boost dev about making Boost
> > libraries warning free. If anyone here really cares about them
> > (most warnings are really nonsense),
> I wanted to say that I do really care (strongly).
> Reasons (apart from the obvious ones):
> 1) when I do something with Spirit (which is for me maybe once in 2
> months...) and make a little mistake, it is very annoying to sift
> through
> pages of pages of compiler messages just to finally realize it was just
> a
> warning and not the error that caused these pages. That wastes time.
> (Maybe things are brighter with MS, but gcc prints lots of (loooong and
> hard
> to read) lines of templated stuff - even if it is just about a unused
> variable).
>
> 2) if that tons of nonsense are always there, it is difficult to detect
> if a
> new non-nonsense warning was introduced.
> (As most boost libs are header only, we always see both our own and
> boost's
> warnings and as a gcc warning for spirit code may well be huge... this
> is
> really important to us end-users. I took the time to measure gcc
> output: I
> got some 3MB (for a simple grammar; ok that included 1 error, too).
> I hope this number shows that it is a pain to check for your own
> warnings
> inside all the nonsense.

Sure, we try to reduce the warnings, that's the whole point of this exercise
:-P

> > we'd appreciate your help
> > in eliminating them. I know this is mechanical and boring work,
> > so what I'll ask instead is to fix them incrementally. We'd
> > appreciate it a lot if you can build with warnings on and report
> > back offending files. It will be a plus if you can provide patches
> > too. Thank you!
> I will.
>
> 2) Some warnings I got:
> boost/spirit/home/support/make_component.hpp:81: warning: unused
> parameter
> 'state'
> boost/spirit/home/support/modify.hpp:102: warning: unused parameter
> 'tag'
> boost/spirit/home/qi/nonterminal/error_handler.hpp:38: warning: unused
> parameter 'it'
> boost/spirit/home/qi/string/lit.hpp:91: warning: unused parameter
> 'context'
> boost/spirit/home/support/attributes.hpp:442: warning: unused parameter
> 'val'
> boost/spirit/home/support/attributes.hpp:442: warning: unused parameter
> 'attr'
> boost/spirit/home/qi/auxiliary/eol.hpp:47: warning: unused parameter
> 'context'
> boost/spirit/home/qi/auxiliary/eol.hpp:47: warning: unused parameter
> 'attr'
>
> boost/spirit/home/qi/detail/assign_to.hpp:90: warning: unused parameter
> 'attr'
> boost/spirit/home/support/info.hpp:130: warning: unused parameter
> 'depth'
> boost/spirit/home/qi/numeric/numeric_utils.hpp:26: warning: unused
> parameter
> 'last'
>
> (Is this ok as 'report'? If no: what should I send?)
>
>
> Maybe I find the time to start porting my "monster grammar" (scripting
> language of mine) to Spirit2.1 next weekend(s). That should lead to
> further
> input.

Those should have been addressed already. Did you update from SVN recently?

> And thanks for keeping improving Spirit; the new interface is a definite
> improvement over 'classic'.

Thanks!
Regards Hartmut

-------------------
Meet me at BoostCon
http://boostcon.com




------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Spirit-devel mailing list
Spirit-devel@...
https://lists.sourceforge.net/lists/listinfo/spirit-devel