Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[22840] branches/4.x/templates/tiki-install.tpl

View: New views
4 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[22840] branches/4.x/templates/tiki-install.tpl

by Marc Laporte-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi everyone!

Profile selection has been removed from installer. It remains in the
rest of the application (of course)

Just to give a bit of background on this decision:

I had been thinking about it for a while now and was on the fence. In
discussions at the TorontoTikiFest4 with Pascal St-Jean, who is
leading profiles effort, I became convinced removing profiles from
installer is the best option.

Benefits:
1- Simplify installer code
2- Users have less choices and worry of making the wrong one at install time
3- Profiles in installer didn't have user input mechanism, which is
very important. (and would have been more work to add)

This will streamline our profiles strategy.

In retrospect, they should never have been there. I think we were
conditioned by the fact the old profiles system were at installation
time only.  If our profiles had been what they are today since the
beginning, we perhaps would have never added them to the installer.
This is a litmus test of sorts in deciding if something is a new
feature and should be optional, vs a better new behavior that
everybody should get.

Best regards,

M ;-)

On Tue, Nov 3, 2009 at 12:57 PM,  <dexl_2000@...> wrote:

> Revision: 22840
>          http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=22840&view=rev
> Author:   dexl_2000
> Date:     2009-11-03 17:57:27 +0000 (Tue, 03 Nov 2009)
>
> Log Message:
> -----------
> [MOD] removed the profile selection and wording on the 5th installation process.
>
> Modified Paths:
> --------------
>    branches/4.x/templates/tiki-install.tpl
>
> Modified: branches/4.x/templates/tiki-install.tpl
> ===================================================================
> --- branches/4.x/templates/tiki-install.tpl     2009-11-03 17:43:12 UTC (rev 22839)
> +++ branches/4.x/templates/tiki-install.tpl     2009-11-03 17:57:27 UTC (rev 22840)
> @@ -238,7 +238,7 @@
>  </div>
>
>  {elseif $install_step eq '4'}
> -<h1>{if $tikidb_created}{tr}Install & Update Profile{/tr}{else}{tr}Install Profile{/tr}{/if}</h1>
> +<h1>{if $tikidb_created}{tr}Install & Upgrade{/tr}{else}{tr}Install{/tr}{/if}</h1>
>  {if $max_exec_set_failed eq 'y'}
>  {remarksbox type="warning" title="{tr}Warning{/tr}"}
>  {tr}Failed to set max_execution_time to 0 for PHP. You may experience problems when creating/upgrading the database on a slow system. This will manitest itself by a blank page.{/tr}
> @@ -248,13 +248,13 @@
>  <div class="clearfix">
>  <p>
>  {if $tikidb_created}
> -       {tr}Select the installation (or upgrade) profile to use. This profile will populate (or upgrade) the database.{/tr}<br/><br/>
> +       {tr}This install will populate (or upgrade) the database.{/tr}<br/><br/>
>        {tr}If you want to upgrade from a previous Tiki release, ensure that you have read and understood the <a href="http://doc.tikiwiki.org/Upgrade" target="_blank">Upgrade instructions</a>.{/tr}
>  {else}
> -       {tr}Select the installation profile to use. This profile will populate the database.{/tr}
> +       {tr}A new install will populate the database.{/tr}
>  {/if}
>  </p>
> -<p>{tr}Profiles can be used to pre-configure your site with specific features and settings.{/tr} {tr}Visit <a href="http://profiles.tikiwiki.org" target="_blank">http://profiles.tikiwiki.org</a> for more information.{/tr}</p>
> +{* <p>{tr}Profiles can be used to pre-configure your site with specific features and settings.{/tr} {tr}Visit <a href="http://profiles.tikiwiki.org" target="_blank">http://profiles.tikiwiki.org</a> for more information.{/tr}</p>  *}
>          {if $dbdone eq 'n'}
>                  {if $logged eq 'y'}
>                    {* we are logged if no admin account is found or if the admin user is logged in*}
> @@ -267,46 +267,30 @@
>        <tr>
>                <td valign="top">
>                        <fieldset><legend>{tr}Install{/tr}</legend>
> -{if $tikidb_created}
> -                       <script type="text/javascript">
> -                       <!--//--><![CDATA[//><!--
> -                               {literal}
> -                               function install() {
> -                                       document.getElementById('install-link').style.display='none';
> -                                       document.getElementById('install-table').style.visibility='';
> -                               }
> -                               {/literal}
> -                       //--><!]]>
> -                       </script>
> -                       <div id="install-link">
> -
> -                       <p style="text-align:center"><a class="button" href="javascript:install()">{tr}Reinstall the database{/tr}</a></p>
> -                       <p style="text-align:center"><img src="pics/icons/sticky.png" alt="{tr}Warning{/tr}" style="vertical-align:middle" /> <strong>{tr}Warning:{/tr}</strong> {tr}This will destroy your current database.{/tr}</p>
> -                       </div>
> -                   <div id="install-table" style="visibility:hidden">
> -                       {else}
> -                   <div id="install-table">
> -                       {/if}
> -                        {if $tikidb_created}<p style="text-align:center"><img src="pics/icons/sticky.png" alt="{tr}Warning{/tr}" style="vertical-align:middle"/> <strong>{tr}Warning:{/tr}</strong> {tr}This will destroy your current database.{/tr}</p>{/if}
> -                       {if $has_internet_connection eq 'y'}
> -                         <p>{tr}Create a new database (clean install) with profile:{/tr}</p>
> -                       <select name="profile" size="6">
> -                       <option value="" selected="selected">{tr}Bare-bones default install{/tr}</option>
> -                       <option value="Personal_Blog_and_Profile">{tr}Personal Blog and Profile{/tr}</option>
> -                       <option value="Small_Organization_Web_Presence">{tr}Small Organization Web Presence{/tr}</option>
> -                       <option value="Company_Intranet">{tr}Company Intranet{/tr}</option>
> -                       <option value="Collaborative_Community">{tr}Collaborative community{/tr}</option>
> -                       </select>
> -                        <p>{tr}See the documentation for <a target="_blank" href="http://profiles.tikiwiki.org/Profiles_in_30_installer" class="link" title="Description of available profiles.">descriptions of the available profiles.{/tr}</a></p>
> -                       {else}
> -                         <p style="text-align:center; color:red">{tr}The installer could not connect to the Profiles repository.{/tr}</p>
> -                         <p style="text-align:center">{tr}The default installation profile will be used.{/tr}</p>
> -                       <input type="hidden" name="profile" value="" />
> -                       {/if}
> -                        <p> </p>
> -                               <div align="center">
> -                                       <input type="submit" name="scratch" value=" {tr}Install{/tr} " />
> +                               {if $tikidb_created}
> +                               <script type="text/javascript">
> +                               <!--//--><![CDATA[//><!--
> +                                       {literal}
> +                                       function install() {
> +                                               document.getElementById('install-link').style.display='none';
> +                                               document.getElementById('install-table').style.visibility='';
> +                                       }
> +                                       {/literal}
> +                               //--><!]]>
> +                               </script>
> +                               <div id="install-link">
> +
> +                               <p style="text-align:center"><a class="button" href="javascript:install()">{tr}Reinstall the database{/tr}</a></p>
> +                               <p style="text-align:center"><img src="pics/icons/sticky.png" alt="{tr}Warning{/tr}" style="vertical-align:middle" /> <strong>{tr}Warning:{/tr}</strong> {tr}This will destroy your current database.{/tr}</p>
>                                </div>
> +                               <div id="install-table" style="visibility:hidden">
> +                               {else}
> +                               <div id="install-table">
> +                               {/if}
> +                               {if $tikidb_created}<p style="text-align:center"><img src="pics/icons/sticky.png" alt="{tr}Warning{/tr}" style="vertical-align:middle"/> <strong>{tr}Warning:{/tr}</strong> {tr}This will destroy your current database.{/tr}</p>{/if}
> +                               <p align="center">
> +                                       <input type="submit" name="scratch" value=" {if $tikidb_created}{tr}Reinstall{/tr}{else}{tr}Install{/tr}{/if} " style="margin: 32px;"/>
> +                               </p>
>
>                        </div>
>                        </fieldset>
>
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tikiwiki-cvs@...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>



--
Marc Laporte

http://MarcLaporte.com
http://TikiWiki.org/MarcLaporte
http://AvanTech.net
http://OurWiki.net

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Tikiwiki-devel mailing list
Tikiwiki-devel@...
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Re: [Tikiwiki-cvs/svn] SF.net SVN:tikiwiki:[22840] branches/4.x/templates/tiki-install.tpl

by Desilets, Alain :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

This is my first time participating in a Tiki release effort, so please
bear with me. I have read the whole of this page:

  http://dev.tikiwiki.org/tiki-index.php?page=Tiki4#Roles

But haven't really found answer to my questions.

Q1: If I, or a person on the testing team wants to test the most recent
version of Tiki 4, what branch should they be using?
- trunk?
- 4.x?

Q2: I have several usability improvements to make on the i18n stuff.
These aren't bug fixes properly, and they are not new features. For
example, I want to make it so that when you translate an update from
say, the En to the Fr page, the diff on the En will be displayed on the
left, with the Fr page open for editing on the right, and everything
displayed in full screen mode. Right now, the diff are on the top, and
the fr page below, and it's really hard to display both of them at the
same time, cause not enough real-estate.

So, my question is: can I make those changes in Tiki 4 release, or
should I only make changes that fix actual bugs. If it's OK to make
those changes on Tiki 4 release, which branch should I be making the
changes on?
- trunk?
- 4.x?

Thx.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Tikiwiki-devel mailing list
Tikiwiki-devel@...
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Re: [Tikiwiki-cvs/svn] SF.net SVN:tikiwiki:[22840] branches/4.x/templates/tiki-install.tpl

by Marc Laporte-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tue, Nov 3, 2009 at 2:44 PM, Desilets, Alain
<Alain.Desilets@...> wrote:

> This is my first time participating in a Tiki release effort, so please
> bear with me. I have read the whole of this page:
>
>  http://dev.tikiwiki.org/tiki-index.php?page=Tiki4#Roles
>
> But haven't really found answer to my questions.
>
> Q1: If I, or a person on the testing team wants to test the most recent
> version of Tiki 4, what branch should they be using?
> - trunk?
> - 4.x?
>


4.x


> Q2: I have several usability improvements to make on the i18n stuff.
> These aren't bug fixes properly, and they are not new features. For
> example, I want to make it so that when you translate an update from
> say, the En to the Fr page, the diff on the En will be displayed on the
> left, with the Fr page open for editing on the right, and everything
> displayed in full screen mode. Right now, the diff are on the top, and
> the fr page below, and it's really hard to display both of them at the
> same time, cause not enough real-estate.
>
> So, my question is: can I make those changes in Tiki 4 release, or
> should I only make changes that fix actual bugs.


There is no hard rule. Use common sense.

If you are pretty sure you will not introduce regressions and you are
not changing a lot of files: 4.x

If not, put in trunk, where they can be tested. And you can submit a
patch to Quality Team to be included in 4.1

Thanks!


 If it's OK to make

> those changes on Tiki 4 release, which branch should I be making the
> changes on?
> - trunk?
> - 4.x?
>
> Thx.
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> Tikiwiki-devel mailing list
> Tikiwiki-devel@...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>



--
Marc Laporte

http://MarcLaporte.com
http://TikiWiki.org/MarcLaporte
http://AvanTech.net
http://OurWiki.net

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Tikiwiki-devel mailing list
Tikiwiki-devel@...
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Re: [Tikiwiki-cvs/svn] SF.net SVN:tikiwiki:[22840]branches/4.x/templates/tiki-install.tpl

by Desilets, Alain :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Thx for your answers Marc. I think most of my changes could go in 4.x, but I will make sure to test the crap out of them before I commit. My guess is that any bug I might introduce will be very local to the i18n stuff.


Alain

-----Original Message-----
From: Marc Laporte [mailto:marc@...]
Sent: Tuesday, November 03, 2009 4:08 PM
To: Tikiwiki developers
Subject: Re: [Tikiwiki-devel] [Tikiwiki-cvs/svn] SF.net SVN:tikiwiki:[22840]branches/4.x/templates/tiki-install.tpl

On Tue, Nov 3, 2009 at 2:44 PM, Desilets, Alain
<Alain.Desilets@...> wrote:

> This is my first time participating in a Tiki release effort, so please
> bear with me. I have read the whole of this page:
>
>  http://dev.tikiwiki.org/tiki-index.php?page=Tiki4#Roles
>
> But haven't really found answer to my questions.
>
> Q1: If I, or a person on the testing team wants to test the most recent
> version of Tiki 4, what branch should they be using?
> - trunk?
> - 4.x?
>


4.x


> Q2: I have several usability improvements to make on the i18n stuff.
> These aren't bug fixes properly, and they are not new features. For
> example, I want to make it so that when you translate an update from
> say, the En to the Fr page, the diff on the En will be displayed on the
> left, with the Fr page open for editing on the right, and everything
> displayed in full screen mode. Right now, the diff are on the top, and
> the fr page below, and it's really hard to display both of them at the
> same time, cause not enough real-estate.
>
> So, my question is: can I make those changes in Tiki 4 release, or
> should I only make changes that fix actual bugs.


There is no hard rule. Use common sense.

If you are pretty sure you will not introduce regressions and you are
not changing a lot of files: 4.x

If not, put in trunk, where they can be tested. And you can submit a
patch to Quality Team to be included in 4.1

Thanks!


 If it's OK to make

> those changes on Tiki 4 release, which branch should I be making the
> changes on?
> - trunk?
> - 4.x?
>
> Thx.
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> Tikiwiki-devel mailing list
> Tikiwiki-devel@...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>



--
Marc Laporte

http://MarcLaporte.com
http://TikiWiki.org/MarcLaporte
http://AvanTech.net
http://OurWiki.net

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Tikiwiki-devel mailing list
Tikiwiki-devel@...
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Tikiwiki-devel mailing list
Tikiwiki-devel@...
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel