« Return to Thread: [VOTE] Promote Localization Tools Maven Plugin from the sandbox

Re: [VOTE] Promote Localization Tools Maven Plugin from the sandbox

by Dennis Lundberg-2 :: Rate this Message:

Reply to Author | View in Thread

Benjamin Bentmann wrote:
>> Please vote for the promotion of l10n plugin from the sandbox:
>
> +1, any plugin out of the sandbox is less hassle for uses to use it and
> provide feedback.
>
> Before the actual release, somebody could take care of these:

Thanks for pointing these out!

> Both mojos use j.l.String instead of j.i.File for file parameters and are
> therefore subject to relative path issues.

Fixed

> The status report has a user-accessible parameter taking model.Resource
> which is a further source of relative paths and needs manual resolving
> (like
> in MRESOURCES-32).

I'm not sure that this really needs to be accessible to the user. If it
doesn't need to, we can make it read-only. That would solve the problem,
right?

> It seems odd that the l10n:pseudo operates on "target/classes" (hence
> taking
> generated/filtered resources into account) while l10n:report by default
> only
> operates on the static resources in "src/main/resources" etc.

Not sure why it is like that.

> The plugin's own localization support should be completed
> (L10NStatusReport.java:559)

Fixed

> A sample report from the plugin about its own bundles would be a nice
> addition to its own site docs. I guess we could find some cute guys to
> add further bundles to make it more interesting ;-)

Report added. Now I'm waiting for translations ;-)

> Checkstyle errors could be fixed. Especially the report's renderBody()
> might
> benefit from refactoring out the analysis stuff from the actual report
> generation.

That is one big method! I don't dare chop that up.

> Benjamin

--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


 « Return to Thread: [VOTE] Promote Localization Tools Maven Plugin from the sandbox