Re: [VOTE] Struts 2.0.4 Quality

> Don
>
> Rene Gielen wrote:
>> Hey guys,
>>
>> a few minutes ago I came to the opinion that we have some major issues
>> with portlet integration, which imo should be fixed before rolling out
>> current build:
>>
>> - Annotation based configuration for actions seems to fail at least in
>> my portlet environment (Liferay 4.2.1), resulting in infinite loop
>> while scanning for action classes in configured packages. Had no time
>> to dig deeper yet, but the issue is reproducible. I'll file an issue.
>>
>> - ServletConfigInterceptor, along with PrincipalAware / PrincipalProxy
>> are not portlet aware. The implementation relies on access to
>> HttpServletRequest, but the Jsr168Dispatcher fails to put the
>> HttpServletRequest into action context (in fact there is a TODO in the
>> code!?!). The other (better: additional) option would be to make
>> PrincipalProxy HttpServletRequest independent, to deliver Principal
>> related information from PorletRequest, if applicable. We should
>> really consider this a major issue, preventing us from considering
>> portlet intergration (and therefore core) "ready for public". I'll
>> file an issue on that, too.
>>
>> For that reason, currently my vote is:
>> >    [x] Leave at test build
>> >    [ ] Alpha
>> >    [ ] Beta
>> >    [ ] General Availability (GA)
>>
>> - Rene
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>