Kevan Miller wrote:
+1. I'm not sure if my vote is binding or not.
Thank you! Only votes of Incubator PMC members are binding.
Unless you are one we still need one more IPMC vote. Could
we have an IPMC member either confirm that Kevan's vote
counts or kindly check out the tarball and give us the last
binding yay?
Kevan Miller wrote:
I did not build (or test). However, RAT and brief of inspection of
source looked good.
One comment -- I see that many source files contain Rogue Wave
Software copyrights (e.g. src/access.h) and one source file contains
an HP copyright (i.e. src/parisc/atomic.s). If at all possible, these
copyrights should be removed from your source (by the copyright
holder, of course) -- they are already in your NOTICE. Hmm. Although
the HP copyright is 2002 in your source file and 1994 in your NOTICE
file...
--kevan
With the exception of src/parisc/atomic.s all of the rest of the files
that bear the HP copyright are from 1994 (the HP STL). I'll update
NOTICE.txt to on trunk reflect the atomic.s date of copyright.
My understanding of the HP license is that it must appear in all
files so we wouldn't be able to remove it without HP's permission.
I'll have to check with Rogue Wave legal to see what they think
about moving our copyright notices to just one file.
Thanks again.
Martin
