« Return to Thread: [cargo] r2964 - core/trunk/samples core/trunk/uberjar extensions/trunk

Re: [cargo] r2964 - core/trunk/samples core/trunk/uberjar extensions/trunk

by Anders Hammar :: Rate this Message:

Ali, didn't we already discuss that this types of "fixes" are not correct? A pom should ALWAYS specify the direct dependencies. Regardless if the change you've done compiles, it's simply wrong in Maven land as you're not specify the (direct) dependencies any more but replying on them being pulled in as transitive dependencies.
Please revert!

/Anders

On Tue, Jun 28, 2011 at 19:33, <alitokmen@...> wrote:

Author: alitokmen
Date: 2011-06-28 12:33:46 -0500 (Tue, 28 Jun 2011)
New Revision: 2964

Modified:
core/trunk/samples/pom.xml
core/trunk/uberjar/pom.xml
extensions/trunk/pom.xml
Log:
CARGO-1008 : Better fix by putting the dependencies to uberjar

Modified: core/trunk/samples/pom.xml
===================================================================
--- core/trunk/samples/pom.xml 2011-06-27 19:37:44 UTC (rev 2963)
+++ core/trunk/samples/pom.xml 2011-06-28 17:33:46 UTC (rev 2964)
@@ -33,18 +33,7 @@
</prerequisites>
<dependencies>
<dependency>
- <groupId>com.sun.xml.bind</groupId>
- <artifactId>jaxb-impl</artifactId>
- <version>2.1.13</version>
- </dependency>
-
- <dependency>
<groupId>org.codehaus.cargo</groupId>
- <artifactId>cargo-core-api-generic</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.codehaus.cargo</groupId>
<artifactId>cargo-core-uberjar</artifactId>
<version>${project.version}</version>
</dependency>

Modified: core/trunk/uberjar/pom.xml
===================================================================
--- core/trunk/uberjar/pom.xml 2011-06-27 19:37:44 UTC (rev 2963)
+++ core/trunk/uberjar/pom.xml 2011-06-28 17:33:46 UTC (rev 2964)
@@ -28,6 +28,37 @@
<description>The Cargo Core Uberjar</description>
<dependencies>
<dependency>
+ <groupId>org.apache.ant</groupId>
+ <artifactId>ant</artifactId>
+ <version>1.7.1</version>
+ </dependency>
+ <dependency>
+ <groupId>commons-discovery</groupId>
+ <artifactId>commons-discovery</artifactId>
+ <version>0.4</version>
+ </dependency>
+ <dependency>
+ <groupId>com.sun.xml.bind</groupId>
+ <artifactId>jaxb-impl</artifactId>
+ <version>2.1.13</version>
+ </dependency>
+ <dependency>
+ <groupId>dom4j</groupId>
+ <artifactId>dom4j</artifactId>
+ <version>1.4</version>
+ </dependency>
+ <dependency>
+ <groupId>jaxen</groupId>
+ <artifactId>jaxen</artifactId>
+ <version>1.0-FCS</version>
+ </dependency>
+ <dependency>
+ <groupId>jdom</groupId>
+ <artifactId>jdom</artifactId>
+ <version>1.0</version>
+ </dependency>
+
+ <dependency>
<groupId>org.codehaus.cargo</groupId>
<artifactId>cargo-core-api-generic</artifactId>
<version>${project.version}</version>
@@ -102,6 +133,16 @@
</goals>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
+ <artifactSet>
+ <excludes>
+ <exclude>org.apache.ant:*</exclude>
+ <exclude>commons-discovery:*</exclude>
+ <exclude>com.sun.xml.bind:*</exclude>
+ <exclude>dom4j:*</exclude>
+ <exclude>jaxen:*</exclude>
+ <exclude>jdom:*</exclude>
+ </excludes>
+ </artifactSet>
<filters>
<filter>
<artifact>*:*</artifact>

Modified: extensions/trunk/pom.xml
===================================================================
--- extensions/trunk/pom.xml 2011-06-27 19:37:44 UTC (rev 2963)
+++ extensions/trunk/pom.xml 2011-06-28 17:33:46 UTC (rev 2964)
@@ -42,36 +42,6 @@

<dependencies>
<dependency>
- <groupId>org.apache.ant</groupId>
- <artifactId>ant</artifactId>
- <version>1.7.1</version>
- </dependency>
- <dependency>
- <groupId>commons-discovery</groupId>
- <artifactId>commons-discovery</artifactId>
- <version>0.4</version>
- </dependency>
- <dependency>
- <groupId>com.sun.xml.bind</groupId>
- <artifactId>jaxb-impl</artifactId>
- <version>2.1.13</version>
- </dependency>
- <dependency>
- <groupId>dom4j</groupId>
- <artifactId>dom4j</artifactId>
- <version>1.4</version>
- </dependency>
- <dependency>
- <groupId>jaxen</groupId>
- <artifactId>jaxen</artifactId>
- <version>1.0-FCS</version>
- </dependency>
- <dependency>
- <groupId>jdom</groupId>
- <artifactId>jdom</artifactId>
- <version>1.0</version>
- </dependency>
- <dependency>
<groupId>org.codehaus.cargo</groupId>
<artifactId>cargo-core-uberjar</artifactId>
<version>${cargo.core.version}</version>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

« Return to Thread: [cargo] r2964 - core/trunk/samples core/trunk/uberjar extensions/trunk