Re: [cargo] r2971 - in extensions/trunk: . ant/tasks maven2/plugin

This particular commit moves the uberjar dependency from the root of extensions to the ANT plugin and Maven2 tasks.

The reason is to avoid that the samples include the uberjar in the WAR fil they generate.

BTW, the uberjar is somehow required for our setup:

• People using the Java API or the ANT tasks cannot just download tens of libraries (core, APIs, containers, ...) and put them.
• The uberjar also uses the merge plugin's functionalities to have a correct services file for the commons-discovery to discover all container implementations.
  

Remember, this is not just Maven :)

S. Ali Tokmen
http://ali.tokmen.com/

GSM (ch): +41 79 207 29 22 [Swisscom]
GSM (fr): +33 66 43 00 555 [Orange]
GSM (tr): +90 555 266 52 73 [Avea]

My AIM, ICQ, MSN Messenger and Yahoo IM
contact details are on http://contact.ali.tokmen.com

On 2011/06/29 23:44, Anders Hammar wrote:

NO NO NO NO!!!!!
I think you're creating a mess here! We should be moving away from the uber jar, but instead your in-cooperating it more and more into everything. Please explain what you are doing and why we should do this!

uber jars are evil and IMHO a sign of bad (module) design.

/Anders

On Wed, Jun 29, 2011 at 21:44, <alitokmen@...> wrote:

Author: alitokmen
Date: 2011-06-29 14:44:08 -0500 (Wed, 29 Jun 2011)
New Revision: 2971

Modified:
  extensions/trunk/ant/tasks/pom.xml
  extensions/trunk/maven2/plugin/pom.xml
  extensions/trunk/pom.xml
Log:
Clean dependencies

Modified: extensions/trunk/ant/tasks/pom.xml
===================================================================
--- extensions/trunk/ant/tasks/pom.xml  2011-06-29 18:52:03 UTC (rev 2970)
+++ extensions/trunk/ant/tasks/pom.xml  2011-06-29 19:44:08 UTC (rev 2971)
@@ -30,6 +30,12 @@
  <dependencies>
    <dependency>
      <groupId>org.codehaus.cargo</groupId>
+      <artifactId>cargo-core-uberjar</artifactId>
+      <version>${cargo.core.version}</version>
+    </dependency>
+
+    <dependency>
+      <groupId>org.codehaus.cargo</groupId>
      <artifactId>cargo-core-api-container</artifactId>
      <version>${cargo.core.version}</version>
      <type>test-jar</type>

Modified: extensions/trunk/maven2/plugin/pom.xml
===================================================================
--- extensions/trunk/maven2/plugin/pom.xml      2011-06-29 18:52:03 UTC (rev 2970)
+++ extensions/trunk/maven2/plugin/pom.xml      2011-06-29 19:44:08 UTC (rev 2971)
@@ -55,6 +55,12 @@
    </dependency>
    <dependency>
      <groupId>org.codehaus.cargo</groupId>
+      <artifactId>cargo-core-uberjar</artifactId>
+      <version>${cargo.core.version}</version>
+    </dependency>
+
+    <dependency>
+      <groupId>org.codehaus.cargo</groupId>
      <artifactId>cargo-core-api-container</artifactId>
      <version>${cargo.core.version}</version>
      <type>test-jar</type>

Modified: extensions/trunk/pom.xml
===================================================================
--- extensions/trunk/pom.xml    2011-06-29 18:52:03 UTC (rev 2970)
+++ extensions/trunk/pom.xml    2011-06-29 19:44:08 UTC (rev 2971)
@@ -42,12 +42,6 @@

  <dependencies>
    <dependency>
-      <groupId>org.codehaus.cargo</groupId>
-      <artifactId>cargo-core-uberjar</artifactId>
-      <version>${cargo.core.version}</version>
-    </dependency>
-
-    <dependency>
      <groupId>junit</groupId>
      <artifactId>junit</artifactId>
      <version>3.8.1</version>


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email