Re: [commits] Horde branch master updated. 82ab649321b2e7d418610f4d089c8d78c4763e45

View: New views
2 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: [commits] Horde branch master updated. 82ab649321b2e7d418610f4d089c8d78c4763e45

by Michael J. Rubinsky :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Quoting Michael M Slusarz <slusarz@...>:

> The branch "master" has been updated.
> The following is a summary of the commits.
>
> from: ff1ff3c3c759e39956e6aa8fcbd2d5a176cd145d
>
> 82ab649... Revise Horde::addScriptFile() API
>
> -----------------------------------------------------------------------
>
> commit 82ab649321b2e7d418610f4d089c8d78c4763e45
> Author: Michael M Slusarz <slusarz@...>
> Date:   Tue Oct 6 12:53:40 2009 -0600
>
>     Revise Horde::addScriptFile() API
>
>     Move addExternalScriptFile() into this function - no reason to have a
>     separate function for this.
>     Direct loading should be the default.  Loading through javascript.php is
>     deprecated and any remaining scripts that contain PHP code should be
>     rewritten ASAP.

...and to start a list of those files that need refactoring,  
Horde_Tree javascript is completely broken at the moment due to this.


--
Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk@...


--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

Re: [commits] Horde branch master updated. 82ab649321b2e7d418610f4d089c8d78c4763e45

by Michael J. Rubinsky :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Quoting "Michael J. Rubinsky" <mrubinsk@...>:

> Quoting Michael M Slusarz <slusarz@...>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: ff1ff3c3c759e39956e6aa8fcbd2d5a176cd145d
>>
>> 82ab649... Revise Horde::addScriptFile() API
>>
>> -----------------------------------------------------------------------
>>
>> commit 82ab649321b2e7d418610f4d089c8d78c4763e45
>> Author: Michael M Slusarz <slusarz@...>
>> Date:   Tue Oct 6 12:53:40 2009 -0600
>>
>>    Revise Horde::addScriptFile() API
>>
>>    Move addExternalScriptFile() into this function - no reason to have a
>>    separate function for this.
>>    Direct loading should be the default.  Loading through javascript.php is
>>    deprecated and any remaining scripts that contain PHP code should be
>>    rewritten ASAP.
>
> ...and to start a list of those files that need refactoring,  
> Horde_Tree javascript is completely broken at the moment due to this.


Actually, it looks like it's only an issue with js caching turned on,  
with php code leaking into the JS.

--
Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk@...


--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...