Re: [commits] Horde branch master updated.

[Chuck Hagenbuch]

Quoting Michael M Slusarz <slusarz@...>:

> The branch "master" has been updated.
> The following is a summary of the commits.
>
> from: 9a984163d1813dcb27454914939e713b1e7dee9e
>
> 2c018fb... Import Horde_Cipher:: from CVS.
> 909134e... Horde_Cipher_Blowfish is broken.  Fallback to RC2 instead.
>
> -----------------------------------------------------------------------
>
> commit 2c018fb41a8d8b9b39d14260ff2aeeb7cf091548
> Author: Michael M Slusarz <slusarz@...>
> Date:   Sun Jul 5 14:29:25 2009 -0600
>
>     Import Horde_Cipher:: from CVS.
>
>     Am dubious about the state of this package, especially since neither
>     blowfish nor Cast128 pass the unit tests (they don't work in CVS either
>     going back for many years).  It might be best to dump them or else use
>     PEAR's Crypt_Blowfish module instead.

Sounds like it shouldn't be in H4 then...

-chuck

--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Michael M Slusarz-2]

Quoting Chuck Hagenbuch <chuck@...>:

> Quoting Michael M Slusarz <slusarz@...>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: 9a984163d1813dcb27454914939e713b1e7dee9e
>>
>> 2c018fb... Import Horde_Cipher:: from CVS.
>> 909134e... Horde_Cipher_Blowfish is broken.  Fallback to RC2 instead.
>>
>> -----------------------------------------------------------------------
>>
>> commit 2c018fb41a8d8b9b39d14260ff2aeeb7cf091548
>> Author: Michael M Slusarz <slusarz@...>
>> Date:   Sun Jul 5 14:29:25 2009 -0600
>>
>>    Import Horde_Cipher:: from CVS.
>>
>>    Am dubious about the state of this package, especially since neither
>>    blowfish nor Cast128 pass the unit tests (they don't work in CVS either
>>    going back for many years).  It might be best to dump them or else use
>>    PEAR's Crypt_Blowfish module instead.
>
> Sounds like it shouldn't be in H4 then...

We still need some sort of hashing fallback (Horde_Secret:: uses it if  
mcrypt is not available).  So keeping Horde_Cipher (namely the Rc2  
and/or Des parts) may be useful to prevent the need for an optional  
PEAR module if the optional mcrypt is not available.

michael

--
___________________________________
Michael Slusarz [slusarz@...]


--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Chuck Hagenbuch]

Quoting Michael M Slusarz <slusarz@...>:

> We still need some sort of hashing fallback (Horde_Secret:: uses it  
> if mcrypt is not available).  So keeping Horde_Cipher (namely the  
> Rc2 and/or Des parts) may be useful to prevent the need for an  
> optional PEAR module if the optional mcrypt is not available.

I'm all for removing the broken ciphers, then.

-chuck

--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Michael M Slusarz-2]

Quoting Chuck Hagenbuch <chuck@...>:

> Quoting Michael M Slusarz <slusarz@...>:
>
>> We still need some sort of hashing fallback (Horde_Secret:: uses it  
>> if mcrypt is not available).  So keeping Horde_Cipher (namely the  
>> Rc2 and/or Des parts) may be useful to prevent the need for an  
>> optional PEAR module if the optional mcrypt is not available.
>
> I'm all for removing the broken ciphers, then.

Done.

michael

--
___________________________________
Michael Slusarz [slusarz@...]


--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Chuck Hagenbuch]

Quoting Michael M Slusarz <slusarz@...>:

> The branch "master" has been updated.
> The following is a summary of the commits.
>
> from: 880314e236f67912136bd1494d4dc177ade28846
>
> 4bb52c7... Horde core framework package import into Git from CVS HEAD
>
> -----------------------------------------------------------------------
>
> commit 4bb52c73a8f50b963685d519bb531990fa89151b
> Author: Michael M Slusarz <slusarz@...>
> Date:   Wed Jul 8 21:00:36 2009 -0600
>
>     Horde core framework package import into Git from CVS HEAD
>
>     Named core framework package Core - makes more sense to me then
>     framework since technically, Core is part of the framework.
>     Also, split out Release into a separate package since 99.9% of users
>     don't need this package.

I agree about framework not really making sense, but if the package is  
Core, shouldn't the classes be named Horde_Core_*?

-chuck

--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Michael M Slusarz-2]

Quoting Chuck Hagenbuch <chuck@...>:

>>    Horde core framework package import into Git from CVS HEAD
>>
>>    Named core framework package Core - makes more sense to me then
>>    framework since technically, Core is part of the framework.
>>    Also, split out Release into a separate package since 99.9% of users
>>    don't need this package.
>
> I agree about framework not really making sense, but if the package  
> is Core, shouldn't the classes be named Horde_Core_*?

IMHO, no.  As for Horde:: - we have app-specific "master" utility  
libraries called IMP::, Turba::, etc. that naming it Horde_Core::  
doesn't make sense.  And I think at this point moving from something  
like Registry:: -> Horde_Core_Registry:: is too much overkill.

The package that contains the core files needs to be named *something*  
- I don't think we have to incorporate that name in the class names  
robotically.

michael

--
___________________________________
Michael Slusarz [slusarz@...]


--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz@...>:

> commit 17ddc46a041053ad32f460cced1e5abf5a8225e6
> Author: Michael M Slusarz <slusarz@...>
> Date:   Wed Jul 1 16:57:35 2009 -0600
>
>     Less resource intensive search for null character
>
>  framework/Mime/lib/Horde/Mime/Part.php |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> http://git.horde.org/diff.php/framework/Mime/lib/Horde/Mime/Part.php?rt=horde-git&r1=0aecab94bc2087b6127d2988368748d40b68da92&r2=17ddc46a041053ad32f460cced1e5abf5a8225e6

null has nothing to with NUL. In this context it's casted to ''.

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Jan Schneider]

Zitat von Chuck Hagenbuch <chuck@...>:

> Quoting Michael M Slusarz <slusarz@...>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: 880314e236f67912136bd1494d4dc177ade28846
>>
>> 4bb52c7... Horde core framework package import into Git from CVS HEAD
>>
>> -----------------------------------------------------------------------
>>
>> commit 4bb52c73a8f50b963685d519bb531990fa89151b
>> Author: Michael M Slusarz <slusarz@...>
>> Date:   Wed Jul 8 21:00:36 2009 -0600
>>
>>    Horde core framework package import into Git from CVS HEAD
>>
>>    Named core framework package Core - makes more sense to me then
>>    framework since technically, Core is part of the framework.
>>    Also, split out Release into a separate package since 99.9% of users
>>    don't need this package.
>
> I agree about framework not really making sense, but if the package  
> is Core, shouldn't the classes be named Horde_Core_*?

Or call the package Horde instead of Framework instead. Though that  
might become confusing once we distribute Horde through PEAR.

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz@...>:

> Quoting Chuck Hagenbuch <chuck@...>:
>
>>>   Horde core framework package import into Git from CVS HEAD
>>>
>>>   Named core framework package Core - makes more sense to me then
>>>   framework since technically, Core is part of the framework.
>>>   Also, split out Release into a separate package since 99.9% of users
>>>   don't need this package.
>>
>> I agree about framework not really making sense, but if the package  
>> is Core, shouldn't the classes be named Horde_Core_*?
>
> IMHO, no.  As for Horde:: - we have app-specific "master" utility  
> libraries called IMP::, Turba::, etc. that naming it Horde_Core::  
> doesn't make sense.  And I think at this point moving from something  
> like Registry:: -> Horde_Core_Registry:: is too much overkill.
>
> The package that contains the core files needs to be named  
> *something* - I don't think we have to incorporate that name in the  
> class names robotically.

Despite of what I wrote earlier, I think I agree with Michael here.

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Michael M Slusarz-2]

Quoting Jan Schneider <jan@...>:

>>> I agree about framework not really making sense, but if the  
>>> package is Core, shouldn't the classes be named Horde_Core_*?
>>
>> IMHO, no.  As for Horde:: - we have app-specific "master" utility  
>> libraries called IMP::, Turba::, etc. that naming it Horde_Core::  
>> doesn't make sense.  And I think at this point moving from  
>> something like Registry:: -> Horde_Core_Registry:: is too much  
>> overkill.
>>
>> The package that contains the core files needs to be named  
>> *something* - I don't think we have to incorporate that name in the  
>> class names robotically.
>
> Despite of what I wrote earlier, I think I agree with Michael here.

I don't have strong feelings on this issue, so if someone wants to do  
something with the naming, there is no objection here.

michael

--
___________________________________
Michael Slusarz [slusarz@...]


--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Michael M Slusarz-2]

Quoting Jan Schneider <jan@...>:

> Zitat von Michael M Slusarz <slusarz@...>:
>
>> commit 17ddc46a041053ad32f460cced1e5abf5a8225e6
>> Author: Michael M Slusarz <slusarz@...>
>> Date:   Wed Jul 1 16:57:35 2009 -0600
>>
>>    Less resource intensive search for null character
>>
>> framework/Mime/lib/Horde/Mime/Part.php |    6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> http://git.horde.org/diff.php/framework/Mime/lib/Horde/Mime/Part.php?rt=horde-git&r1=0aecab94bc2087b6127d2988368748d40b68da92&r2=17ddc46a041053ad32f460cced1e5abf5a8225e6
>
> null has nothing to with NUL. In this context it's casted to ''.

No it isn't.

---

<?php
$a = "1234";
$b = "12" . "\0" . "34";

print "A length: " . strlen($a) . "\n";
print "B: " . strlen($b) . "\n";

if (strpos($a, "\0") !== false) {
     print "A1\n";
}
if (strpos($b, "\0") !== false) {
     print "B1\n";
}

if (strpos($a, null) !== false) {
     print "A2\n";
}
if (strpos($b, null) !== false) {
     print "B2\n";
}

---

Output:

---
A length: 4
B length: 5
B1
B2
---

michael

--
___________________________________
Michael Slusarz [slusarz@...]


--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz@...>:

> Quoting Jan Schneider <jan@...>:
>
>> Zitat von Michael M Slusarz <slusarz@...>:
>>
>>> commit 17ddc46a041053ad32f460cced1e5abf5a8225e6
>>> Author: Michael M Slusarz <slusarz@...>
>>> Date:   Wed Jul 1 16:57:35 2009 -0600
>>>
>>>   Less resource intensive search for null character
>>>
>>> framework/Mime/lib/Horde/Mime/Part.php |    6 ++++--
>>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>>
>>> http://git.horde.org/diff.php/framework/Mime/lib/Horde/Mime/Part.php?rt=horde-git&r1=0aecab94bc2087b6127d2988368748d40b68da92&r2=17ddc46a041053ad32f460cced1e5abf5a8225e6
>>
>> null has nothing to with NUL. In this context it's casted to ''.
>
> No it isn't.
>
> ---
>
> <?php
> $a = "1234";
> $b = "12" . "\0" . "34";
>
> print "A length: " . strlen($a) . "\n";
> print "B: " . strlen($b) . "\n";
>
> if (strpos($a, "\0") !== false) {
>     print "A1\n";
> }
> if (strpos($b, "\0") !== false) {
>     print "B1\n";
> }
>
> if (strpos($a, null) !== false) {
>     print "A2\n";
> }
> if (strpos($b, null) !== false) {
>     print "B2\n";
> }
>
> ---
>
> Output:
>
> ---
> A length: 4
> B length: 5
> B1
> B2
> ---

Uh, since when did this work? My apologies. For clarity, I'm still in  
favor of using "\0" instead.

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...

[Michael M Slusarz-2]

Quoting Jan Schneider <jan@...>:

> Uh, since when did this work? My apologies. For clarity, I'm still  
> in favor of using "\0" instead.

I think you are partially correct - in a string context, it does  
resolve to '' (e.g. "A" . null . "B" = "AB" [length 2]).  I've used  
that strpos() way for some time now.

I've always used null there because it *is* more clear.  But you are  
probably also correct that at a deeper level, it may be confusing  
since 'nul'l in PHP differs based on context.

michael

--
___________________________________
Michael Slusarz [slusarz@...]


--
Horde developers mailing list - Join the hunt: http://horde.org/bounties/
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: dev-unsubscribe@...