Re: [issue1644818] Allow importing built-in submodules

[Julien Danjou-2]

At 1261178549 time_t, Martin v. Löwis wrote:
> > Is there to chance to see this *bug* fixed someday?
>
> Please ask on python-dev. I may be willing to revive my five-for-one offer.

Not sure I really understand, but I can ask gain here:
will that patch, which seems correct finally merged and get this bug
closed?

Cheers,
--
Julien Danjou
// ᐰ <julien@...>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// Trust no one.


_______________________________________________
Python-Dev mailing list
Python-Dev@...
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/lists%40nabble.com

[Nick Coghlan]

Julien Danjou wrote:
> At 1261178549 time_t, Martin v. Löwis wrote:
>>> Is there to chance to see this *bug* fixed someday?
>> Please ask on python-dev. I may be willing to revive my five-for-one offer.
>
> Not sure I really understand, but I can ask gain here:
> will that patch, which seems correct finally merged and get this bug
> closed?
>

Seems like a fair enough idea - I'll have a look at it in the next week
or two.

Cheers,
Nick.

--
Nick Coghlan   |   ncoghlan@...   |   Brisbane, Australia
---------------------------------------------------------------
_______________________________________________
Python-Dev mailing list
Python-Dev@...
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/lists%40nabble.com

["Martin v. Löwis"]

Julien Danjou wrote:
> At 1261178549 time_t, Martin v. Löwis wrote:
>>> Is there to chance to see this *bug* fixed someday?
>> Please ask on python-dev. I may be willing to revive my five-for-one offer.
>
> Not sure I really understand, but I can ask gain here:
> will that patch, which seems correct finally merged and get this bug
> closed?

Only if some committer finds time for it, which is *really* scarce.
If you want to push that issue, I promise to review it after you have
reviewed five other patches.

Regards,
Martin
_______________________________________________
Python-Dev mailing list
Python-Dev@...
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/lists%40nabble.com

[Julien Danjou-2]

At 1261181806 time_t, "Martin v. Löwis" wrote:
> Only if some committer finds time for it, which is *really* scarce.
> If you want to push that issue, I promise to review it after you have
> reviewed five other patches.

Well, that's disapointing. I work on several other free software
projects, and my time is really scarce too.

I understand blackmailing me to close a bug can be seen as a nice game.
Honestly, if I had more time to get involve in that area, I'll
take it as a game and would do it with pleasure.

But in my current position and with "I-do-software-developement-too",
you are just pissing me off for not fixing a bug in your program with a 10
lines long patch written by someone else 3 years ago.

Something that should take 5 minutes, probably the time we both lost by
writing our respective emails. Or give commit access, I'll do it for
you.

Anyway, thanks.

Cheers,
--
Julien Danjou
// ᐰ <julien@...>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// This is the end of my signature.


_______________________________________________
Python-Dev mailing list
Python-Dev@...
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/lists%40nabble.com

["Martin v. Löwis"]

> But in my current position and with "I-do-software-developement-too",
> you are just pissing me off for not fixing a bug in your program with a 10
> lines long patch written by someone else 3 years ago.

Unfortunately, it is not obvious to me that the patch is correct, so I
couldn't check it in as-is. The review would probably take an hour or
two.

> Something that should take 5 minutes, probably the time we both lost by
> writing our respective emails. Or give commit access, I'll do it for
> you.

Thanks, no. One possible side effect of the five reviews might be that
we could build trust in the reviewer not just to check in everything,
but apply careful review before.

Regards,
Martin
_______________________________________________
Python-Dev mailing list
Python-Dev@...
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/lists%40nabble.com

[R. David Murray]

On Sat, 19 Dec 2009 01:16:46 +0100, =?ISO-8859-1?Q?=22Martin_v=2E_L=F6wis=22?= <martin@...> wrote:
> Only if some committer finds time for it, which is *really* scarce.
> If you want to push that issue, I promise to review it after you have
> reviewed five other patches.

As a general note, I'm willing to make the same deal.  Anyone who has a
patch they are championing, if you will review some other patches for
us, I'll see if I can get the patch you are interested in committed.
We have a lot of patches in the tracker that only the submitter has
looked at/tested, or which lack tests or doc updates, and so they just
sit there...

(By the way, Julian, if you had done a review of the patch in question
(tested it, etc, and reported your results) progress on the bug might
have just started happening.  This is how it often works; although
there's no guarantee of course.)

I'd also like to point out that IMO the idea behind the one-for-five offer
is to leverage the "I have an itch to scratch" energy to the benefit of
all and, just as important (and as Martin already pointed out), perhaps
set some new people on the path to becoming committers.

--
R. David Murray                                      www.bitdance.com
Business Process Automation - Network/Server Management - Routers/Firewalls
_______________________________________________
Python-Dev mailing list
Python-Dev@...
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/lists%40nabble.com

[Glyph Lefkowitz]

On Dec 19, 2009, at 5:29 AM, Julien Danjou wrote:

> Well, that's disapointing. I work on several other free software
> projects, and my time is really scarce too.
>
> I understand blackmailing me to close a bug can be seen as a nice game.
> Honestly, if I had more time to get involve in that area, I'll
> take it as a game and would do it with pleasure.
>
> But in my current position and with "I-do-software-developement-too",
> you are just pissing me off for not fixing a bug in your program with a 10
> lines long patch written by someone else 3 years ago.
>
> Something that should take 5 minutes, probably the time we both lost by
> writing our respective emails. Or give commit access, I'll do it for
> you.

I think you're missing the point here.  This one particular patch is 10 lines long, but the problem is that there are thousands of patches in the Python tracker, many of which are buggy or incorrect, all of which need to be reviewed.  All of which *are* being reviewed, as people have time.  Nothing is particularly special about your patch.

In other words, Martin is asking you to review only 5 patches, but you're asking him to review tens of thousands.  I think the 5-for-1 deal is a great idea, because it takes peoples' impatience and turns it into a resource to deal with other peoples' impatience :).


_______________________________________________
Python-Dev mailing list
Python-Dev@...
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/lists%40nabble.com

[Nick Coghlan]

Martin v. Löwis wrote:
>> But in my current position and with "I-do-software-developement-too",
>> you are just pissing me off for not fixing a bug in your program with a 10
>> lines long patch written by someone else 3 years ago.
>
> Unfortunately, it is not obvious to me that the patch is correct, so I
> couldn't check it in as-is. The review would probably take an hour or
> two.

I definitely plan on spending a lot more than 5 minutes on it - in
particular, I want to see if I can find a way to avoid adding
yet-more-test-code to the main binary. (Probably not, given the nature
of the feature we're trying to test in this case, but I'm still going to
try).

Cheers,
Nick.

--
Nick Coghlan   |   ncoghlan@...   |   Brisbane, Australia
---------------------------------------------------------------
_______________________________________________
Python-Dev mailing list
Python-Dev@...
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/lists%40nabble.com