Re: [mb-commits] r12052 - in mb_server/trunk: lib/MusicBrainz/Server/Controller lib/MusicBrainz/Server/Plugin root root/components root/layout root/layout/sidebar root/release root/scripts root/static/scripts root/static/scripts/jquery root/static/sc

[Aurélien Mino-2]

On Fri, Sep 4, 2009 at 5:31 PM, <root@...> wrote:

Author: acid2
Date: 2009-09-04 15:31:00 +0000 (Fri, 04 Sep 2009)
New Revision: 12052

Added:
  mb_server/trunk/root/layout/sidebar/properties.tt
  mb_server/trunk/root/layout/sidebar/property.tt
  mb_server/trunk/root/layout/sidebar/sidebar-lastupdate.tt
  mb_server/trunk/root/layout/sidebar/sidebar-rating.tt
  mb_server/trunk/root/layout/sidebar/sidebar-tags.tt
  [...]
Removed:
  mb_server/trunk/root/components/sidebar-lastupdate.tt
  mb_server/trunk/root/components/sidebar-rating.tt
  mb_server/trunk/root/components/sidebar-tags.tt
  [...]
Log:
Merge Brian's work on the sidebar in the release editor.

See review 370.

These changes (move sidebar-*.tt from root/components/ to root/layout/sidebar/) were not in http://codereview.musicbrainz.org/r/370/diff/ as far as I can tell.

That breaks a few templates:

mbserver@brainzvm:~/svn/trunk/root$ grep -R "components/sidebar-" * | grep -v ".svn"

artist/layout.tt:    [%- INCLUDE "components/sidebar-rating.tt" entity=artist -%]
artist/layout.tt:    [%- INCLUDE "components/sidebar-tags.tt" entity=artist tags=top_tags tag_this_text=l('Tag this artist') -%]
artist/layout.tt:    [%- INCLUDE "components/sidebar-lastupdate.tt" entity=artist -%]
label/layout.tt:    [%- INCLUDE "components/sidebar-rating.tt" entity=label -%]
label/layout.tt:    [%- INCLUDE "components/sidebar-tags.tt" entity=label tags=top_tags tag_this_text=l('Tag this label') -%]
label/layout.tt:    [%- INCLUDE "components/sidebar-lastupdate.tt" entity=label -%]
recording/layout.tt:    [%- INCLUDE "components/sidebar-rating.tt" entity=recording -%]
recording/layout.tt:    [%- INCLUDE "components/sidebar-tags.tt" entity=recording tags=top_tags tag_this_text=l('Tag this recording') -%]
recording/layout.tt:    [%- INCLUDE "components/sidebar-lastupdate.tt" entity=recording -%]
release_group/layout.tt:    [%- INCLUDE "components/sidebar-rating.tt" entity=rg -%]
release_group/layout.tt:    [%- INCLUDE "components/sidebar-tags.tt" entity=rg tags=top_tags tag_this_text=l('Tag this release group') -%]
release_group/layout.tt:    [%- INCLUDE "components/sidebar-lastupdate.tt" entity=rg -%]
work/layout.tt:    [%- INCLUDE "components/sidebar-rating.tt" entity=work -%]
work/layout.tt:    [%- INCLUDE "components/sidebar-tags.tt" entity=work tags=top_tags tag_this_text=l('Tag this work') -%]
work/layout.tt:    [%- INCLUDE "components/sidebar-lastupdate.tt" entity=work -%]

- Aurélien

 

_______________________________________________
MusicBrainz-devel mailing list
MusicBrainz-devel@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel