Ross, removing protected modifier on methods doesn't make connector easier to extend. In fact, it's more restrictive, as custom subclasses must be in the same package (ouch), unlike for protected.
Andrew
On Nov 4, 2009 6:26 PM, <rossmason@...> wrote:
- Revision
- 15967
- Author
- rossmason
- Date
- 2009-11-04 17:26:15 -0600 (Wed, 04 Nov 2009)
Log Message
Make Http connecotr a little easier to extend
Modified Paths
Diff
Modified: branches/mule-3.x/transports/http/src/main/java/org/mule/transport/http/HttpConnector.java (15966 => 15967)
--- branches/mule-3.x/transports/http/src/main/java/org/mule/transport/http/HttpConnector.java 2009-11-04 23:25:23 UTC (rev 15966)
+++ branches/mule-3.x/transports/http/src/main/java/org/mule/transport/http/HttpConnector.java 2009-11-04 23:26:15 UTC (rev 15967)
@@ -325,7 +325,7 @@
this.followRedirects = followRedirects;
}
- protected HttpClient doClientConnect() throws Exception
+ HttpClient doClientConnect() throws Exception
{
HttpState state = new HttpState();
@@ -343,7 +343,7 @@
return client;
}
- protected void setupClientAuthorization(MuleEvent event, HttpMethod httpMethod,
+ void setupClientAuthorization(MuleEvent event, HttpMethod httpMethod,
HttpClient client, ImmutableEndpoint endpoint)
throws UnsupportedEncodingException
{
Modified: branches/mule-3.x/transports/http/src/main/java/org/mule/transport/http/HttpMessageAdapter.java (15966 => 15967)
--- branches/mule-3.x/transports/http/src/main/java/org/mule/transport/http/HttpMessageAdapter.java 2009-11-04 23:25:23 UTC (rev 15966)
+++ branches/mule-3.x/transports/http/src/main/java/org/mule/transport/http/HttpMessageAdapter.java 2009-11-04 23:26:15 UTC (rev 15967)
@@ -36,9 +36,9 @@
*/
private static final long serialVersionUID = -1544495479333000422L;
- private boolean http11 = true;
+ protected boolean http11 = true;
- private Object message;
+ protected Object message;
public HttpMessageAdapter(Object message)
{
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
