2009/2/4 David P Grove <
groved@...>:
> Steve Blackburn <
Steve.Blackburn@...> wrote on 02/03/2009 06:36:32
> PM:
>>
>> Can explain to us what you were trying to do with r15318? The commit
>> message says "fix typos", I assume that was a mistake on your part
>> because the commit doesn't seem to have a lot to do with typos. A
>> bunch of other things are going on in there which appear significant
>> and that affect others:
>
> I'll leave it to Ian to explain the content of the commit, but I can confirm
> that he meant to do two commits, one to fix a few typos and the second to
> make the more interesting change. We tried to fix the commit log message
> after the fact, but sf svn doesn't allow the necessary operation.
>
> --dave
Hi Steve,
the more interesting part of the commit were the changes to the
barrier code. This is a speedup primarily on Intel baseline code. I'll
take each barrier in turn:
aastore:
previously: the aastore would emit a call to checkstore and then a
call to the aastore barrier
now: a single aastore helper can inline both of these calls and
therefore we pay only 1 call. Another consequence of this is the
baseline compiler emits less code (which should make it faster).
putfield/putstatic:
previously: the arguments to the barrier routines in MemoryManager
were in a different order to the values on the JVM's operand stack, to
call the barrier the parameters were shuffled
now: the order of operands on the barrier routines now match, we no
longer need to shuffle parameters losing around 2 instructions (long 4
byte instructions) per baseline barrier call.
Regards,
Ian
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-
http://p.sf.net/sfu/adobe-com_______________________________________________
Jikesrvm-core mailing list
Jikesrvm-core@...
https://lists.sourceforge.net/lists/listinfo/jikesrvm-core
