« Return to Thread: Re: [rvm-core] [rvm-commits] SF.net SVN: jikesrvm:[15318] rvmroot/trunk
Re: [rvm-core] [rvm-commits] SF.net SVN: jikesrvm:[15318] rvmroot/trunk
by Ian Rogers (nabble)
::
Rate this Message:
2009/2/4 Steve Blackburn <Steve.Blackburn@...>:
> On 04/02/2009, at 1:14 PM, David P Grove wrote:
>
> I'll leave it to Ian to explain the content of the commit, but I can confirm
> that he meant to do two commits, one to fix a few typos and the second to
> make the more interesting change. We tried to fix the commit log message
> after the fact, but sf svn doesn't allow the necessary operation.
>
> No worries. We've all made errors when committing. This one would have
> gone under the radar except that I stumbled on it while tracking down the
> compress regression which seemed to "magically" disappear. I guess for
> future reference, depending on the importance of the changes, the best thing
> to do would either be to simply reply to the list with that commit on the
> subject line (so that the reply comes up when searching on the commit id),
> or if it was significant, just back out and recommit as intended.
> In this case I was just trying to get to the bottom of the compress
> regression and was a bit baffled when it narrowed down to this commit.
What is the compress regression?
> Even after reading through the commit I couldn't easily figure out why it
> "fixed" the compress regression. It disturbs me when performance changes
> significantly for no clear reason, so having some clue as to what's going on
> here would be helpful, and I was speculating that that was what Ian may have
> been trying to address (which is why I sought clarification).
I've been trying to get the barrier code into shape but no one commit
should have moved performance back. I think the major issue is that
we've had a week or so of misleading performance results from
Habanero.
> The issue with the barriers is that the changes amount to a change in an API
> which some people rely on heavily, so while it may make sense to change it,
> it really should be discussed first.
I thought the MemoryManager API was analogous to RuntimeEntrypoints,
entry points for the compiler and not something that people should be
deliberately coding against.
Ian
> --Steve
>
> ------------------------------------------------------------------------------
> Create and Deploy Rich Internet Apps outside the browser with
> Adobe(R)AIR(TM)
> software. With Adobe AIR, Ajax developers can use existing skills and code
> to
> build responsive, highly engaging applications that combine the power of
> local
> resources and data with the reach of the web. Download the Adobe AIR SDK and
> Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
> _______________________________________________
> Jikesrvm-core mailing list
> Jikesrvm-core@...
> https://lists.sourceforge.net/lists/listinfo/jikesrvm-core
>
>
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Jikesrvm-core mailing list
Jikesrvm-core@...
https://lists.sourceforge.net/lists/listinfo/jikesrvm-core
> On 04/02/2009, at 1:14 PM, David P Grove wrote:
>
> I'll leave it to Ian to explain the content of the commit, but I can confirm
> that he meant to do two commits, one to fix a few typos and the second to
> make the more interesting change. We tried to fix the commit log message
> after the fact, but sf svn doesn't allow the necessary operation.
>
> No worries. We've all made errors when committing. This one would have
> gone under the radar except that I stumbled on it while tracking down the
> compress regression which seemed to "magically" disappear. I guess for
> future reference, depending on the importance of the changes, the best thing
> to do would either be to simply reply to the list with that commit on the
> subject line (so that the reply comes up when searching on the commit id),
> or if it was significant, just back out and recommit as intended.
> In this case I was just trying to get to the bottom of the compress
> regression and was a bit baffled when it narrowed down to this commit.
What is the compress regression?
> Even after reading through the commit I couldn't easily figure out why it
> "fixed" the compress regression. It disturbs me when performance changes
> significantly for no clear reason, so having some clue as to what's going on
> here would be helpful, and I was speculating that that was what Ian may have
> been trying to address (which is why I sought clarification).
I've been trying to get the barrier code into shape but no one commit
should have moved performance back. I think the major issue is that
we've had a week or so of misleading performance results from
Habanero.
> The issue with the barriers is that the changes amount to a change in an API
> which some people rely on heavily, so while it may make sense to change it,
> it really should be discussed first.
I thought the MemoryManager API was analogous to RuntimeEntrypoints,
entry points for the compiler and not something that people should be
deliberately coding against.
Ian
> --Steve
>
> ------------------------------------------------------------------------------
> Create and Deploy Rich Internet Apps outside the browser with
> Adobe(R)AIR(TM)
> software. With Adobe AIR, Ajax developers can use existing skills and code
> to
> build responsive, highly engaging applications that combine the power of
> local
> resources and data with the reach of the web. Download the Adobe AIR SDK and
> Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
> _______________________________________________
> Jikesrvm-core mailing list
> Jikesrvm-core@...
> https://lists.sourceforge.net/lists/listinfo/jikesrvm-core
>
>
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Jikesrvm-core mailing list
Jikesrvm-core@...
https://lists.sourceforge.net/lists/listinfo/jikesrvm-core
« Return to Thread: Re: [rvm-core] [rvm-commits] SF.net SVN: jikesrvm:[15318] rvmroot/trunk
| Free embeddable forum powered by Nabble | Forum Help |
