Re: [sc-users] (9/7).reciprocal.asFraction is buggy

[nescivi]

Hiho,

did anyone check this in?

sincerely,
Marije


On Wednesday 15 April 2009 22:34:51 James McCartney wrote:

> The primitive can be fixed by changing the two lines that look like this:
>
> if (maxDenominator < mediant_den || d == 0.0) {
>
> to this:
>
> if (maxDenominator < mediant_den || fabs(d) < 1e-5) {
>
> Also this fix should be removed:
>
> // catch special behaviour - fixes SF.net bug 1856972
> if(x == 0.2) {
> SetInt(slots+0, 1);
> SetInt(slots+1, 5);
> return errNone;
> }
>
> _______________________________________________
> sc-users mailing list
>
> info (subscription, etc.):
> http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml archive:
> http://www.listarc.bham.ac.uk/marchives/sc-users/
> search: http://www.listarc.bham.ac.uk/lists/sc-users/search/

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

[Dan Stowell]

Yes:

Revision: 9056
         http://supercollider.svn.sourceforge.net/supercollider/?rev=9056&view=rev
Author:   jrhb
Date:     2009-04-16 07:42:20 +0000 (Thu, 16 Apr 2009)



2009/4/22 nescivi <nescivi@...>:

> Hiho,
>
> did anyone check this in?
>
> sincerely,
> Marije
>
>
> On Wednesday 15 April 2009 22:34:51 James McCartney wrote:
>> The primitive can be fixed by changing the two lines that look like this:
>>
>>                       if (maxDenominator < mediant_den || d == 0.0) {
>>
>> to this:
>>
>>                       if (maxDenominator < mediant_den || fabs(d) < 1e-5) {
>>
>> Also this fix should be removed:
>>
>>       // catch special behaviour - fixes SF.net bug 1856972
>>       if(x == 0.2) {
>>               SetInt(slots+0, 1);
>>               SetInt(slots+1, 5);
>>               return errNone;
>>       }
>>
>> _______________________________________________
>> sc-users mailing list
>>
>> info (subscription, etc.):
>> http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml archive:
>> http://www.listarc.bham.ac.uk/marchives/sc-users/
>> search: http://www.listarc.bham.ac.uk/lists/sc-users/search/
>
>
>
> _______________________________________________
> sc-dev mailing list
>
> info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
> archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
> search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/
>

--
http://www.mcld.co.uk

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/