Hi, Michael
I have a short comment about includes style:
+#include <rendering/RenderMedia.h>
I think it should be
+#include "rendering/RenderMedia.h"
and
+#include "RenderMedia.h"
+#include "MediaControls.h"
should be
#include "rendering/RenderMedia.h"
#include "rendering/MediaControls.h"
(possibly in more places)
obviously, we have it incosistent, but that's what we lately agreed on (from my experience)
Thanks for your work!
Vyacheslav Tokarev
2009/6/4 Michael Howell
<mhowell123@...>
KHTML currently includes a small amount of boilerplate code, imported from
WebKit, for HTML5 media elements. This patch finishes the job, backing it with
Phonon and native KDE widgets for controls.
I'd like it to be reviewed, please, before commiting.
--
Please do not send HTML mail. Please, if you forward email, clean off the
garbage. Thanks for making everyone's email experience more enjoyable.
Michael Howell
mhowell123@...
