Re: Bug 137826 - "next file" button does not work when used first thing in a new session

12.06.2012, 17:59, "Jean-Nicolas Artaud" <jeannicolasartaud@...>:
> Hello,Sorry but I didn't succeed with the review board, only know the git one :-(

http://techbase.kde.org/Development/Review_Board#Using_Review_Board_With_Subversion

It's possible to submit git-originated patches there too, but they need to be modifed to look like
svn diffs

> BTW, I have a patch to fix the bug 137826.
> Could you please review it and/or guide me a bit more to use the review board ?

1. Don't compare boolean return value with 0 - it's incorrect even if old code does that.
2. I don't like name of openParseDiffOutput function. Also it seems that it mixes GUI stuff and parsing
(probably show() should stay where it was)


--
Regards,
Konstantin
_______________________________________________
Kompare-devel mailing list
Kompare-devel@...
https://mail.kde.org/mailman/listinfo/kompare-devel