Re: Bug in comments perms and more feedback on object perms

[Michael Risch]

tiki_p_wiki_view_comments is no longer on the perms list - at least not that I see, and not in the wiki type


>>> <tikiwiki-devel-request@...> 10/21/2009 8:40 AM >>>
> 1. tiki_p_post_comments isn't being read correctly for categories and wiki pages. I have a category with the flag set to off for anonymous(verified in the object perm list). I am still getting comments on wiki pages in that category. I checked for page object perms - none set according to the object list.
>
> I then turned off the global tiki_p_post_comments for Anonymous, and the ability to post comments now disappears. Thus, for some reason the global perm was read instead of the object perm based on its category membership.
>
> Note that I have comment approval on, if that makes a difference.
>

I have noticed some weirdness before in this area. I think the root of
the problem is that there are different perms:

tiki_p_read_comments
tiki_p_post_comments
tiki_p_wiki_view_comments

As far as I remember it, you need both (general and wiki) for comments
to work on wiki pages.


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Tikiwiki-devel mailing list
Tikiwiki-devel@...
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

[Jonny Bradley-2]

I see tiki_p_wiki_view_comments in the wiki section (and it's in  
tiki.sql - maybe an up?). You need feature_wiki_comments on to be able  
to see it though.

It does seem like a bit of a mess - and beyond what can be fixed for  
4.0...

Now that the object perms do work properly, we should remove all the  
wiki and tracker specific perms for comments, and use the generic  
object perms on those objects (or categories they are in) if you want  
finer grain control.

But for now we'll just have to live with it (i guess).

jb



On 21 Oct 2009, at 13:50, Michael Risch wrote:

> tiki_p_wiki_view_comments is no longer on the perms list - at least  
> not that I see, and not in the wiki type
>
>
>>>> <tikiwiki-devel-request@...> 10/21/2009 8:40 AM  
>>>> >>>
>> 1. tiki_p_post_comments isn't being read correctly for categories  
>> and wiki pages. I have a category with the flag set to off for  
>> anonymous(verified in the object perm list). I am still getting  
>> comments on wiki pages in that category. I checked for page object  
>> perms - none set according to the object list.
>>
>> I then turned off the global tiki_p_post_comments for Anonymous,  
>> and the ability to post comments now disappears. Thus, for some  
>> reason the global perm was read instead of the object perm based on  
>> its category membership.
>>
>> Note that I have comment approval on, if that makes a difference.
>>
>
> I have noticed some weirdness before in this area. I think the root of
> the problem is that there are different perms:
>
> tiki_p_read_comments
> tiki_p_post_comments
> tiki_p_wiki_view_comments
>
> As far as I remember it, you need both (general and wiki) for comments
> to work on wiki pages.
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart  
> your
> developing skills, take BlackBerry mobile applications to market and  
> stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> Tikiwiki-devel mailing list
> Tikiwiki-devel@...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Tikiwiki-devel mailing list
Tikiwiki-devel@...
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel