« Return to Thread: Code review request, CR 6996372: synchronizing handshaking hash

Re: Code review request, CR 6996372: synchronizing handshaking hash

by xuelei.fan :: Rate this Message:

| View in Thread

On 4/27/2012 11:46 AM, David Schlosnagle wrote:
> On Apr 26, 2012, at 10:07 PM, Xuelei Fan <xuelei.fan@...> wrote:
>
>> webrev: http://cr.openjdk.java.net/~xuelei/6996372/webrev.00/
>
> It might be worthwhile to add a comment that both disabledAlgorithmsMap and keySizeConstraintsMap are locked by the disabledAlgorithmsMap instance. Also, is there any reason not to make both of those static maps final?
>
Good suggestion.  See the updated webrev:
   http://cr.openjdk.java.net/~xuelei/6996372/webrev.01/

Thanks,
Xuelei

> Thanks,
> Dave

 « Return to Thread: Code review request, CR 6996372: synchronizing handshaking hash