« Return to Thread: Compiling nailgun on Solaris

Re: Compiling nailgun on Solaris

by Chris Evans-8 :: Rate this Message:

Reply to Author | View in Thread

Did this make it into 1.3.1, or do I need to do a special build to get
the changes?

---
Chris

On Sun, Jun 14, 2009 at 2:03 PM, Charles Oliver
Nutter<headius@...> wrote:

> On Sat, Jun 13, 2009 at 5:08 AM, Ole Christian Rynning<oc@...> wrote:
>> You're right. I've found the bug, and fixed it. Tested on OSOL
>> 2008.11, 2009.06 and OSX 10.5.7
>>
>> getcwd(NULL,0) doesn't conform to POSIX.1. The correct would be to use
>> MAXPATHLEN (from sys/param.h) -- but as I do not have a Linux box
>> available, I chose BUFSIZE (2048) as a simpler solution. It's usually
>> bigger than maxpath - which is usually 1024 anyway, and it gets freed
>> immediately after so I think it should be a pretty safe fix.
>>
>> See:
>> http://github.com/oc/jruby/commit/372471fe4c66e245299c14298efb48e921359a73
>
> Cool, thank you. I merged it in 81e2177.
>
> - Charlie
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


 « Return to Thread: Compiling nailgun on Solaris