Re: Errors in cluster events documentation

View: New views
4 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: Errors in cluster events documentation

by Igal Levy :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

hi Geert,

i've applied some more refactoring to the cluster events doc. i've got a couple of issues still:

1. is there a good example of how to use SimulatedDsoCluster in a useful test? this is still missed in the doc.

2. didn't quite understand this comment from below:

>> * "... it will be injected with cluster awareness." -> you don't know  
>> that since the type of the field isn't shown anywhere in the snippet.

can you elaborate a bit?

tnx,

---------------------------------------------------
Igal D. Levy
Terracotta Inc.
terracotta.org | terracottatech.com
415-738-4026

----- Original Message -----
From: "Geert Bevin" <gbevin@...>
To: "Igal Levy" <ilevy@...>
Cc: "tc-dev" <tc-dev@...>
Sent: Tuesday, April 21, 2009 3:40:43 AM GMT -08:00 US/Canada Pacific
Subject: Re: [tc-dev] Errors in cluster events documentation

Hi Igal,

I read through the intro, great idea to add this.

Some small suggestions:

* "The functionality is injected into a specified field ..." -> I  
understand why you use the generic 'functionality' word here, but it  
reads weird. Functionality isn't injected, instances of particular  
types are, and those instances can provide the functionality.

* "Classes that are not configured for instrumentation by Terracotta  
cannot be injected using this configuration." -> should be "... cannot  
be injected into ..." ie. they need to be configured for  
instrumentation so that their bytecode can be modified to perform the  
injection

* "... it will be injected with cluster awareness." -> you don't know  
that since the type of the field isn't shown anywhere in the snippet.

* It would be good to also gear people towards using annotations here  
instead of using the XML for configuring injected instances for field.

Take care,

Geert


On 21 Apr 2009, at 01:44, Igal Levy wrote:

> fixed. i've also edited that section to have a more general  
> introduction before focusing on cluster events.
>
> ---------------------------------------------------
> Igal D. Levy
> Terracotta Inc.
> terracotta.org | terracottatech.com
> 415-738-4026
>
> ----- Original Message -----
> From: "Geert Bevin" <gbevin@...>
> To: "Igal Levy" <ilevy@...>
> Sent: Monday, April 20, 2009 2:53:34 AM GMT -08:00 US/Canada Pacific
> Subject: Fwd: [tc-dev] Errors in cluster events documentation
>
> Hi Igal,
>
> Could you make the relevant changes?
>
> Thanks,
>
> Geert
>
> Begin forwarded message:
>
>> From: Sergio Bossa <sergio.bossa@...>
>> Date: Mon 20 Apr 2009 11:51:40 GMT+02:00
>> To: tc-dev <tc-dev@...>
>> Subject: [tc-dev] Errors in cluster events documentation
>> Reply-To: tc-dev@...
>>
>> Hi guys,
>>
>> the cluster events documentation at
>> "http://terracotta.org/web/display/docs/Configuration+Guide+and+Reference#ConfigurationGuideandReference-injectedinstances
>> "
>> has the following errors:
>>
>> - The "/tc:tc-config/clients/dso/injected-instances" path is wrong,  
>> it
>> should be: "/tc:tc-config/application/dso/injected-instances"
>> - The related XML snippet, reported as an example, doesn't actually
>> contain the field name, but just the class name:
>> "<field-name>com.mypackage.myClasses.OtherClusterAwareClass</field-
>> name>"
>>
>> Cheers,
>>
>> Sergio B.
>>
>> --
>> Sergio Bossa
>> Software Passionate and Open Source Enthusiast.
>> Blog : http://sbtourist.blogspot.com
>> Pro-Netics : http://www.pronetics.it
>> Sourcesense : http://www.sourcesense.com
>> _______________________________________________
>> tc-dev mailing list
>> tc-dev@...
>> http://lists.terracotta.org/mailman/listinfo/tc-dev
>
> --
> Geert Bevin
> Terracotta - http://www.terracotta.org
> Uwyn "Use what you need" - http://uwyn.com
> RIFE Java application framework - http://rifers.org
> Flytecase Band - http://flytecase.be
> Music and words - http://gbevin.com
>

--
Geert Bevin
Terracotta - http://www.terracotta.org
Uwyn "Use what you need" - http://uwyn.com
RIFE Java application framework - http://rifers.org
Flytecase Band - http://flytecase.be
Music and words - http://gbevin.com

_______________________________________________
tc-dev mailing list
tc-dev@...
http://lists.terracotta.org/mailman/listinfo/tc-dev

Re: Errors in cluster events documentation

by Sergio Bossa :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

There seems to be another error in the events table: the nodeJoined  
and nodeLeft events are actually received multiple times, more  
specifically everytime nodes join/leave, rather than once per node  
lifetime as reported in that table.

HTH

Sergio Bossa
Sent by iPhone

Il giorno 13/mag/09, alle ore 19:40, Igal Levy  
<ilevy@...> ha scritto:

> hi Geert,
>
> i've applied some more refactoring to the cluster events doc. i've  
> got a couple of issues still:
>
> 1. is there a good example of how to use SimulatedDsoCluster in a  
> useful test? this is still missed in the doc.
>
> 2. didn't quite understand this comment from below:
>
>>> * "... it will be injected with cluster awareness." -> you don't  
>>> know
>>> that since the type of the field isn't shown anywhere in the  
>>> snippet.
>
> can you elaborate a bit?
>
> tnx,
>
> ---------------------------------------------------
> Igal D. Levy
> Terracotta Inc.
> terracotta.org | terracottatech.com
> 415-738-4026
>
> ----- Original Message -----
> From: "Geert Bevin" <gbevin@...>
> To: "Igal Levy" <ilevy@...>
> Cc: "tc-dev" <tc-dev@...>
> Sent: Tuesday, April 21, 2009 3:40:43 AM GMT -08:00 US/Canada Pacific
> Subject: Re: [tc-dev] Errors in cluster events documentation
>
> Hi Igal,
>
> I read through the intro, great idea to add this.
>
> Some small suggestions:
>
> * "The functionality is injected into a specified field ..." -> I
> understand why you use the generic 'functionality' word here, but it
> reads weird. Functionality isn't injected, instances of particular
> types are, and those instances can provide the functionality.
>
> * "Classes that are not configured for instrumentation by Terracotta
> cannot be injected using this configuration." -> should be "... cannot
> be injected into ..." ie. they need to be configured for
> instrumentation so that their bytecode can be modified to perform the
> injection
>
> * "... it will be injected with cluster awareness." -> you don't know
> that since the type of the field isn't shown anywhere in the snippet.
>
> * It would be good to also gear people towards using annotations here
> instead of using the XML for configuring injected instances for field.
>
> Take care,
>
> Geert
>
>
> On 21 Apr 2009, at 01:44, Igal Levy wrote:
>
>> fixed. i've also edited that section to have a more general
>> introduction before focusing on cluster events.
>>
>> ---------------------------------------------------
>> Igal D. Levy
>> Terracotta Inc.
>> terracotta.org | terracottatech.com
>> 415-738-4026
>>
>> ----- Original Message -----
>> From: "Geert Bevin" <gbevin@...>
>> To: "Igal Levy" <ilevy@...>
>> Sent: Monday, April 20, 2009 2:53:34 AM GMT -08:00 US/Canada Pacific
>> Subject: Fwd: [tc-dev] Errors in cluster events documentation
>>
>> Hi Igal,
>>
>> Could you make the relevant changes?
>>
>> Thanks,
>>
>> Geert
>>
>> Begin forwarded message:
>>
>>> From: Sergio Bossa <sergio.bossa@...>
>>> Date: Mon 20 Apr 2009 11:51:40 GMT+02:00
>>> To: tc-dev <tc-dev@...>
>>> Subject: [tc-dev] Errors in cluster events documentation
>>> Reply-To: tc-dev@...
>>>
>>> Hi guys,
>>>
>>> the cluster events documentation at
>>> "http://terracotta.org/web/display/docs/Configuration+Guide+and+Reference#ConfigurationGuideandReference-injectedinstances
>>> "
>>> has the following errors:
>>>
>>> - The "/tc:tc-config/clients/dso/injected-instances" path is wrong,
>>> it
>>> should be: "/tc:tc-config/application/dso/injected-instances"
>>> - The related XML snippet, reported as an example, doesn't actually
>>> contain the field name, but just the class name:
>>> "<field-name>com.mypackage.myClasses.OtherClusterAwareClass</field-
>>> name>"
>>>
>>> Cheers,
>>>
>>> Sergio B.
>>>
>>> --
>>> Sergio Bossa
>>> Software Passionate and Open Source Enthusiast.
>>> Blog : http://sbtourist.blogspot.com
>>> Pro-Netics : http://www.pronetics.it
>>> Sourcesense : http://www.sourcesense.com
>>> _______________________________________________
>>> tc-dev mailing list
>>> tc-dev@...
>>> http://lists.terracotta.org/mailman/listinfo/tc-dev
>>
>> --
>> Geert Bevin
>> Terracotta - http://www.terracotta.org
>> Uwyn "Use what you need" - http://uwyn.com
>> RIFE Java application framework - http://rifers.org
>> Flytecase Band - http://flytecase.be
>> Music and words - http://gbevin.com
>>
>
> --
> Geert Bevin
> Terracotta - http://www.terracotta.org
> Uwyn "Use what you need" - http://uwyn.com
> RIFE Java application framework - http://rifers.org
> Flytecase Band - http://flytecase.be
> Music and words - http://gbevin.com
>
> _______________________________________________
> tc-dev mailing list
> tc-dev@...
> http://lists.terracotta.org/mailman/listinfo/tc-dev
_______________________________________________
tc-dev mailing list
tc-dev@...
http://lists.terracotta.org/mailman/listinfo/tc-dev

Re: Errors in cluster events documentation

by Igal Levy :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

yes, other than that table, the rest of the doc takes that view -- thanks for catching that!

---------------------------------------------------
Igal D. Levy
Terracotta Inc.
terracotta.org | terracottatech.com
415-738-4026

----- Original Message -----
From: "Sergio Bossa" <sergio.bossa@...>
To: tc-dev@...
Cc: "tc-dev" <tc-dev@...>
Sent: Wednesday, May 13, 2009 11:01:30 AM GMT -08:00 US/Canada Pacific
Subject: Re: [tc-dev] Errors in cluster events documentation

Hi,

There seems to be another error in the events table: the nodeJoined  
and nodeLeft events are actually received multiple times, more  
specifically everytime nodes join/leave, rather than once per node  
lifetime as reported in that table.

HTH

Sergio Bossa
Sent by iPhone

Il giorno 13/mag/09, alle ore 19:40, Igal Levy  
<ilevy@...> ha scritto:

> hi Geert,
>
> i've applied some more refactoring to the cluster events doc. i've  
> got a couple of issues still:
>
> 1. is there a good example of how to use SimulatedDsoCluster in a  
> useful test? this is still missed in the doc.
>
> 2. didn't quite understand this comment from below:
>
>>> * "... it will be injected with cluster awareness." -> you don't  
>>> know
>>> that since the type of the field isn't shown anywhere in the  
>>> snippet.
>
> can you elaborate a bit?
>
> tnx,
>
> ---------------------------------------------------
> Igal D. Levy
> Terracotta Inc.
> terracotta.org | terracottatech.com
> 415-738-4026
>
> ----- Original Message -----
> From: "Geert Bevin" <gbevin@...>
> To: "Igal Levy" <ilevy@...>
> Cc: "tc-dev" <tc-dev@...>
> Sent: Tuesday, April 21, 2009 3:40:43 AM GMT -08:00 US/Canada Pacific
> Subject: Re: [tc-dev] Errors in cluster events documentation
>
> Hi Igal,
>
> I read through the intro, great idea to add this.
>
> Some small suggestions:
>
> * "The functionality is injected into a specified field ..." -> I
> understand why you use the generic 'functionality' word here, but it
> reads weird. Functionality isn't injected, instances of particular
> types are, and those instances can provide the functionality.
>
> * "Classes that are not configured for instrumentation by Terracotta
> cannot be injected using this configuration." -> should be "... cannot
> be injected into ..." ie. they need to be configured for
> instrumentation so that their bytecode can be modified to perform the
> injection
>
> * "... it will be injected with cluster awareness." -> you don't know
> that since the type of the field isn't shown anywhere in the snippet.
>
> * It would be good to also gear people towards using annotations here
> instead of using the XML for configuring injected instances for field.
>
> Take care,
>
> Geert
>
>
> On 21 Apr 2009, at 01:44, Igal Levy wrote:
>
>> fixed. i've also edited that section to have a more general
>> introduction before focusing on cluster events.
>>
>> ---------------------------------------------------
>> Igal D. Levy
>> Terracotta Inc.
>> terracotta.org | terracottatech.com
>> 415-738-4026
>>
>> ----- Original Message -----
>> From: "Geert Bevin" <gbevin@...>
>> To: "Igal Levy" <ilevy@...>
>> Sent: Monday, April 20, 2009 2:53:34 AM GMT -08:00 US/Canada Pacific
>> Subject: Fwd: [tc-dev] Errors in cluster events documentation
>>
>> Hi Igal,
>>
>> Could you make the relevant changes?
>>
>> Thanks,
>>
>> Geert
>>
>> Begin forwarded message:
>>
>>> From: Sergio Bossa <sergio.bossa@...>
>>> Date: Mon 20 Apr 2009 11:51:40 GMT+02:00
>>> To: tc-dev <tc-dev@...>
>>> Subject: [tc-dev] Errors in cluster events documentation
>>> Reply-To: tc-dev@...
>>>
>>> Hi guys,
>>>
>>> the cluster events documentation at
>>> "http://terracotta.org/web/display/docs/Configuration+Guide+and+Reference#ConfigurationGuideandReference-injectedinstances
>>> "
>>> has the following errors:
>>>
>>> - The "/tc:tc-config/clients/dso/injected-instances" path is wrong,
>>> it
>>> should be: "/tc:tc-config/application/dso/injected-instances"
>>> - The related XML snippet, reported as an example, doesn't actually
>>> contain the field name, but just the class name:
>>> "<field-name>com.mypackage.myClasses.OtherClusterAwareClass</field-
>>> name>"
>>>
>>> Cheers,
>>>
>>> Sergio B.
>>>
>>> --
>>> Sergio Bossa
>>> Software Passionate and Open Source Enthusiast.
>>> Blog : http://sbtourist.blogspot.com
>>> Pro-Netics : http://www.pronetics.it
>>> Sourcesense : http://www.sourcesense.com
>>> _______________________________________________
>>> tc-dev mailing list
>>> tc-dev@...
>>> http://lists.terracotta.org/mailman/listinfo/tc-dev
>>
>> --
>> Geert Bevin
>> Terracotta - http://www.terracotta.org
>> Uwyn "Use what you need" - http://uwyn.com
>> RIFE Java application framework - http://rifers.org
>> Flytecase Band - http://flytecase.be
>> Music and words - http://gbevin.com
>>
>
> --
> Geert Bevin
> Terracotta - http://www.terracotta.org
> Uwyn "Use what you need" - http://uwyn.com
> RIFE Java application framework - http://rifers.org
> Flytecase Band - http://flytecase.be
> Music and words - http://gbevin.com
>
> _______________________________________________
> tc-dev mailing list
> tc-dev@...
> http://lists.terracotta.org/mailman/listinfo/tc-dev
_______________________________________________
tc-dev mailing list
tc-dev@...
http://lists.terracotta.org/mailman/listinfo/tc-dev
_______________________________________________
tc-dev mailing list
tc-dev@...
http://lists.terracotta.org/mailman/listinfo/tc-dev

Re: Errors in cluster events documentation

by Geert Bevin-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Actually that depends on the point of view you're taking. Those events  
are received only once for one particular node. However, you can  
receive several of those events from different nodes.

On 13 May 2009, at 20:05, Igal Levy wrote:

> yes, other than that table, the rest of the doc takes that view --  
> thanks for catching that!
>
> ---------------------------------------------------
> Igal D. Levy
> Terracotta Inc.
> terracotta.org | terracottatech.com
> 415-738-4026
>
> ----- Original Message -----
> From: "Sergio Bossa" <sergio.bossa@...>
> To: tc-dev@...
> Cc: "tc-dev" <tc-dev@...>
> Sent: Wednesday, May 13, 2009 11:01:30 AM GMT -08:00 US/Canada Pacific
> Subject: Re: [tc-dev] Errors in cluster events documentation
>
> Hi,
>
> There seems to be another error in the events table: the nodeJoined
> and nodeLeft events are actually received multiple times, more
> specifically everytime nodes join/leave, rather than once per node
> lifetime as reported in that table.
>
> HTH
>
> Sergio Bossa
> Sent by iPhone
>
> Il giorno 13/mag/09, alle ore 19:40, Igal Levy
> <ilevy@...> ha scritto:
>
>> hi Geert,
>>
>> i've applied some more refactoring to the cluster events doc. i've
>> got a couple of issues still:
>>
>> 1. is there a good example of how to use SimulatedDsoCluster in a
>> useful test? this is still missed in the doc.
>>
>> 2. didn't quite understand this comment from below:
>>
>>>> * "... it will be injected with cluster awareness." -> you don't
>>>> know
>>>> that since the type of the field isn't shown anywhere in the
>>>> snippet.
>>
>> can you elaborate a bit?
>>
>> tnx,
>>
>> ---------------------------------------------------
>> Igal D. Levy
>> Terracotta Inc.
>> terracotta.org | terracottatech.com
>> 415-738-4026
>>
>> ----- Original Message -----
>> From: "Geert Bevin" <gbevin@...>
>> To: "Igal Levy" <ilevy@...>
>> Cc: "tc-dev" <tc-dev@...>
>> Sent: Tuesday, April 21, 2009 3:40:43 AM GMT -08:00 US/Canada Pacific
>> Subject: Re: [tc-dev] Errors in cluster events documentation
>>
>> Hi Igal,
>>
>> I read through the intro, great idea to add this.
>>
>> Some small suggestions:
>>
>> * "The functionality is injected into a specified field ..." -> I
>> understand why you use the generic 'functionality' word here, but it
>> reads weird. Functionality isn't injected, instances of particular
>> types are, and those instances can provide the functionality.
>>
>> * "Classes that are not configured for instrumentation by Terracotta
>> cannot be injected using this configuration." -> should be "...  
>> cannot
>> be injected into ..." ie. they need to be configured for
>> instrumentation so that their bytecode can be modified to perform the
>> injection
>>
>> * "... it will be injected with cluster awareness." -> you don't know
>> that since the type of the field isn't shown anywhere in the snippet.
>>
>> * It would be good to also gear people towards using annotations here
>> instead of using the XML for configuring injected instances for  
>> field.
>>
>> Take care,
>>
>> Geert
>>
>>
>> On 21 Apr 2009, at 01:44, Igal Levy wrote:
>>
>>> fixed. i've also edited that section to have a more general
>>> introduction before focusing on cluster events.
>>>
>>> ---------------------------------------------------
>>> Igal D. Levy
>>> Terracotta Inc.
>>> terracotta.org | terracottatech.com
>>> 415-738-4026
>>>
>>> ----- Original Message -----
>>> From: "Geert Bevin" <gbevin@...>
>>> To: "Igal Levy" <ilevy@...>
>>> Sent: Monday, April 20, 2009 2:53:34 AM GMT -08:00 US/Canada Pacific
>>> Subject: Fwd: [tc-dev] Errors in cluster events documentation
>>>
>>> Hi Igal,
>>>
>>> Could you make the relevant changes?
>>>
>>> Thanks,
>>>
>>> Geert
>>>
>>> Begin forwarded message:
>>>
>>>> From: Sergio Bossa <sergio.bossa@...>
>>>> Date: Mon 20 Apr 2009 11:51:40 GMT+02:00
>>>> To: tc-dev <tc-dev@...>
>>>> Subject: [tc-dev] Errors in cluster events documentation
>>>> Reply-To: tc-dev@...
>>>>
>>>> Hi guys,
>>>>
>>>> the cluster events documentation at
>>>> "http://terracotta.org/web/display/docs/Configuration+Guide+and+Reference#ConfigurationGuideandReference-injectedinstances
>>>> "
>>>> has the following errors:
>>>>
>>>> - The "/tc:tc-config/clients/dso/injected-instances" path is wrong,
>>>> it
>>>> should be: "/tc:tc-config/application/dso/injected-instances"
>>>> - The related XML snippet, reported as an example, doesn't actually
>>>> contain the field name, but just the class name:
>>>> "<field-name>com.mypackage.myClasses.OtherClusterAwareClass</field-
>>>> name>"
>>>>
>>>> Cheers,
>>>>
>>>> Sergio B.
>>>>
>>>> --
>>>> Sergio Bossa
>>>> Software Passionate and Open Source Enthusiast.
>>>> Blog : http://sbtourist.blogspot.com
>>>> Pro-Netics : http://www.pronetics.it
>>>> Sourcesense : http://www.sourcesense.com
>>>> _______________________________________________
>>>> tc-dev mailing list
>>>> tc-dev@...
>>>> http://lists.terracotta.org/mailman/listinfo/tc-dev
>>>
>>> --
>>> Geert Bevin
>>> Terracotta - http://www.terracotta.org
>>> Uwyn "Use what you need" - http://uwyn.com
>>> RIFE Java application framework - http://rifers.org
>>> Flytecase Band - http://flytecase.be
>>> Music and words - http://gbevin.com
>>>
>>
>> --
>> Geert Bevin
>> Terracotta - http://www.terracotta.org
>> Uwyn "Use what you need" - http://uwyn.com
>> RIFE Java application framework - http://rifers.org
>> Flytecase Band - http://flytecase.be
>> Music and words - http://gbevin.com
>>
>> _______________________________________________
>> tc-dev mailing list
>> tc-dev@...
>> http://lists.terracotta.org/mailman/listinfo/tc-dev
> _______________________________________________
> tc-dev mailing list
> tc-dev@...
> http://lists.terracotta.org/mailman/listinfo/tc-dev
> _______________________________________________
> tc-dev mailing list
> tc-dev@...
> http://lists.terracotta.org/mailman/listinfo/tc-dev

--
Geert Bevin
Terracotta - http://www.terracotta.org
Uwyn "Use what you need" - http://uwyn.com
RIFE Java application framework - http://rifers.org
Flytecase Band - http://flytecase.be
Music and words - http://gbevin.com

_______________________________________________
tc-dev mailing list
tc-dev@...
http://lists.terracotta.org/mailman/listinfo/tc-dev