On 22/06/2009, at 2:11 PM, Richard Vowles wrote:
[I am thinking you might be in the same/similar timezone to me?]
East Coast Australia (Brisbane), so GMT +10.
On Mon, Jun 22, 2009 at 3:56 PM, Luke Daley
<ld@...> wrote:
On 22/06/2009, at 1:49 PM, Richard Vowles wrote:
I think you are talking about _Install.groovy? I'm not really sure of what the problems are with _Install, but that doesn't solve the problem with general runtime uses where the Events script depends on compiled classes (which will always fail). I could implement a specific solution to this problem for easyb, I'm just trying to implement a generic solution that won't impact on the performance or use of scripts for anyone who doesn't need to use it.
Ah yes I am.
Why can't the classes be compiled before _Events is?
That would mean that no events could fire before _GrailsCompile.groovy were completed - and that would be a change in behavior that would probably have far reaching consequences and unlikely to pass the powers that be.
Can _Install not just depend on compile when it is run?
Would that compile the plugin to be installed as well?
[I have this feeling you are trying to lead me to a conclusion and I am not getting it]
You would be compiling the current project, so yes. But the problem is that when you try and compile a plugin, the plugin distribution prevents files that Grails expects to exist from being included, hence it won't compile (currently). If the Grails compliation mechanism could be changed to recognize it was in a plugin and thus missing those things was OK, then I can't see a problem here. But then you would get items in your ~/.grails/version/projects directory matching each plugin that you install. Not sure this is a bad thing, but it is a thing.
I don't really follow you here.
IMHO, some changes in Grails compilation are in order because when you store your project in a Git repository, it doesn't version empty directories. If you have nothing in src/java or grails-app/conf/resource then when you check it out it won't compile (for example). But that is a different issue. I'm just trying to get a zero impact change for _Events.groovy implemented so I can finish grails-easyb and grails-easyb-gfunc.
I am not sure a zero impact change is possible.
The current gfunc plugin errors on installation because of this problem. In my opinion you should ship what you have and just advertise that you will get errors on install because of this Grails bug. Then once the version comes out with your patch everything will be great :)
Thanks for working on these plugins BTW. I am looking forward to using them.