« Return to Thread: FSFS bug with mixed revision commit

Re: FSFS bug with mixed revision commit

by Philip Martin :: Rate this Message:

"Peter N. Lundblad" <peter@...> writes:

> Below is a reproduction recipe for what I think is a bug in FSFS. That's
> the bug that got triggered by r14738. It copies a dir at revision 1 with a
> file at revision 2 that is also modified. Any suggestions?
>
> pl@fnapp:~/svntest$ svnadmin create repo
> pl@fnapp:~/svntest$ export R=file://`pwd`/repo
> pl@fnapp:~/svntest$ svn co $R wc
> Checked out revision 0.
> pl@fnapp:~/svntest$ cd wc
> pl@fnapp:~/svntest/wc$ svn mkdir a
> A a
> pl@fnapp:~/svntest/wc$ touch a/f
> pl@fnapp:~/svntest/wc$ svn add a/f
> A a/f
> pl@fnapp:~/svntest/wc$ svn ci -m m
> Adding a
> Adding a/f
> Transmitting file data .
> Committed revision 1.
> pl@fnapp:~/svntest/wc$ echo hej > a/f
> pl@fnapp:~/svntest/wc$ svn ci -m m
> Sending a/f
> Transmitting file data .
> Committed revision 2.
> pl@fnapp:~/svntest/wc$ svn up -r1
> U a/f
> Updated to revision 1.
> pl@fnapp:~/svntest/wc$ svn up a/f
> U a/f
> Updated to revision 2.

You don't need these two updates to trigger the bug.

> pl@fnapp:~/svntest/wc$ echo hoj > a/f
> pl@fnapp:~/svntest/wc$ svn cp a $R/b -m 'mixed wc copy'
> subversion/libsvn_client/copy.c:544: (apr_err=160004)
> svn: Commit failed (details follow):
> subversion/libsvn_fs_fs/fs_fs.c:1973: (apr_err=160004)
> svn: Invalid change ordering: new node revision ID without delete

The commit fails over ra_local and ra_svn, but works over
ra_dav. Here's what ra_dav commits:

$ svnlook tree --show-ids -r2 repo
/ <0.0.r2/370>
a/ <1.0.r2/200>
f <2.0.r2/32>
$ svnlook tree --show-ids -r3 repo
/ <0.0.r3/403>
a/ <1.0.r2/200>
f <2.0.r2/32>
b/ <1.1.r3/206>
f <2.2.r3/35>

I remember that error message, it's been reported before:

http://svn.haxx.se/dev/archive-2004-11/1136.shtml

so the bug has been present since early 1.1, i.e. it's probably not
release critical.

--
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

« Return to Thread: FSFS bug with mixed revision commit