« Return to Thread: Re: Google hates Twibright Links

Re: Google hates Twibright Links

by Mikulas Patocka :: Rate this Message:

Reply to Author | View in Thread

Hi

This is an error in libpng. Apply this patch to libpng:

--- pngrtran.c_ 2007-06-25 03:58:01.000000000 +0200
+++ pngrtran.c  2007-06-25 03:58:38.000000000 +0200
@@ -1294,9 +1294,9 @@
        if(rgb_error)
        {
           png_ptr->rgb_to_gray_status=1;
-         if(png_ptr->transformations & PNG_RGB_TO_GRAY_WARN)
+         if((png_ptr->transformations & PNG_RGB_TO_GRAY) == PNG_RGB_TO_GRAY_WARN)
              png_warning(png_ptr, "png_do_rgb_to_gray found nongray
pixel");
-         if(png_ptr->transformations & PNG_RGB_TO_GRAY_ERR)
+         if((png_ptr->transformations & PNG_RGB_TO_GRAY) == PNG_RGB_TO_GRAY_ERR)
              png_error(png_ptr, "png_do_rgb_to_gray found nongray pixel");
        }
     }

--- alternatively, you can use older libpng (1.2.5 works OK, 1.2.18 has
problems, they broke it somewhere between these).

I attach a file that contains all links characters, you can view this file
in graphics mode links to test if the error happens.

For libpng developers: man page says that error_action == 1 means to not
report any errors. On error_action == 1 you set PNG_RGB_TO_GRAY that has
both bits PNG_RGB_TO_GRAY_ERR and PNG_RGB_TO_GRAY_WARN set.

Mikulas

> Hi Mikulas,
>
> Recently I've had Twibright Links crash for the first time ever. There
> is one particular company whose websites cause the crash.
> Unfortunately, that company is google.com. This only started in the
> last couple of weeks and I think it's because google added some kind
> of pull down menu at the top of their sites. Basically Links works
> flawlessly except when I go to Google where it promptly dies with the
> following messages on the console:
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> :-> [xed][~]$ /usr/bin/links -g
> Error when loading compiled-in font: png_do_rgb_to_gray found nongray
> pixel.
> libpng error: png_do_rgb_to_gray found nongray pixel
> Aborted
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> I'm running "Links 2.1pre28" and I've recompiled libpng (1.2.18).
>
> I'm wondering if the problem could be related to these items in the
> change log:
> Wed Mar 21 04:37:42 MET 2007 mikulas:
>        Limit image scaling to prevent allocation overflow
> Tue Feb  6 00:23:43 MET 2007 mikulas:
>        Allow quotation marks in Refresh URL parameter --- fixes Google Picasa
>
> Any help or suggestions you can offer would be greatly appreciated.
> I'm trying to use dogpile.com, but not being able to use Google is
> pretty harsh.
>
> Hope you're doing well. I keep trying to spread the good word about
> how great Twibright Links is. Keep up the good work.
>
> Thanks
>
> --
> ++++++++++[>++++++++++++<-]>-...<++++++[>>+++++++<<-]>>++++.<+.<++++[>
> Chris X Edwards-----<-]>+.- Have a nice day. >.<-.+++++><chris@...>
>

































!
"
#
$
%
&
'
(
)
*
+
,
-
.
/
0
1
2
3
4
5
6
7
8
9
:
;
<
=
>
?
@
A
B
C
D
E
F
G
H
I
J
K
L
M
N
O
P
Q
R
S
T
U
V
W
X
Y
Z
[
\
]
^
_
`
a
b
c
d
e
f
g
h
i
j
k
l
m
n
o
p
q
r
s
t
u
v
w
x
y
z
{
|
}
~




ƒ




ˆ

Š

Œ

Ž









˜

š

œ

ž
Ÿ
 
¡
¢
£
¤
¥
¦
§
¨
©
«
¬
­
®
¯
°
±
´
µ

·
¸
º
»
¿
À
Á
Â
Ã
Ä
Å
Æ
Ç
È
É
Ê
Ë
Ì
Í
Î
Ï
Ð
Ñ
Ò
Ó
Ô
Õ
Ö
×
Ø
Ù
Ú
Û
Ü
Ý
Þ
ß
à
á
â
ã
ä
å
æ
ç
è
é
ê
ë
ì
í
î
ï
ð
ñ
ò
ó
ô
õ
ö
÷
ø
ù
ú
û
ü
ý
þ
ÿ
Ā
ā
Ă
ă
Ą
ą
Ć
ć
Ĉ
ĉ
Ċ
ċ
Č
č
Ď
ď
Đ
đ
Ē
ē
Ĕ
ĕ
Ė
ė
Ę
ę
Ě
ě
Ĝ
ĝ
Ğ
ğ
Ġ
ġ
ģ
Ĥ
ĥ
Ħ
ħ
Ĩ
ĩ
Ī
ī
Ĭ
ĭ
Į
į
İ
ı
IJ
ij
Ĵ
ĵ
Ķ
ķ
ĸ
Ĺ
ĺ
Ļ
ļ
Ľ
ľ
Ŀ
ŀ
Ł
ł
Ń
ń
Ņ
ņ
Ň
ň
ʼn
Ŋ
ŋ
Ō
ō
Ŏ
ŏ
Ő
ő
Œ
œ
Ŕ
ŕ
Ŗ
ŗ
Ř
ř
Ś
ś
Ŝ
ŝ
Ş
ş
Š
š
Ţ
ţ
Ť
ť
Ŧ
ŧ
Ũ
ũ
Ū
ū
Ŭ
ŭ
Ů
ů
Ű
ű
Ų
ų
Ŵ
ŵ
Ŷ
ŷ
Ÿ
Ź
ź
Ż
ż
Ž
ž
ſ
Ɔ
Ƈ
ƈ
Ɖ
Ɗ
ƌ
Ǝ
Ə
Ɛ
Ƒ
ƒ
Ɠ
Ɨ
Ƙ
ƙ
ƚ
ƛ
Ɯ
Ɲ
ƞ
Ɵ
ǃ
DŽ
Dž
dž
LJ
Lj
lj
NJ
Nj
nj
Ǎ
ǎ
Ǐ
ǐ
Ǒ
ǒ
Ǔ
ǔ
Ǧ
ǧ
Ǩ
ǩ
Ǫ
ǫ
ǰ
Ǵ
ǵ
Ǹ
ǹ
Ș
ș
Ț
ț
Ȧ
ȧ
Ȱ
ȱ
ˆ
ˇ
˙
˚
˛
˜
˝
̀
̆
̋
Ά
·
Έ
Ή
Ί
Ό
Ύ
Ώ
ΐ
Α
Β
Γ
Δ
Ε
Ζ
Η
Θ
Ι
Κ
Λ
Μ
Ν
Ξ
Ο
Π
Ρ
Σ
Τ
Υ
Φ
Χ
Ψ
Ω
Ϊ
Ϋ
ά
έ
ή
ί
ΰ
α
β
γ
δ
ε
ζ
η
θ
ι
κ
λ
μ
ν
ξ
ο
π
ρ
ς
σ
τ
υ
φ
χ
ψ
ω
ϊ
ϋ
ό
ύ
ώ
ϐ
ϑ
ϒ
ϓ
ϔ
ϕ
ϖ
ϗ
ϰ
Ё
Ђ
Є
І
Ї
Ј
Љ
Њ
Ћ
Џ
А
Б
В
Г
Д
Е
Ж
З
И
Й
К
Л
М
Н
О
П
Р
С
Т
У
Ф
Х
Ц
Ч
Ш
Щ
Ъ
Ы
Ь
Э
Ю
Я
а
б
в
г
д
е
ж
з
и
й
к
л
м
н
о
п
р
с
т
у
ф
х
ц
ч
ш
щ
ъ
ы
ь
э
ю
я
ё
ђ
є
і
ї
ј
љ
њ
ћ
ў
џ
Ѣ
ѣ
Ѳ
ѳ
א
ב
ג
ד
ה
ו
ז
ח
ט
י
ך
כ
ל
ם
מ
ן
נ
ס
ע
ף
פ
ץ
צ
ק
ר
ש
ת
؄
،
؛
؟
ء
آ
أ
ؤ
إ
ئ
ا
ب
ت
ث
ج
ح
خ
د
ذ
ر
ز
س
ش
ص
ض
ط
ظ
ع
غ
ـ
ف
ق
ك
ل
م
ن
ه
و
ى
ي
ً
ٌ
ٍ
َ
ُ
ِ
ّ
ْ
٠
١
٢
٣
٤
٥
٦
٧
٨
٩
٪
٬
٭
ٰ
ٱ
ٴ
چ
ڍ
ژ
ک
گ
ھ
ۂ
ۃ
ی
ە
ۙ
۰
۱
۲
۳
۴
۵
۶
۷
۸
۹



























































































































































































































































































































































































































































-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
png-mng-implement mailing list
png-mng-implement@...
https://lists.sourceforge.net/lists/listinfo/png-mng-implement

 « Return to Thread: Re: Google hates Twibright Links