Re: JavaRpc code modularity

Hi Michael,

Am 19.03.2009 um 08:56 schrieb Michael Wyraz:

> I had a look to JavaRpc because I'd wanted to integrate it into  
> spring.
> I have seen that the code is not very modular: the RPC handling code,
> servlet specific code and other is all in the RpcServlet.

I'm the original author of the RPC code, and I agree that some  
modularity would be very nice. There was a similar discussion back in  
2007:

http://sourceforge.net/mailarchive/forum.php?thread_name=DD15AEA9AC775A43B16E2D31B5FCC7F03E86D1%40exchange.GERMO.DE&forum_name=qooxdoo-devel

One of the proposed refactorings went way too far IMHO, creating 31  
classes/interfaces in total and adding unnecessary external  
dependencies. The code of the other refactoring/rewrite never appeared  
on the list (or in qooxdoo-contrib), so I can't say much about it.

> The code
> forces the developer that the Service implementation uses the
> RemoteService interface and any method declares "throws  
> RemoteException".

This is the simplest way to protect people from accidentally  
"publishing" classes or methods that should not be callable from the  
browser. The way this is handled now, you can simply write some  
services and drop them in the server's classpath - no need to  
configure anything.

By now, I guess JDK 1.4 compatibility isn't important anymore, so a  
better solution would be to use annotations (or maybe some external  
configuration, although I'm not too fond of that - a simple "drop a  
JAR" solution should still exist in any new version).

> Because I need to integrate it in my project structure, I'm going to
> cleanup the code a lot. The result will reuse much of the existing  
> code
> but will have much cleaner structure. If you're interested, I'll
> contribute the result. Who should I do this? Give it a new name and
> contribute it as a fork? Send the result to the initial developers?

I would suggest to make it a new qooxdoo-contrib project. If it works  
out well, we can move the code to the standard RpcJava contrib later  
on (provided it's compatible to the old version).

Regards,

   Andreas


------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@...
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel