Re: Meaning of CVS HEAD on facelets?

View: New views
3 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: Meaning of CVS HEAD on facelets?

by Ryan Lubke :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Unless Jacob says otherwise, I would recommend creating a new branch for
1.2 based on the current head
as I'm uncertain of the state of any features that were added to the
release_1-2 branch.

That having been said, I'm -1 on the dtd changes.  As far as I can tell,
in 2.0 handler-class is not optional
and there is no 'resource' element.  Adding these changes could lead to
backwards compatibility issues.

On 8/10/09 1:58 PM, Ed Burns wrote:

> I haven't seen a reply to this, so I'm resending.
>    
>>>>>> On Fri, 17 Jul 2009 16:19:22 -0700, Ed Burns<ed.burns@...>  said:
>>>>>>              
> EB>  Hello Facelets team,
> EB>  I'd like to know the right place for "facelets for JSF 1.2" work.  We
> EB>  used to have a release_1-2 branch, but I see that Ryan has been checking
> EB>  code straight into the HEAD.  I have fixed several issues specific to
> EB>  1.2 but they are not on the CVS HEAD.
>
> EB>  As far as I know, the CVS HEAD of facelets is still for "facelets for
> EB>  JSF 1.1".  Is this correct?
>    
> EB>  The reason I ask is that I have a performance enhancement from Credit
> EB>  Suisse that I'd like to check in [1], but I don't know what's the right
> EB>  place anymore.
>
> EB>  Thanks,
>
> EB>  Ed
>
> EB>  [1] https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1176
>
> EB>  P.S. Here is some archival data on the ancient history of this issue.
>
>    
>>>>>> On Tue, 12 Feb 2008 05:25:35 -0800, Ed Burns<ed.burns@...>  said:
>>>>>>              
> EB>  On 30 November 2006, Ed Burns wrote:
> EB>  Hello,
>
> EB>  Ever since JavaOne, when Jacob made some mods to facelets with a
> EB>  view towards declaring it Facelets 1.2, I've been using those mods
> EB>  for our Dynamic Faces project [1].  Since then, I've been using a
> EB>  home-build "facelets 1.1.10a" jar that includes these changes.
>
> EB>  It's now time to try to get these changes into the core Facelets code.
>
> EB>  I've filed three bugs: [2] [3] [4] and this code is checked in on a
> EB>  branch.  Jacob, can you please help me get this into the core?
> EB>  Doing so will force you to decide the issue of what is the plan for
> EB>  facelets with respect to JSF 1.2.  Do we do a separate release for
> EB>  1.2, etc...
>
> EB>  Ed
>
> JH>  Thanks for the patches!
>
> JH>  the 'release_1-2' branch is JSF 1.2 specific and will have some
> JH>  additional features added, the 1.1/Head is in maintenance mode
>
> EB>  Jacob, is release_1-2 still the place for the most current Facelets
> EB>  development?  I would really like to get the fix for [2] in there.  What
> EB>  is the right place, and may I check it in?  I've attached diffs to the
> EB>  bug.
>
>
> EB>  [2] https://facelets.dev.java.net/issues/show_bug.cgi?id=183
>
> EB>  RCS file: /cvs/facelets/src/etc/facelet-taglib_1_0.dtd,v
> EB>  Working file: src/etc/facelet-taglib_1_0.dtd
> EB>  head: 1.4
> EB>  branch:
> EB>  locks: strict
> EB>  access list:
> EB>  keyword substitution: kv
> EB>  total revisions: 11; selected revisions: 1
> EB>  description:
> EB>  ----------------------------
> EB>  revision 1.3.16.1
> EB>  date: 2006/11/30 13:54:17;  author: edburns;  state: Exp;  lines: +6 -3
> EB>  Issue: 183 JSF 1.2 support
> EB>  Issue: 184 Fix build system to not mess with CVS
> EB>  Issue: 185 TLD Errors
>
> EB>  SECTION: Changes
>
> EB>  M build.xml
>
> EB>  - copy the downloading ant file from Sun JSF Impl, authored by Ryan
> EB>    Lubke.  Use it to satisfy dependencies from Maven Repositories.
>
> EB>  M src/etc/facelet-taglib_1_0.dtd
>
> EB>  - add "resource" to facelet-taglib
>
> EB>  - make handler-class optional.
>
> EB>  - define elements for resource, resource-path, and mime-type
>
> EB>  M src/java/com/sun/facelets/component/UIRepeat.java
>
> EB>  - uncomment invokeOnComponent.
>
> EB>  --
> EB>  | ed.burns@...  | office: 408 884 9519 OR x31640
> EB>  | homepage:         | http://ridingthecrest.com/
>
>
>    


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Parent Message unknown Re: Meaning of CVS HEAD on facelets?

by Ed Burns :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

>>>>> On Mon, 10 Aug 2009 02:13:49 -0700, Ryan Lubke <Ryan.Lubke@...> said:

RL> Unless Jacob says otherwise, I would recommend creating a new branch for
RL> 1.2 based on the current head
RL> as I'm uncertain of the state of any features that were added to the
RL> release_1-2 branch.

I feel more comfortable just updating the release_1-2 branch.  I'll do
the necessary CVS archeology to make sure it has the right code.

RL> That having been said, I'm -1 on the dtd changes.  As far as I can tell,
RL> in 2.0 handler-class is not optional

RL> and there is no 'resource' element.  Adding these changes could lead to
RL> backwards compatibility issues.

Ok, I'll not do those.

Ed

--
| ed.burns@...  | office: 408 884 9519 OR x31640
| homepage:         | http://ridingthecrest.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Meaning of CVS HEAD on facelets?

by Jacob Hookom :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I have no problems with a branch.

As for the dtd changes, if it does introduce backwards compat issues,
then I wouldn't make them in the hopes of driving adopters to the full
2.0 implementation.  The statesaving optimization is incremental, but
really, anything assigned from the view should be stateless, more so for
non-VEs.

Ryan Lubke wrote:

> Unless Jacob says otherwise, I would recommend creating a new branch
> for 1.2 based on the current head
> as I'm uncertain of the state of any features that were added to the
> release_1-2 branch.
>
> That having been said, I'm -1 on the dtd changes.  As far as I can
> tell, in 2.0 handler-class is not optional
> and there is no 'resource' element.  Adding these changes could lead
> to backwards compatibility issues.
>
> On 8/10/09 1:58 PM, Ed Burns wrote:
>> I haven't seen a reply to this, so I'm resending.
>>  
>>>>>>> On Fri, 17 Jul 2009 16:19:22 -0700, Ed Burns<ed.burns@...>  
>>>>>>> said:
>>>>>>>              
>> EB>  Hello Facelets team,
>> EB>  I'd like to know the right place for "facelets for JSF 1.2"
>> work.  We
>> EB>  used to have a release_1-2 branch, but I see that Ryan has been
>> checking
>> EB>  code straight into the HEAD.  I have fixed several issues
>> specific to
>> EB>  1.2 but they are not on the CVS HEAD.
>>
>> EB>  As far as I know, the CVS HEAD of facelets is still for
>> "facelets for
>> EB>  JSF 1.1".  Is this correct?
>>    EB>  The reason I ask is that I have a performance enhancement
>> from Credit
>> EB>  Suisse that I'd like to check in [1], but I don't know what's
>> the right
>> EB>  place anymore.
>>
>> EB>  Thanks,
>>
>> EB>  Ed
>>
>> EB>  [1]
>>
>> EB>  P.S. Here is some archival data on the ancient history of this
>> issue.
>>
>>  
>>>>>>> On Tue, 12 Feb 2008 05:25:35 -0800, Ed Burns<ed.burns@...>  
>>>>>>> said:
>>>>>>>              
>> EB>  On 30 November 2006, Ed Burns wrote:
>> EB>  Hello,
>>
>> EB>  Ever since JavaOne, when Jacob made some mods to facelets with a
>> EB>  view towards declaring it Facelets 1.2, I've been using those mods
>> EB>  for our Dynamic Faces project [1].  Since then, I've been using a
>> EB>  home-build "facelets 1.1.10a" jar that includes these changes.
>>
>> EB>  It's now time to try to get these changes into the core Facelets
>> code.
>>
>> EB>  I've filed three bugs: [2] [3] [4] and this code is checked in on a
>> EB>  branch.  Jacob, can you please help me get this into the core?
>> EB>  Doing so will force you to decide the issue of what is the plan for
>> EB>  facelets with respect to JSF 1.2.  Do we do a separate release for
>> EB>  1.2, etc...
>>
>> EB>  Ed
>>
>> JH>  Thanks for the patches!
>>
>> JH>  the 'release_1-2' branch is JSF 1.2 specific and will have some
>> JH>  additional features added, the 1.1/Head is in maintenance mode
>>
>> EB>  Jacob, is release_1-2 still the place for the most current Facelets
>> EB>  development?  I would really like to get the fix for [2] in
>> there.  What
>> EB>  is the right place, and may I check it in?  I've attached diffs
>> to the
>> EB>  bug.
>>
>>
>> EB>  [2] https://facelets.dev.java.net/issues/show_bug.cgi?id=183
>>
>> EB>  RCS file: /cvs/facelets/src/etc/facelet-taglib_1_0.dtd,v
>> EB>  Working file: src/etc/facelet-taglib_1_0.dtd
>> EB>  head: 1.4
>> EB>  branch:
>> EB>  locks: strict
>> EB>  access list:
>> EB>  keyword substitution: kv
>> EB>  total revisions: 11;    selected revisions: 1
>> EB>  description:
>> EB>  ----------------------------
>> EB>  revision 1.3.16.1
>> EB>  date: 2006/11/30 13:54:17;  author: edburns;  state: Exp;  
>> lines: +6 -3
>> EB>  Issue: 183 JSF 1.2 support
>> EB>  Issue: 184 Fix build system to not mess with CVS
>> EB>  Issue: 185 TLD Errors
>>
>> EB>  SECTION: Changes
>>
>> EB>  M build.xml
>>
>> EB>  - copy the downloading ant file from Sun JSF Impl, authored by Ryan
>> EB>    Lubke.  Use it to satisfy dependencies from Maven Repositories.
>>
>> EB>  M src/etc/facelet-taglib_1_0.dtd
>>
>> EB>  - add "resource" to facelet-taglib
>>
>> EB>  - make handler-class optional.
>>
>> EB>  - define elements for resource, resource-path, and mime-type
>>
>> EB>  M src/java/com/sun/facelets/component/UIRepeat.java
>>
>> EB>  - uncomment invokeOnComponent.
>>
>> EB>  -- EB>  | ed.burns@...  | office: 408 884 9519 OR x31640
>> EB>  | homepage:         | http://ridingthecrest.com/
>>
>>
>>    
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
> ------------------------------------------------------------------------
>
>
> No virus found in this incoming message.
> Checked by AVG - www.avg.com
> Version: 8.5.392 / Virus Database: 270.13.49/2294 - Release Date: 08/10/09 06:10:00
>
>  


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...