Re: Menus items icons

[Pierre Wieser-2]

----- "Pierre Wieser" <pwieser@...> wrote:

> Hi Nautilus guys
>
> I have began to work with Jelle de Jong in order to define a common
> format for action extensions with Xfce file manager. As I was looking
> at [1], I realized that I might have badly interpreted [2].
>
> In Nautilus-Actions, user used to be free to define a themed icon or a
> path-based one. And it is perfectly conceivable - at least for me -
> that a user define a set of actions with its own set of custom icons,
> which will be path-based.
>
> For now, path-based icons defined for Nautilus actions are no more
> displayed in Nautilus context menus.
>
> This is because somewhere between 2.20 and 2.22, Nautilus has switched
> from a path-based icon lookup to a theme-based one
> (fm-directory-view.c:add_extension_action_for_files()). The comment in
> the source states that "this should really used themed icons".
>
> So, is it really a decision to only display themed icon in Nautilus
> menus, as this appears to me as a restriction to [1], and I don't
> understand the rationale behind this ?
>
> If not, should I open a bug ? Join a patch to it ?
>
> Thanks in advance for your help
> Regards
> Pierre
>
> [1]
> http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
> [2] http://bugzilla.gnome.org/show_bug.cgi?id=525845

Well, I just have taken the time to write and test a small patch
to fix this issue.

I have tested this patch against current gnome-2-28 and master
branches.

The patch has been made with 'git diff' and should so be applied
with 'patch -p1'. It is joined to this mail, and also as an
attachment to [2].

Could you be kind enough to review and commit it if you agree,
please ?

Thanks in advance for our users.

Regards
Pierre


--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list