Re: Menus items icons

[Pierre Wieser-2]

----- "Pierre Wieser" <pwieser@...> a écrit :

> ----- "Pierre Wieser" <pwieser@...> wrote:
>
> Well, I just have taken the time to write and test a small patch
> to fix this issue.
> I have tested this patch against current gnome-2-28 and master
> branches.
> The patch has been made with 'git diff' and should so be applied
> with 'patch -p1'. It is joined to this mail, and also as an
> attachment to [2].
> Could you be kind enough to review and commit it if you agree,
> please ?
> Thanks in advance for our users.
>
> Regards
> Pierre

Hi Nautilus guys !

Is there anybody here ?

Patches are as eggs : when not fresh, they have to be trashed ;-)

As stated in Nautilus README.commits file, I have first asked,
and then asked.

While Nautilus team appears to have no time to review and
commit the patch, I'm clearly hesitant about committing it myself.
Or should I commit ?

Thanks in advance for your time, and, always, our users.
Regards
Pierre

[1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
[2] http://bugzilla.gnome.org/show_bug.cgi?id=525845
[3] http://mail.gnome.org/archives/nautilus-list/2009-August/msg00015.html
[4] http://mail.gnome.org/archives/nautilus-list/2009-October/msg00024.html
--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list

[Andre Klapper]

*ping* to nauilus maintainers.

Am Donnerstag, den 29.10.2009, 15:12 +0100 schrieb pwieser@...:

> ----- "Pierre Wieser" <pwieser@...> a écrit :
> > ----- "Pierre Wieser" <pwieser@...> wrote:
> >
> > Well, I just have taken the time to write and test a small patch
> > to fix this issue.
> > I have tested this patch against current gnome-2-28 and master
> > branches.
> > The patch has been made with 'git diff' and should so be applied
> > with 'patch -p1'. It is joined to this mail, and also as an
> > attachment to [2].
> > Could you be kind enough to review and commit it if you agree,
> > please ?
> > Thanks in advance for our users.
> >
> > Regards
> > Pierre
>
> Hi Nautilus guys !
>
> Is there anybody here ?
>
> Patches are as eggs : when not fresh, they have to be trashed ;-)
>
> As stated in Nautilus README.commits file, I have first asked,
> and then asked.
>
> While Nautilus team appears to have no time to review and
> commit the patch, I'm clearly hesitant about committing it myself.
> Or should I commit ?
>
> Thanks in advance for your time, and, always, our users.
> Regards
> Pierre
>
> [1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
> [2] http://bugzilla.gnome.org/show_bug.cgi?id=525845
> [3] http://mail.gnome.org/archives/nautilus-list/2009-August/msg00015.html
> [4] http://mail.gnome.org/archives/nautilus-list/2009-October/msg00024.html
> --
> nautilus-list mailing list
> nautilus-list@...
> http://mail.gnome.org/mailman/listinfo/nautilus-list

--
 mailto:ak-47@... | failed
 http://www.iomc.de/  | http://blogs.gnome.org/aklapper

--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list

[Gilles Dartiguelongue-4]

I'm no nautilus developer but two things to keep in mind when writing
patches:
 * do not mix code changes with cosmetic changes ever (whitespace, ...)
 * stick to the surrounding code style (that also means paying attention
to the indentation, tab vs. spaces, ...)

That could reduce the patch size a bit and allow reviewers to be more
focused on the actual code change.

--
Gilles Dartiguelongue <gilles.dartiguelongue@...>


--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list