« Return to Thread: New driver for Vlsys mplay (the one in Zalman Hd135 case)

Re: New driver for Vlsys mplay (the one in Zalman Hd135 case)

by ben905 :: Rate this Message:

Hi,

> You just need to modify setup.data. autogen.sh will create everything
> requried.
>
> Some comments regarding implementation:
>
> - mplay_deinit: please reset hw.fd to -1
>
> - mplay_rec: if the read fails, call mplay_deinit to close the device.
> This will prevent endless looping when the device is disconnected.
>
> - please don't use C++ comments
>
> - intendation should be 8
>
> - mplay_decode: the interface has changed in latest CVS. Please update
> your code
>
> Please attach your patch as a file next time instead of sending it
> inline in the message.
>
> Christoph

Christoph, I have modify what you want:
- reset hw.fd in deinit,
- call deinit in rec if the read file,
- use only C comments,
- use an intendation of 8,
- update the interface of mplay_decode.
I also do :
- add information about how the device work,
- add the driver to the configuration interface,
- add some comment,
- identify and resolve an issu with key repetition (see comment in .c file),
- test the driver on my htpc during few days,
- and test if the driver work well in collaboration with the new lcdproc
driver for the lcd integrated in the device.

The patch is for the cvs version of lirc.

Benoit

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

mplay_driver_lirc_cvs.patch.bz2 (7K) Download Attachment

« Return to Thread: New driver for Vlsys mplay (the one in Zalman Hd135 case)