Re: Notification error

[Christopher James Halse Rogers-3]

On Sun, 2009-10-18 at 06:00 -0700, vaskark wrote:
> I have notifications turned on in Banshee, and recently I've noticed an
> ommission of 'by' between song title and artist. Example:
>
> Now Playing
> Jesus Christ Pose Soundgarden
>
> I'm using the latest banshee (git) on ubuntu (karmic beta). Is anyone else
> seeing this?
> Many thanks.

This is due to NotifyOSD stripping newlines (and other formatting) from
notifications.  Banshee is sending
"Jesus Christ\n<i>Pose Soundgarden</i>" expecting it to be rendered as
"""
Jesus Christ
/Pose Soundgarden/
"""
but NotifyOSD strips the newline & formatting, so you see
"""
Jesus Christ Pose Soundgarden
""".

It's worth a bug, but I'm not sure what the best way to resolve it would
be.  Special-casing for notifyosd seems pretty ugly (particularly since
you really are special-casing for notifyosd - you can't simply check for
the "body-markup" capability[1]), and I'd expect resistance to using
only the lowest-common-denominator capabilities everywhere.

It's probably also worth a bug against the Ubuntu package; we could
easily patch in a "by" rather than "\n", which would hide the problem
for (I presume) almost all users of notifyosd.

[1] https://wiki.ubuntu.com/NotifyOSD#sanitizing


_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list

[Alexander Kojevnikov]

2009/10/29 Christopher James Halse Rogers > This is due to NotifyOSD
stripping newlines (and other formatting) from

> notifications.  Banshee is sending
> "Jesus Christ\n<i>Pose Soundgarden</i>" expecting it to be rendered as
> """
> Jesus Christ
> /Pose Soundgarden/
> """
> but NotifyOSD strips the newline & formatting, so you see
> """
> Jesus Christ Pose Soundgarden
> """.
>
> It's worth a bug, but I'm not sure what the best way to resolve it would
> be.  Special-casing for notifyosd seems pretty ugly (particularly since
> you really are special-casing for notifyosd - you can't simply check for
> the "body-markup" capability[1]), and I'd expect resistance to using
> only the lowest-common-denominator capabilities everywhere.
>
> It's probably also worth a bug against the Ubuntu package; we could
> easily patch in a "by" rather than "\n", which would hide the problem
> for (I presume) almost all users of notifyosd.
>
> [1] https://wiki.ubuntu.com/NotifyOSD#sanitizing

Another alternative is using the patch from
https://bugzilla.gnome.org/show_bug.cgi?id=565453
_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list

[Chow Loong Jin]

I'd like to chip in, after having bugged the notify-osd people about this issue.

Newlines in the title are stripped, but not in the body. However, multiple
consecutive newlines in the body will be merged together.

Here's the snippet from wiki.ubuntu.com:

======================
Body text

The body should be 0.9 × the standard application font size, of color #eaeaea,
standard weight, and should not contain any extra formatting.

In the body text, any string of one or more consecutive whitespace characters
that contains at least one newline (U+000D CARRIAGE RETURN (CR), U+000A LINE
FEED (LF), or U+000D CARRIAGE RETURN (CR) immediately followed by U+000A LINE
FEED (LF)), even if a mixture of those, should be treated as a single newline.
Then for each line in the text, any string of one or more consecutive
(non-newline) whitespace characters, even if a mixture of them, should be
treated as a single space, and leading and trailing whitespace should not be
presented.
======================


Something worth noting is that the notify-osd that's in Jaunty works fine, and
the one that's in Karmic currently also works fine. Just the notify-osd's in
between Jaunty and Karmic's release.

I think the bug should be marked invalid. It was notify-osd's fault to begin with.

--
Kind regards,
Chow Loong Jin



_______________________________________________
banshee-list mailing list
banshee-list@...
http://mail.gnome.org/mailman/listinfo/banshee-list