On Sat, 2008-07-12 at 11:40 -0600, Tom Tromey wrote:
> Note that I can only approve the libcpp bits.
That's OK. I've already got rs6000 and testsuite approval from David
and Janis.
> Ben> + if (ident == C_CPP_HASHNODE (vector_keyword) || ident == C_CPP_HASHNODE (__vector_keyword))
>
> Need to wrap these long lines.
Fixed.
> The libcpp parts are fine provided this change doesn't excessively
> impact code size or performance. Ordinarily I wouldn't look at this,
> but a similar patch of mine elsewhere got critiqued on this
> basis... so I know some other maintainers are thinking about it.
Thanks for the reminder about this. I checked and there is no
perceptible difference in memory consumption when compiling
insn-attrtab.o.
Committed.
Thanks, Ben
--
Ben Elliston <
bje@...>
Australia Development Lab, IBM
