« Return to Thread: PATCH: Small patches
Re: PATCH: Small patches
by Marco Antonio Gómez
::
Rate this Message:
Hi,
I am far from an SSE expert :)
I could see that Nebula implementation used some non-standard aspects,
that are only available in VC++.
However, current version of Nebula _is not using SSE_ (I do not know
the reason), even in Windows. You can check it for example in
mathlib/matrix.h:
#ifndef __USE_SSE__
#include "mathlib/_matrix33.h"
#include "mathlib/_matrix44.h"
typedef _matrix33 matrix33;
typedef _matrix44 matrix44;
#else
#include "mathlib/_matrix33_sse.h"
#include "mathlib/_matrix44_sse.h"
typedef _matrix33_sse matrix33;
typedef _matrix44_sse matrix44;
#endif
where __USE_SSE__ symbol is not defined by default.
As gcc had problems reading sse code, the patch I sent used the
__USE_SSE__ symbol, and only when defined the sse code was compiled.
Marco
Seika van Olstroem escribió:
> How can we solve the SSE issues? I'm not very familiar with that, but
> I'm willing to learn :), unfortunately I can't find any
> documentation/tutorial for gcc/g++ to use SSE.
>
> Is it worth to implement a custom SSE implementation, doesn't the
> compiler optimize such things correctly?
>
> 2007/3/13, Marco Antonio Gómez Martín <marcoa@...>:
>> Hi all,
>>
>>> The second patch was already mentioned before by marco, it adds an
>>> include for
>>> algorithm to narray.h. I'm not sure why it wasn't not yet within the
>>> SVN but I think
>>> something was wrong the way he tried to commit it.
>> Actually, I didn't commit the patches I sent, because I have no
>> user/password in SVN.
>> That's the reason why I sent the patches to the list, but I had no
>> answers :'( I hope you have more luck :-p
>>
>> By the way, I did not mention the error you solve in the makefile.py
>> patch, but I am agree with it, and I just hope someone commit it to the
>> repository...
>>
>> Marco
>>
>>> Please comment. :-)
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> Index: code/nebula2/inc/util/narray.h
>>> ===================================================================
>>> --- code/nebula2/inc/util/narray.h (Revision 3233)
>>> +++ code/nebula2/inc/util/narray.h (Arbeitskopie)
>>> @@ -17,6 +17,8 @@
>>> */
>>> #include "kernel/ntypes.h"
>>>
>>> +#include <algorithm>
>>> +
>>> //------------------------------------------------------------------------------
>>> template<class TYPE> class nArray
>>> {
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> Index: buildsys3/generators/makefile.py
>>> ===================================================================
>>> --- buildsys3/generators/makefile.py (Revision 3233)
>>> +++ buildsys3/generators/makefile.py (Arbeitskopie)
>>> @@ -107,7 +107,7 @@
>>> # spring clean
>>> makeFile.write("clean: \n")
>>> makeFile.write("\t$(RM) $(N_TARGETDIR)*\n")
>>> - makeFile.write("\t$(RM) $(N_INTERDIR)\n")
>>> + makeFile.write("\t$(RM) $(N_INTERDIR)*\n")
>>>
>>> makeFile.write("default: all\n")
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> -------------------------------------------------------------------------
>>> Take Surveys. Earn Cash. Influence the Future of IT
>>> Join SourceForge.net's Techsay panel and you'll get the chance to share your
>>> opinions on IT & business topics through brief surveys-and earn cash
>>> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> *** NOTE: To reply to the list use "reply to all", ***
>>> *** to reply direct to the sender use "reply" ***
>>> _______________________________________________
>>> Nebuladevice-discuss mailing list
>>> Nebuladevice-discuss@...
>>> https://lists.sourceforge.net/lists/listinfo/nebuladevice-discuss
>> -------------------------------------------------------------------------
>> Take Surveys. Earn Cash. Influence the Future of IT
>> Join SourceForge.net's Techsay panel and you'll get the chance to share your
>> opinions on IT & business topics through brief surveys-and earn cash
>> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>>
>> *** NOTE: To reply to the list use "reply to all", ***
>> *** to reply direct to the sender use "reply" ***
>> _______________________________________________
>> Nebuladevice-discuss mailing list
>> Nebuladevice-discuss@...
>> https://lists.sourceforge.net/lists/listinfo/nebuladevice-discuss
>>
>
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
*** NOTE: To reply to the list use "reply to all", ***
*** to reply direct to the sender use "reply" ***
_______________________________________________
Nebuladevice-discuss mailing list
Nebuladevice-discuss@...
https://lists.sourceforge.net/lists/listinfo/nebuladevice-discuss
I am far from an SSE expert :)
I could see that Nebula implementation used some non-standard aspects,
that are only available in VC++.
However, current version of Nebula _is not using SSE_ (I do not know
the reason), even in Windows. You can check it for example in
mathlib/matrix.h:
#ifndef __USE_SSE__
#include "mathlib/_matrix33.h"
#include "mathlib/_matrix44.h"
typedef _matrix33 matrix33;
typedef _matrix44 matrix44;
#else
#include "mathlib/_matrix33_sse.h"
#include "mathlib/_matrix44_sse.h"
typedef _matrix33_sse matrix33;
typedef _matrix44_sse matrix44;
#endif
where __USE_SSE__ symbol is not defined by default.
As gcc had problems reading sse code, the patch I sent used the
__USE_SSE__ symbol, and only when defined the sse code was compiled.
Marco
Seika van Olstroem escribió:
> How can we solve the SSE issues? I'm not very familiar with that, but
> I'm willing to learn :), unfortunately I can't find any
> documentation/tutorial for gcc/g++ to use SSE.
>
> Is it worth to implement a custom SSE implementation, doesn't the
> compiler optimize such things correctly?
>
> 2007/3/13, Marco Antonio Gómez Martín <marcoa@...>:
>> Hi all,
>>
>>> The second patch was already mentioned before by marco, it adds an
>>> include for
>>> algorithm to narray.h. I'm not sure why it wasn't not yet within the
>>> SVN but I think
>>> something was wrong the way he tried to commit it.
>> Actually, I didn't commit the patches I sent, because I have no
>> user/password in SVN.
>> That's the reason why I sent the patches to the list, but I had no
>> answers :'( I hope you have more luck :-p
>>
>> By the way, I did not mention the error you solve in the makefile.py
>> patch, but I am agree with it, and I just hope someone commit it to the
>> repository...
>>
>> Marco
>>
>>> Please comment. :-)
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> Index: code/nebula2/inc/util/narray.h
>>> ===================================================================
>>> --- code/nebula2/inc/util/narray.h (Revision 3233)
>>> +++ code/nebula2/inc/util/narray.h (Arbeitskopie)
>>> @@ -17,6 +17,8 @@
>>> */
>>> #include "kernel/ntypes.h"
>>>
>>> +#include <algorithm>
>>> +
>>> //------------------------------------------------------------------------------
>>> template<class TYPE> class nArray
>>> {
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> Index: buildsys3/generators/makefile.py
>>> ===================================================================
>>> --- buildsys3/generators/makefile.py (Revision 3233)
>>> +++ buildsys3/generators/makefile.py (Arbeitskopie)
>>> @@ -107,7 +107,7 @@
>>> # spring clean
>>> makeFile.write("clean: \n")
>>> makeFile.write("\t$(RM) $(N_TARGETDIR)*\n")
>>> - makeFile.write("\t$(RM) $(N_INTERDIR)\n")
>>> + makeFile.write("\t$(RM) $(N_INTERDIR)*\n")
>>>
>>> makeFile.write("default: all\n")
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> -------------------------------------------------------------------------
>>> Take Surveys. Earn Cash. Influence the Future of IT
>>> Join SourceForge.net's Techsay panel and you'll get the chance to share your
>>> opinions on IT & business topics through brief surveys-and earn cash
>>> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> *** NOTE: To reply to the list use "reply to all", ***
>>> *** to reply direct to the sender use "reply" ***
>>> _______________________________________________
>>> Nebuladevice-discuss mailing list
>>> Nebuladevice-discuss@...
>>> https://lists.sourceforge.net/lists/listinfo/nebuladevice-discuss
>> -------------------------------------------------------------------------
>> Take Surveys. Earn Cash. Influence the Future of IT
>> Join SourceForge.net's Techsay panel and you'll get the chance to share your
>> opinions on IT & business topics through brief surveys-and earn cash
>> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>>
>> *** NOTE: To reply to the list use "reply to all", ***
>> *** to reply direct to the sender use "reply" ***
>> _______________________________________________
>> Nebuladevice-discuss mailing list
>> Nebuladevice-discuss@...
>> https://lists.sourceforge.net/lists/listinfo/nebuladevice-discuss
>>
>
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
*** NOTE: To reply to the list use "reply to all", ***
*** to reply direct to the sender use "reply" ***
_______________________________________________
Nebuladevice-discuss mailing list
Nebuladevice-discuss@...
https://lists.sourceforge.net/lists/listinfo/nebuladevice-discuss
« Return to Thread: PATCH: Small patches
| Free embeddable forum powered by Nabble | Forum Help |
