Tatsuro MATSUOKA wrote:
> Hello
>
> After discussion with Vadim Zeitlin, who is one of the developer of wxWidget, in the following address
>
>
http://groups.google.co.jp/group/wx-dev/browse_thread/thread/65a3af28e9a21bca/89264cf1c66e16f3#89264cf1c66e16f3>
> I consider two different patch. First one, 'makefile.mgw.1.patch' is the same as that I have proposed
> in the previous post.
> Second one is add overrideng option to when PIPES flag is on: 'makefile.mgw.2.patch'
>
> First patch:
> - WX_LIBS = $(shell wx-config --libs)
> + WX_LIBS = $(shell wx-config --libs | sed -e 's/ -Wl,--subsystem,windows -mwindows//')
> This removes '-Wl,--subsystem,windows -mwindows' flag
I'd propose a more robust version like
sed -e "s+-Wl,--subsystem,windows++g" -e "s+-mwindows++g"
Removing should not be dependent on spaces and the actual order of the
erroneus commands.
> Second patch:
> WX_LIBS = $(shell wx-config --libs)
> + ifdef PIPES
> + WX_LIBS += -Wl,--subsystem,console
> + endif
> add overrideing option for gnuplot.exe and wgnuplot_pipes.exe
>
> I cannot figure out which is better. Please discuss this matter and produce better patch.
> Of course, more smart ideas are highly welcome.
The former. The latter looks wrong and is highly unportable as it
depends on the order of the flags on the command line and their
interpreation by binutils.
benjamin
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf_______________________________________________
gnuplot-beta mailing list
gnuplot-beta@...
https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
