Le dimanche 26 avril 2009, Carlos Licea a écrit :
> Hi list,
> I had forgotten to submit this patch.
> Now i believe it should be safe enough to commit.
> Also I'm tired of this code, so I'll stop my work for now and start
> implementing the DOM Level 3 XPath specification.
Hi Carlos,
this looks excellent to me.
It passes all testcases I can throw at it, and keeps the regression test suite
happy.
If you recall, I had concerns about whether this could be applied in all
rendering modes, seeing how Opera does make a distinction - but I now think
we may try this in all modes - seeing the old HTML2 meaning of
colspan/rowspan zero seems hardly ever used anywhere.
All I'm left to comment about is typos, otherwise I think its ripe for
commit.. ;)
+ * (C) 2009 Carlos Licea (
carlos.licea@...
missing parenthesis at end of line
+ //What:Postion the cell
missing 'i'
+ //How: we take care of special case when colspan or rowspan equals 0
+ //after that position the cell, that is just to tell where is it and tell
+ //other cells where they can't be located (marking the cells as -1)
Up to here, all good. But the three lines below don't bring much clarity I
think... maybe replace them with a link to the relevant section of the HTML
4.01 specification?
+ //later taking the span into account (and in other function) the cell is
+ //then painted (that's why we need to set the colspan and rowspan properly
+ //when any of them is cero
cero -> zero
Thank you for implementing a tricky bit of HTML 4, that no other engine ever
managed to implement correctly yet.
Greetings,
Germain
P.S: also please remove/comment the debug statements before commiting, as they
are a bit noisy.
