Re: Perp mistakes.

On 13-Apr-09, at 2:55 PM, Dudás Zsolt wrote:

> I got some mistakes in the system.
>
> 1.       in line 369 in class.ui_perp_work_order.inc.php you use  
> „'pseudo'                       =>          false, „
>  but php handle badly. Correct solution is :  
> „'pseudo'                    =>          0,  „

Please be more specific as to 'badly'.  Error message, where it goes  
wrong.
The string 'false' is specifically handled by the AJAX select widget, /
etemplate/inc/class.ajax_select_widget.inc.php, line 278, so the two  
should be equivalent.

> this is couse of you can’t add new product to work order (only  
> pseudo product.).

You can't add pseudo items to a work order, they're not 'real' items  
that can go into inventory when the work order is done.
Should this maybe a site configuration setting, to allow pseudo items  
onto a work order?

> 2.       in ooo.inc.php line 380.
> bad:      unlink($this->_tempdir.'/'.$this->_xml_filename);
>                $zip->close();
>
>  first should $zip->close, then  delete it.  (cannot remove xml file  
> …. message from php in report document. only windows php version.)
> good:                   $zip->close();
>                              unlink($this->_tempdir.'/'.$this-
> >_xml_filename);

Committed, thanks.

> 3.       class.bo_perp_price.inc.php line 99
> should add this two lines:
> if (!$query['start']) $query['start']=0;
> if (!$query['num_rows']) $query['num_rows'] =9999;
> because php’s Array_slice function returns null if second parameter  
> is empty. this is cause of you can’t edit price lists.

start added, num_rows set to the preferred number of rows rather than  
9999.

> 4.         my language is use multibyte character set. this is  
> problem for tbs system. I changed it multibyte version of TBS. I  
> send you by attached file.

I'm glad to see this one, I think others will be as well.

> I hope I help you. This is the best erp system I have ever seen .
>
> Best regards Zsolt.

Thank you for your contributions.

Nathan Gray
nathan at goarctic dot com


------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
Perp-developers mailing list
Perp-developers@...
https://lists.sourceforge.net/lists/listinfo/perp-developers