Re: Quickquote: new line feature

[Daniel W. Steinbrook]

Thank you, Ulrich! This is the true spirit of open source -- if a feature
isn't there, take the code and implement it yourself. This takes a
much-requested feature off the ever-growing QuickQuote todo list. Much
appreciated!

- Daniel W. Steinbrook


On Wednesday 13 June 2007 06:58:28 am you wrote:

> Hi developers of quickquote,
>
> I thought it would be nice to have a new line
> feature in your very very usefull extension.
>
> So I made one. Just have a look in the attached
> quickquoteOverlay2.js.
>
> Look for "// inserted by sunfish" at line 361
> ant beyond the new function newLine().
>
> It seemed to me the best, to replace %n at the
> very last process of prefs.phrase. Are line
> breaks inserted before, there are troubles with
> quoting.
>
> For example:
> ---------------------------------------------
> Hi %author,%n %n author wrote at %date %time:
> ---------------------------------------------
>
> is changed to
> ---------------------------------------------
> Hi Dan,
>
> Dan wrote at 13.th of June 13:02:
> ---------------------------------------------
>
> Just for Information:
> One blank before an after "%n" is deleted.
>
>
> Maybe you can use this snippet.
> I think it is quite useful.
>
> Greetings form Germany
>
> Ulrich

_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote

[tanstaafl-2]

Daniel W. Steinbrook, on 6/13/2007 2:00 PM, said the following:
> Thank you, Ulrich! This is the true spirit of open source -- if a
> feature isn't there, take the code and implement it yourself. This
> takes a much-requested feature off the ever-growing QuickQuote todo
> list. Much appreciated!

Cool!

Will you be updating the extension, or do we have to do this manually
somehow?

I've been wanting that for a while...

Thanks Ulrich (and Daniel)!

Charles
_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote

[Daniel W. Steinbrook]

Hmm, I could do some sort of 0.8.1 release...I was waiting until I had
completed some other tweaks before doing a minor release, but I seem to have
forgotten what's gone into CVS since 0.8, so perhaps this would be a good
idea. (I also want to rework the home page description...it's starting to
sound a little sketchy, to use American slang.)

I'll send out another message when I've put everything together.

- Daniel W. Steinbrook


On Wednesday 13 June 2007 03:47:16 pm Charles Marcus wrote:

> Daniel W. Steinbrook, on 6/13/2007 2:00 PM, said the following:
> > Thank you, Ulrich! This is the true spirit of open source -- if a
> > feature isn't there, take the code and implement it yourself. This
> > takes a much-requested feature off the ever-growing QuickQuote todo
> > list. Much appreciated!
>
> Cool!
>
> Will you be updating the extension, or do we have to do this manually
> somehow?
>
> I've been wanting that for a while...
>
> Thanks Ulrich (and Daniel)!
>
> Charles

_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote

[tanstaafl-2]

Daniel W. Steinbrook, on 6/13/2007 3:55 PM, said the following:
> Hmm, I could do some sort of 0.8.1 release...I was waiting until I had
> completed some other tweaks before doing a minor release, but I seem to have
> forgotten what's gone into CVS since 0.8, so perhaps this would be a good
> idea. (I also want to rework the home page description...it's starting to
> sound a little sketchy, to use American slang.)
>
> I'll send out another message when I've put everything together.

I look forward to it - and thanks!
_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote

[Daniel W. Steinbrook]

OK, so I committed Ulrich's modifications to CVS, but I'm still
tinkering with some other stuff. Attached is QuickQuote 0.8 for TB and
SM, plus his modifications and the relatively recent Polish
localization. More changes coming soon.

- Daniel W. Steinbrook


On 6/13/07, Charles Marcus <tanstaafl@...> wrote:

> Daniel W. Steinbrook, on 6/13/2007 3:55 PM, said the following:
> > Hmm, I could do some sort of 0.8.1 release...I was waiting until I had
> > completed some other tweaks before doing a minor release, but I seem to have
> > forgotten what's gone into CVS since 0.8, so perhaps this would be a good
> > idea. (I also want to rework the home page description...it's starting to
> > sound a little sketchy, to use American slang.)
> >
> > I'll send out another message when I've put everything together.
>
> I look forward to it - and thanks!
>

_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote

[tanstaafl-2]

Daniel W. Steinbrook, on 6/14/2007 10:27 AM, said the following:
> OK, so I committed Ulrich's modifications to CVS, but I'm still
> tinkering with some other stuff. Attached is QuickQuote 0.8 for TB and
> SM, plus his modifications and the relatively recent Polish
> localization. More changes coming soon.

Cool! I'll let you know how it works...

Thanks!
_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote

[tanstaafl-2]

Daniel W. Steinbrook, on 6/14/2007 10:27 AM, said the following:
> OK, so I committed Ulrich's modifications to CVS, but I'm still
> tinkering with some other stuff. Attached is QuickQuote 0.8 for TB and
> SM, plus his modifications and the relatively recent Polish
> localization. More changes coming soon.

Hmmm...

Ok, initial feedback... it isn't working as expected...

The prior version had only two blank lines between the quoted text and
my sig - one line too few (for me), as I like a blank line between the
quoted text and my reply.

Also I'm a bottom-poster, so have my reply configured to come after the
quoted text. With the old version of QQ, it looked like this:

Author, on Date/Time, said the following:
 > quoted text


-- <-- sig delimeter

Best regards,  |\
                  > both of these lines highlighted
Charles        |/

(see attached screenshot)

If I add lines below my name, like, phone numbers, it is always the last
two lines of text that is highlighted. With only my name (as in the
screenshot), it is the last two lines of text, even though there is a
blank line between them.

As you can see, there are only two lines between the quoted text and my
sig. I'd like three.

Of course, I'd also like to be able to tell the cursor where to go -
right now, for some reason, the last two lines of text in my sig are
selected/highlighted (again, see attached screenshot - this is exactly
what it looks like), and I have to manually click into the line right
after the quoted text and then hit 'Enter', then I can start typing my
reply.

I'm fairly used to this, so it isn't that big a deal, but it would be
really nice if it worked correctly:

Author, on Date/Time, said the following:
 > quoted text

| <- cursor here, ready to type

-- <-- sig delimeter

Best regards,

Charles

Hope that was understandable...
_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote

[Daniel W. Steinbrook]

There was no screenshot attached to that message, but I'm seeing what
you're saying. With the message set to start above the quote (as I
usually do), it seems to work perfectly fine, but with the message
below the quote, part of the signature is highlighted. I have no idea
why the number of blank lines before the signature would change. #@$#!
regressions. As Thunderbird becomes more complex, more simple parts of
QuickQuote seem to start misbehaving. Still, thank you for this
important information.

- Daniel W. Steinbrook


On 6/14/07, Charles Marcus <tanstaafl@...> wrote:

> Daniel W. Steinbrook, on 6/14/2007 10:27 AM, said the following:
> > OK, so I committed Ulrich's modifications to CVS, but I'm still
> > tinkering with some other stuff. Attached is QuickQuote 0.8 for TB and
> > SM, plus his modifications and the relatively recent Polish
> > localization. More changes coming soon.
>
> Hmmm...
>
> Ok, initial feedback... it isn't working as expected...
>
> The prior version had only two blank lines between the quoted text and
> my sig - one line too few (for me), as I like a blank line between the
> quoted text and my reply.
>
> Also I'm a bottom-poster, so have my reply configured to come after the
> quoted text. With the old version of QQ, it looked like this:
>
> Author, on Date/Time, said the following:
>  > quoted text
>
>
> -- <-- sig delimeter
>
> Best regards,  |\
>                   > both of these lines highlighted
> Charles        |/
>
> (see attached screenshot)
>
> If I add lines below my name, like, phone numbers, it is always the last
> two lines of text that is highlighted. With only my name (as in the
> screenshot), it is the last two lines of text, even though there is a
> blank line between them.
>
> As you can see, there are only two lines between the quoted text and my
> sig. I'd like three.
>
> Of course, I'd also like to be able to tell the cursor where to go -
> right now, for some reason, the last two lines of text in my sig are
> selected/highlighted (again, see attached screenshot - this is exactly
> what it looks like), and I have to manually click into the line right
> after the quoted text and then hit 'Enter', then I can start typing my
> reply.
>
> I'm fairly used to this, so it isn't that big a deal, but it would be
> really nice if it worked correctly:
>
> Author, on Date/Time, said the following:
>  > quoted text
>
> | <- cursor here, ready to type
>
> -- <-- sig delimeter
>
> Best regards,
>
> Charles
>
> Hope that was understandable...
>

_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote

[tanstaafl-2]

Forgot the attachment too... <sigh> let's try this again...

Daniel W. Steinbrook, on 6/14/2007 10:27 AM, said the following:
> OK, so I committed Ulrich's modifications to CVS, but I'm still
> tinkering with some other stuff. Attached is QuickQuote 0.8 for TB and
> SM, plus his modifications and the relatively recent Polish
> localization. More changes coming soon.

Hmmm...

Ok, initial feedback... it isn't working as expected...

The prior version had only two blank lines between the quoted text and
my sig - one line too few (for me), as I like a blank line between the
quoted text and my reply. With this version, when I add a %n in the
'After quoted text' box to add a third blank line, it actually adds TWO
new lines, not just one - so, instead of three lines between the quoted
text and my sig, there are FOUR...

Also I'm a bottom-poster, so have my reply configured to come after the
quoted text. With the old version of QQ, it looked like this:

Author, on Date/Time, said the following:
> quoted text


-- <-- sig delimeter

Best regards,  |\
                  > both of these lines highlighted
Charles        |/

(see attached screenshot)

If I add lines below my name, like, phone numbers, it is always the last
two lines of text that is highlighted. With only my name (as in the
screenshot), it is the last two lines of text, even though there is a
blank line between them.

As you can see, there are only two lines between the quoted text and my
sig. I'd like three.

Of course, I'd also like to be able to tell the cursor where to go -
right now, for some reason, the last two lines of text in my sig are
selected/highlighted (again, see attached screenshot - this is exactly
what it looks like), and I have to manually click into the line right
after the quoted text and then hit 'Enter', then I can start typing my
reply.

I'm fairly used to this, so it isn't that big a deal, but it would be
really nice if it worked correctly:

Author, on Date/Time, said the following:
> quoted text

| <- cursor here, ready to type

-- <-- sig delimeter

Best regards,

Charles

Hope that was understandable...



_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote

[Daniel W. Steinbrook]

Ah, gotcha. It looks like one blank line comes from the TB's default
signature behavior. Furthermore, since QuickQuote was already set (I
think) to put padding around whatever came afterwards, padding around
a blank line is more blank space. How humorous.

- Daniel W. Steinbrook


On 6/14/07, Charles Marcus <tanstaafl@...> wrote:

> Forgot the attachment too... <sigh> let's try this again...
>
> Daniel W. Steinbrook, on 6/14/2007 10:27 AM, said the following:
> > OK, so I committed Ulrich's modifications to CVS, but I'm still
> > tinkering with some other stuff. Attached is QuickQuote 0.8 for TB and
> > SM, plus his modifications and the relatively recent Polish
> > localization. More changes coming soon.
>
> Hmmm...
>
> Ok, initial feedback... it isn't working as expected...
>
> The prior version had only two blank lines between the quoted text and
> my sig - one line too few (for me), as I like a blank line between the
> quoted text and my reply. With this version, when I add a %n in the
> 'After quoted text' box to add a third blank line, it actually adds TWO
> new lines, not just one - so, instead of three lines between the quoted
> text and my sig, there are FOUR...
>
> Also I'm a bottom-poster, so have my reply configured to come after the
> quoted text. With the old version of QQ, it looked like this:
>
> Author, on Date/Time, said the following:
> > quoted text
>
>
> -- <-- sig delimeter
>
> Best regards,  |\
>                   > both of these lines highlighted
> Charles        |/
>
> (see attached screenshot)
>
> If I add lines below my name, like, phone numbers, it is always the last
> two lines of text that is highlighted. With only my name (as in the
> screenshot), it is the last two lines of text, even though there is a
> blank line between them.
>
> As you can see, there are only two lines between the quoted text and my
> sig. I'd like three.
>
> Of course, I'd also like to be able to tell the cursor where to go -
> right now, for some reason, the last two lines of text in my sig are
> selected/highlighted (again, see attached screenshot - this is exactly
> what it looks like), and I have to manually click into the line right
> after the quoted text and then hit 'Enter', then I can start typing my
> reply.
>
> I'm fairly used to this, so it isn't that big a deal, but it would be
> really nice if it worked correctly:
>
> Author, on Date/Time, said the following:
> > quoted text
>
> | <- cursor here, ready to type
>
> -- <-- sig delimeter
>
> Best regards,
>
> Charles
>
> Hope that was understandable...
>
>
>

_______________________________________________
QuickQuote mailing list
QuickQuote@...
http://mozdev.org/mailman/listinfo/quickquote