Re: Review Request: Redesign Window Switcher layout design

Updated May 14, 2012, 6:49 p.m.

About scaling: did you consider some (eg hover selecting) name or "icon" list and a preview box?
Right now you have to scroll through some eventually long list or know what you're looking for.
LayoutConfig::LayoutConfig(QWidget* parent)
LayoutConfig::LayoutConfig(const QString& layoutName, QWidget* parent)
    setMinimumSize(QSize(500, 500));
    QWidget::setLayout(vboxLayout);
passing a widget parameter sets the layout - the overloaded ::setLayout() does not break this, does it?
LayoutConfig::LayoutConfig(QWidget* parent)
LayoutConfig::LayoutConfig(const QString& layoutName, QWidget* parent)
    if (QObject *item = rootObject()->findChild<QObject*>("view")) {
    m_declarativeView->rootObject()->setProperty("currentIndex", row);
bug?
::selectedLayout() below still checks the "view" object (and so seems qml)
Redesign Window Switcher layout design

Complete rewrite of the dialog to select the window switcher
layout to fix the usability and scalability issues of the
existing implementation:
* added search functionality through QSortFilterProxyModel
* increased the dialog size to better render large layouts
* added scrollbar from decoration kcm
* "normal" list background and selection instead of window
  background
* only show one preview at a time

BUG: 299278
FIXED-IN: 4.9.0
current remaining issues:
* small icons looks really bad
* initial selected layout is broken, fixed after forced re-rendering
* grid layout does not use all available space
* highlight moves too slow

Re: Review Request: Redesign Window Switcher layout design

Description

Testing

Diffs

Screenshots

kwin/kcmkwin/kwintabbox/layoutconfig.cpp (Diff revision 1)
LayoutConfig::LayoutConfig(QWidget* parent)		LayoutConfig::LayoutConfig(const QString& layoutName, QWidget* parent)
52	setMinimumSize(QSize(500, 500));	55	QWidget::setLayout(vboxLayout);