On May 14th, 2012, 9:48 p.m., Thomas Lübking wrote:

kwin/kcmkwin/kwintabbox/layoutconfig.cpp (Diff revision 1)
LayoutConfig::LayoutConfig(QWidget* parent)		LayoutConfig::LayoutConfig(const QString& layoutName, QWidget* parent)
52	setMinimumSize(QSize(500, 500));	55	QWidget::setLayout(vboxLayout);

passing a widget parameter sets the layout - the overloaded ::setLayout() does not break this, does it?

On May 15th, 2012, 4:37 a.m., Martin Gräßlin wrote:

I changed it to QWidget::setLayout due to compile error.

On May 15th, 2012, 6:49 a.m., Thomas Lübking wrote:

i meant that calling ::setLayout should not be necessary in the first place, yesno?

On May 15th, 2012, 3:47 p.m., Martin Gräßlin wrote:

it is, with setLayout(vboxLayout); we get:

/home/martin/kdesrc/kde/kde-workspace/kwin/kcmkwin/kwintabbox/layoutconfig.cpp: In constructor ‘KWin::TabBox::LayoutConfig::LayoutConfig(const QString&, QWidget*)’:
/home/martin/kdesrc/kde/kde-workspace/kwin/kcmkwin/kwintabbox/layoutconfig.cpp:55:25: error: no matching function for call to ‘KWin::TabBox::LayoutConfig::setLayout(QVBoxLayout*&)’
/home/martin/kdesrc/kde/kde-workspace/kwin/kcmkwin/kwintabbox/layoutconfig.cpp:55:25: note: candidate is:
/home/martin/kdesrc/kde/kde-workspace/kwin/kcmkwin/kwintabbox/layoutconfig.h:43:10: note: void KWin::TabBox::LayoutConfig::setLayout(const QString&)
/home/martin/kdesrc/kde/kde-workspace/kwin/kcmkwin/kwintabbox/layoutconfig.h:43:10: note:   no known conversion for argument 1 from ‘QVBoxLayout*’ to ‘const QString&’

=)
i didn't mean the explicit base call, but the entire call - creatin a layout on a widget should set that layout on the widget anyway, so actually the line should be superfluous and that confused me.

- Thomas

On May 14th, 2012, 6:49 p.m., Martin Gräßlin wrote:

Review request for kwin. By Martin Gräßlin. Updated May 14, 2012, 6:49 p.m. Description Redesign Window Switcher layout design Complete rewrite of the dialog to select the window switcher layout to fix the usability and scalability issues of the existing implementation: * added search functionality through QSortFilterProxyModel * increased the dialog size to better render large layouts * added scrollbar from decoration kcm * "normal" list background and selection instead of window background * only show one preview at a time BUG: 299278 FIXED-IN: 4.9.0 Testing current remaining issues: * small icons looks really bad * initial selected layout is broken, fixed after forced re-rendering * grid layout does not use all available space * highlight moves too slow Bugs: 299278 Diffs kwin/kcmkwin/kwindecoration/CMakeLists.txt (4762bb983b8e431daaf3a2e600d460e2186a870b) kwin/kcmkwin/kwintabbox/layoutconfig.h (a83574ad170a80efefa123061d8dc77687ef5cfb) kwin/kcmkwin/kwintabbox/layoutconfig.cpp (b2a426685ace2e0c4a76258ff1c05c7a105d0e92) kwin/kcmkwin/kwintabbox/main.cpp (bb705dbfc911a9b718821ac43e70196cef31f430) kwin/kcmkwin/kwintabbox/qml/main.qml (8858e208c9f45c9d9836210f51a5324687c10c92) View Diff Screenshots